From: ivan <ivan>
Date: Wed, 9 Jul 2008 20:37:20 +0000 (+0000)
Subject: should avoid spurious uninitialized value warnings on upgrade
X-Git-Tag: freeside_1_7_4rc1~246
X-Git-Url: http://git.freeside.biz/gitweb/?a=commitdiff_plain;h=a4d37dd27a244461cd8bcc23c898a4040766189d;p=freeside.git

should avoid spurious uninitialized value warnings on upgrade
---

diff --git a/FS/FS/part_pkg.pm b/FS/FS/part_pkg.pm
index 7acada538..6ff1fbb9c 100644
--- a/FS/FS/part_pkg.pm
+++ b/FS/FS/part_pkg.pm
@@ -376,7 +376,12 @@ sub replace {
   my $pkg_svc = $options{'pkg_svc'} || {};
   foreach my $part_svc ( qsearch('part_svc', {} ) ) {
     my $quantity = $pkg_svc->{$part_svc->svcpart} || 0;
-    my $primary_svc = $options{'primary_svc'} == $part_svc->svcpart ? 'Y' : '';
+    my $primary_svc =
+      ( defined($options{'primary_svc'})
+        && $options{'primary_svc'} == $part_svc->svcpart
+      )
+        ? 'Y'
+        : '';
 
     my $old_pkg_svc = qsearchs('pkg_svc', {
       'pkgpart' => $old->pkgpart,