From: ivan <ivan>
Date: Wed, 11 Aug 2010 21:54:24 +0000 (+0000)
Subject: at least show an error for bad pkgparts instead of a hang, RT#9578
X-Git-Tag: freeside_1_9_5~69
X-Git-Url: http://git.freeside.biz/gitweb/?a=commitdiff_plain;h=9ce4ac30dbe0c3213836081ed44f5f515c59a338;p=freeside.git

at least show an error for bad pkgparts instead of a hang, RT#9578
---

diff --git a/FS/FS/cust_main/Import.pm b/FS/FS/cust_main/Import.pm
index 901ff18ae..e2165a096 100644
--- a/FS/FS/cust_main/Import.pm
+++ b/FS/FS/cust_main/Import.pm
@@ -328,6 +328,12 @@ sub batch_import {
     tie my %hash, 'Tie::RefHash'; #this part is important
 
     if ( $cust_pkg{'pkgpart'} ) {
+
+      unless ( $cust_pkg{'pkgpart'} =~ /^\d+$/ ) {
+        $dbh->rollback if $oldAutoCommit;
+        return 'illegal pkgpart: '. $cust_pkg{'pkgpart'};
+      }
+
       my $cust_pkg = new FS::cust_pkg ( \%cust_pkg );
 
       my @svc_x = ();