From: Mark Wells <mark@freeside.biz>
Date: Fri, 22 Apr 2016 17:21:22 +0000 (-0700)
Subject: fix apportionment of flat fees on zero-charge invoices, #39816
X-Git-Url: http://git.freeside.biz/gitweb/?a=commitdiff_plain;h=9b6a030dbbf8be7f23f1795f3164da0a5a42b08b;p=freeside.git

fix apportionment of flat fees on zero-charge invoices, #39816
---

diff --git a/FS/FS/part_fee.pm b/FS/FS/part_fee.pm
index 0ca52a096..1d4682c1e 100644
--- a/FS/FS/part_fee.pm
+++ b/FS/FS/part_fee.pm
@@ -402,7 +402,8 @@ sub lineitem {
 
   # if this is a percentage fee and has line item fractions,
   # adjust them to be proportional and to add up correctly.
-  if ( @item_base ) {
+  # don't try this if we're charging on a zero-amount set of line items.
+  if ( scalar(@item_base) > 0 and $total_base > 0 ) {
     my $cents = $amount * 100;
     # not necessarily the same as percent
     my $multiplier = $amount / $total_base;