From: mark <mark>
Date: Sat, 19 Dec 2009 20:58:13 +0000 (+0000)
Subject: Fix date format string and quoting of password
X-Git-Tag: freeside_1_9_2~176
X-Git-Url: http://git.freeside.biz/gitweb/?a=commitdiff_plain;h=7c9f392d3cdcec081bdeb01f4c9f65b7cc667a78;p=freeside.git

Fix date format string and quoting of password
---

diff --git a/FS/FS/pay_batch/paymentech.pm b/FS/FS/pay_batch/paymentech.pm
index b75f256e6..d62a1f11f 100644
--- a/FS/FS/pay_batch/paymentech.pm
+++ b/FS/FS/pay_batch/paymentech.pm
@@ -66,7 +66,7 @@ my %paytype = (
     $xml->startTag('transRequest', RequestCount => scalar(@cust_pay_batch) + 1);
     $xml->startTag('batchFileID');
     $xml->dataElement(userID => $username);
-    $xml->dataElement(fileDateTime => time2str('%Y%m%d%H%M%s', time));
+    $xml->dataElement(fileDateTime => time2str('%Y%m%d%H%M%S', time));
     $xml->dataElement(fileID => 'FILEID');
     $xml->endTag('batchFileID');
 
diff --git a/FS/bin/freeside-paymentech-download b/FS/bin/freeside-paymentech-download
index 293db8420..16ac3c23b 100755
--- a/FS/bin/freeside-paymentech-download
+++ b/FS/bin/freeside-paymentech-download
@@ -68,7 +68,7 @@ BATCH: foreach my $filename (@files) {
   }
 
   #unzip file
-  system('unzip', '-P', '$password', '-q',
+  system('unzip', '-P', $password, '-q',
            "$tmpdir/${filename}_resp.zip", '-d', $tmpdir);
   if(! -f "$tmpdir/${filename}_resp.xml") {
     warn "failed to extract ${filename}_resp.xml from ${filename}_resp.zip\n";
diff --git a/FS/bin/freeside-paymentech-upload b/FS/bin/freeside-paymentech-upload
index 42bd278c1..06bef68be 100755
--- a/FS/bin/freeside-paymentech-upload
+++ b/FS/bin/freeside-paymentech-upload
@@ -63,7 +63,7 @@ foreach my $pay_batch (@batches) {
   print OUT $text;
   close OUT;
 
-  system('zip', '-P', '$password', '-q', '-j',
+  system('zip', '-P', $password, '-q', '-j',
            "$tmpdir/$filename.zip", "$tmpdir/$filename.xml");
 
   die "failed to create zip file\n" if (! -f "$tmpdir/$filename.zip" );