From: Ivan Kohler <ivan@freeside.biz>
Date: Fri, 25 Mar 2016 19:29:36 +0000 (-0700)
Subject: avoid uninitialized value errors on upgrade
X-Git-Url: http://git.freeside.biz/gitweb/?a=commitdiff_plain;h=650682d61cb09233b106c83d50259e8bd7acee20;p=freeside.git

avoid uninitialized value errors on upgrade
---

diff --git a/FS/FS/Upgrade.pm b/FS/FS/Upgrade.pm
index 2841981fa..1aae55d87 100644
--- a/FS/FS/Upgrade.pm
+++ b/FS/FS/Upgrade.pm
@@ -203,8 +203,9 @@ sub upgrade_overlimit_groups {
 sub upgrade_invoice_from {
   my ($conf, $agentnum, $agentonly) = @_;
   if (
-      (!$conf->exists('invoice_from_name',$agentnum,$agentonly)) && 
-      ($conf->config('invoice_from',$agentnum,$agentonly) =~ /\<(.*)\>/)
+          ! $conf->exists('invoice_from_name',$agentnum,$agentonly)
+       && $conf->exists('invoice_from',$agentnum,$agentonly)
+       && $conf->config('invoice_from',$agentnum,$agentonly) =~ /\<(.*)\>/
   ) {
     my $realemail = $1;
     $realemail =~ s/^\s*//; # remove leading spaces