From: ivan <ivan>
Date: Tue, 7 Oct 2008 00:09:05 +0000 (+0000)
Subject: when setting last_login/last_logout, ensure only accounts actually attached to the... 
X-Git-Tag: freeside_1_7_4rc1~169
X-Git-Url: http://git.freeside.biz/gitweb/?a=commitdiff_plain;h=5e8fd96c0a0dc70b3e6afea20aa619821cc123cf;p=freeside.git

when setting last_login/last_logout, ensure only accounts actually attached to the export are updated
---

diff --git a/FS/FS/Upgrade.pm b/FS/FS/Upgrade.pm
index 4024ab8b9..7a284ddbe 100644
--- a/FS/FS/Upgrade.pm
+++ b/FS/FS/Upgrade.pm
@@ -186,17 +186,24 @@ sub upgrade_sqlradius {
       my ($username, $realm, $start, $stop) = @$row;
   
       $username = lc($username) unless $conf->exists('username-uppercase');
-      my $extra_sql = '';
+
+      my $exportnum = $part_export->exportnum;
+      my $extra_sql = " AND exportnum = $exportnum ".
+                      " AND exportsvcnum IS NOT NULL ";
+
       if ( ref($part_export) =~ /withdomain/ ) {
-        $extra_sql = " And '$realm' = ( SELECT domain FROM svc_domain
+        $extra_sql = " AND '$realm' = ( SELECT domain FROM svc_domain
                          WHERE svc_domain.svcnum = svc_acct.domsvc ) ";
       }
   
-      my $svc_acct = qsearchs( 'svc_acct',
-                               { 'username' => $username },
-                               '',
-                               $extra_sql,
-                             );
+      my $svc_acct = qsearchs({
+        'table'     => 'svc_acct.*',
+        'addl_from' => 'LEFT JOIN cust_svc   USING ( svcnum )'.
+                       'LEFT JOIN export_svc USING ( svcpart )',
+        'hashref'   => { 'username' => $username },
+        'extra_sql' => $extra_sql,
+      });
+
       if ($svc_acct) {
         $svc_acct->last_login($start)
           if $start && (!$svc_acct->last_login || $start > $svc_acct->last_login);