From: ivan <ivan>
Date: Mon, 20 Jun 2011 23:50:52 +0000 (+0000)
Subject: some debugging for prepaid card generation, and retry more, RT#13329
X-Git-Tag: freeside_2_3_0~103
X-Git-Url: http://git.freeside.biz/gitweb/?a=commitdiff_plain;h=44ce5ab2e8edd012154d3bb7e5711341e8c6cf35;p=freeside.git

some debugging for prepaid card generation, and retry more, RT#13329
---

diff --git a/FS/FS/prepay_credit.pm b/FS/FS/prepay_credit.pm
index e5773aebd..c93999c6d 100644
--- a/FS/FS/prepay_credit.pm
+++ b/FS/FS/prepay_credit.pm
@@ -1,12 +1,15 @@
 package FS::prepay_credit;
 
 use strict;
-use vars qw( @ISA );
+use vars qw( @ISA $DEBUG $me );
 use FS::Record qw(qsearchs dbh);
 use FS::agent;
 
 @ISA = qw(FS::Record);
 
+$DEBUG = 0;
+$me = '[FS::prepay_credit]';
+
 =head1 NAME
 
 FS::prepay_credit - Object methods for prepay_credit records
@@ -170,7 +173,16 @@ sub generate {
 
     my $identifier = join('', map($codeset[int(rand $#codeset)], (1..$length) ) );
 
-    redo if qsearchs('prepay_credit',{identifier=>$identifier}) && $condup++<23;
+    if ( qsearchs('prepay_credit',{identifier=>$identifier}) ) {
+      if ( $condup++ < 54 ) {
+        warn "$me generate: duplicate identifier $identifier; retrying\n"
+          if $DEBUG;
+        redo;
+      } else {
+        warn "$me generate: giving up after 54 tries"
+          if $DEBUG;
+      }
+    }
     $condup = 0;
 
     my $prepay_credit = new FS::prepay_credit {