From: Mark Wells <mark@freeside.biz>
Date: Sat, 24 Mar 2012 23:34:49 +0000 (-0700)
Subject: fix flat-rate discounts when charging zero months, #17043
X-Git-Url: http://git.freeside.biz/gitweb/?a=commitdiff_plain;h=2ee2d0cf73e191a4fd276675eff543675a0c9676;p=freeside.git

fix flat-rate discounts when charging zero months, #17043
---

diff --git a/FS/FS/part_pkg/discount_Mixin.pm b/FS/FS/part_pkg/discount_Mixin.pm
index 7de3bfe42..7c53a8c4c 100644
--- a/FS/FS/part_pkg/discount_Mixin.pm
+++ b/FS/FS/part_pkg/discount_Mixin.pm
@@ -84,7 +84,9 @@ sub calc_discount {
     $amount += $discount->amount
         if $cust_pkg->pkgpart == $param->{'real_pkgpart'};
     $amount += sprintf('%.2f', $discount->percent * $br / 100 );
-    my $chg_months = $param->{'months'} || $cust_pkg->part_pkg->freq;
+    my $chg_months = defined($param->{'months'}) ?
+                      $param->{'months'} :
+                      $cust_pkg->part_pkg->freq;
 
     my $months = $discount->months
     ? min( $chg_months,