From: jeff <jeff>
Date: Mon, 28 Sep 2009 15:55:12 +0000 (+0000)
Subject: use object copy when billing on cancel to avoid very weird side effects ( including... 
X-Git-Tag: freeside_1_9_1^2~61
X-Git-Url: http://git.freeside.biz/gitweb/?a=commitdiff_plain;h=1425c9ef765b7fe350dafd5534bc70d20a6ff0ee;p=freeside.git

use object copy when billing on cancel to avoid very weird side effects ( including 'impossible' history ) RT#5723
---

diff --git a/FS/FS/cust_pkg.pm b/FS/FS/cust_pkg.pm
index e7f84845f..e839eb93e 100644
--- a/FS/FS/cust_pkg.pm
+++ b/FS/FS/cust_pkg.pm
@@ -603,8 +603,9 @@ sub cancel {
   #resolved by performing a change package instead (which unprovisions) and
   #later cancelling
   if ( !$options{nobill} && !$date && $conf->exists('bill_usage_on_cancel') ) {
+      my $copy = $self->new({$self->hash});
       my $error =
-        $self->cust_main->bill( pkg_list => [ $self ], cancel => 1 );
+        $copy->cust_main->bill( pkg_list => [ $copy ], cancel => 1 );
       warn "Error billing during cancel, custnum ".
         #$self->cust_main->custnum. ": $error"
         ": $error"