From: Ivan Kohler Date: Mon, 8 Jul 2013 21:08:43 +0000 (-0700) Subject: performance improvement for packages with many services, patch from jeff finucane... X-Git-Url: http://git.freeside.biz/gitweb/?a=commitdiff_plain;h=0e0109e17e7601dfcc655ff9b18a9846c0d93297;p=freeside.git performance improvement for packages with many services, patch from jeff finucane, RT#23900 --- diff --git a/FS/FS/cust_pkg.pm b/FS/FS/cust_pkg.pm index 824221fba..f97cf9126 100644 --- a/FS/FS/cust_pkg.pm +++ b/FS/FS/cust_pkg.pm @@ -2456,11 +2456,13 @@ sub _sort_cust_svc { my $sort = sub ($$) { my ($a, $b) = @_; $b->[1] cmp $a->[1] or $a->[2] <=> $b->[2] }; + my %pkg_svc = map { $_->svcpart => $_ } + qsearch( 'pkg_svc', { 'pkgpart' => $self->pkgpart } ); + map { $_->[0] } sort $sort map { - my $pkg_svc = qsearchs( 'pkg_svc', { 'pkgpart' => $self->pkgpart, - 'svcpart' => $_->svcpart } ); + my $pkg_svc = $pkg_svc{ $_->svcpart } || ''; [ $_, $pkg_svc ? $pkg_svc->primary_svc : '', $pkg_svc ? $pkg_svc->quantity : 0,