From: ivan <ivan>
Date: Tue, 5 Nov 2002 23:34:11 +0000 (+0000)
Subject: can't use placeholders in SELECT SUM(?)
X-Git-Tag: freeside_1_5_0pre1~144
X-Git-Url: http://git.freeside.biz/gitweb/?a=commitdiff_plain;ds=sidebyside;h=d32ae4e36b14a3418979856e3ee3f662c5290d65;hp=548a47b0ec1040320e56f17cfac71f716785cb95;p=freeside.git

can't use placeholders in SELECT SUM(?)
---

diff --git a/FS/FS/cust_svc.pm b/FS/FS/cust_svc.pm
index e0d582b51..7516be599 100644
--- a/FS/FS/cust_svc.pm
+++ b/FS/FS/cust_svc.pm
@@ -477,14 +477,14 @@ sub attribute_since_sqlradacct {
       $str2time = 'extract(epoch from ';
     }
 
-    my $sth = $dbh->prepare("SELECT SUM(?)
+    my $sth = $dbh->prepare("SELECT SUM($attrib)
                                FROM radacct
                                WHERE UserName = ?
                                  AND $str2time AcctStopTime ) >= ?
                                  AND $str2time AcctStopTime ) <  ?
                                  AND AcctStopTime IS NOT NULL"
     ) or die $dbh->errstr;
-    $sth->execute($attrib, $username, $start, $end) or die $sth->errstr;
+    $sth->execute($username, $start, $end) or die $sth->errstr;
 
     $sum += $sth->fetchrow_arrayref->[0];