X-Git-Url: http://git.freeside.biz/gitweb/?a=blobdiff_plain;f=t%2Fbop.t;h=ba4c6cd1451040483fae21f444ba0feb9007a392;hb=e1bf5c280a8581314d4832de6d1baf2181b389c6;hp=c5535d2b92bd1ce5516ab37f7c55d4bb46bf65d7;hpb=417f1443bc69fd3b5c9bce17cfb618d0c7da486f;p=Business-OnlinePayment.git

diff --git a/t/bop.t b/t/bop.t
index c5535d2..ba4c6cd 100644
--- a/t/bop.t
+++ b/t/bop.t
@@ -1,11 +1,10 @@
 #!/usr/bin/perl
-# $Id: bop.t,v 1.7 2006-11-20 04:54:24 plobbes Exp $
 
 use strict;
 use warnings;
-use Test::More tests => 62;
+use Test::More tests => 57;
 
-BEGIN { use_ok("Business::OnlinePayment") or exit; }
+use Business::OnlinePayment;
 
 {    # fake test driver 1 (no submit method)
 
@@ -18,19 +17,15 @@ BEGIN { use_ok("Business::OnlinePayment") or exit; }
 {    # fake test driver 2 (with submit method that dies)
 
     package Business::OnlinePayment::MOCK2;
-    use strict;
-    use warnings;
-    use base qw(Business::OnlinePayment);
-    sub submit { die("in processor submit\n"); }
+    use base qw(Business::OnlinePayment::MOCK1);
+    sub submit { my $self = shift; die("in processor submit\n"); }
 }
 
 {    # fake test driver 3 (with submit method)
 
     package Business::OnlinePayment::MOCK3;
-    use strict;
-    use warnings;
-    use base qw(Business::OnlinePayment);
-    sub submit { return (1); }
+    use base qw(Business::OnlinePayment::MOCK1);
+    sub submit { my $self = shift; return 1; }
 }
 
 my $package = "Business::OnlinePayment";
@@ -112,21 +107,6 @@ foreach my $drv (@drivers) {
     my $obj2   = $package->new("MOCK3");
     my $s_new2 = $obj2->can("submit");
     is( $obj2->submit, "1", "MOCK3(obj2) submit returns 1" );
-
-    # fraud detection failure modes
-    my $obj   = $package->new("MOCK3");
-    my $bogus = "__BOGUS_PROCESSOR";
-    my $valid = "preCharge";
-
-    is( $obj->fraud_detect($bogus), $bogus, "fraud_detect set to '$bogus'" );
-    eval { $obj->submit; };
-    is( $@, "", "fraud_detect ignores non-existant processors" );
-
-    is( $obj->fraud_detect($valid), $valid, "fraud_detect set to '$valid'" );
-    eval { $obj->submit; };
-    like( $@, qr/^missing required /, "fraud_detect($valid) missing fields" );
-
-    # XXX: more test cases for preCharge needed
 }
 
 {    # content
@@ -202,7 +182,7 @@ foreach my $drv (@drivers) {
 
     eval { $obj->submit; };
     like( $@, qr/^Processor subclass did not /, "missing submit() croaks" );
-    is( $obj->can("submit"), $package->can("submit"), "submit unchanged" );
+    isnt( $obj->can("submit"), $package->can("submit"), "submit changed" );
 
     my $mock2 = $package->new("MOCK2");
     can_ok( $mock2, qw(submit) );