X-Git-Url: http://git.freeside.biz/gitweb/?a=blobdiff_plain;f=rt%2Ft%2Fticket%2Fdeferred_owner.t;h=a0aa350eca91a42782cba56b48589db0fcb453d6;hb=96af02574ea6b1b59f81a1215330b682a8dee635;hp=40172caf971a4d408deec0605732bf4b5724b82e;hpb=b4b0c7e72d7eaee2fbfc7022022c9698323203dd;p=freeside.git

diff --git a/rt/t/ticket/deferred_owner.t b/rt/t/ticket/deferred_owner.t
index 40172caf9..a0aa350ec 100644
--- a/rt/t/ticket/deferred_owner.t
+++ b/rt/t/ticket/deferred_owner.t
@@ -1,10 +1,7 @@
-
 use strict;
 use warnings;
 
-use RT::Test tests => 18;
-use_ok('RT');
-use_ok('RT::Ticket');
+use RT::Test nodata => 1, tests => undef;
 use Test::Warn;
 
 
@@ -16,11 +13,10 @@ ok $tester && $tester->id, 'loaded or created user';
 my $queue = RT::Test->load_or_create_queue( Name => 'General' );
 ok $queue && $queue->id, 'loaded or created queue';
 
-my $owner_role_group = RT::Group->new( $RT::SystemUser );
-$owner_role_group->LoadQueueRoleGroup( Type => 'Owner', Queue => $queue->id );
+my $owner_role_group = $queue->RoleGroup( 'Owner' );
 ok $owner_role_group->id, 'loaded owners role group of the queue';
 
-diag "check that deffering owner doesn't regress" if $ENV{'TEST_VERBOSE'};
+diag "check that deffering owner doesn't regress";
 {
     RT::Test->set_rights(
         { Principal => $tester->PrincipalObj,
@@ -39,14 +35,13 @@ diag "check that deffering owner doesn't regress" if $ENV{'TEST_VERBOSE'};
         Owner   => $tester->id,
         AdminCc => 'root@localhost',
     );
-    diag $msg if $msg && $ENV{'TEST_VERBOSE'};
+    diag $msg if $msg;
     ok $tid, "created a ticket";
     is $ticket->Owner, $tester->id, 'correct owner';
     like $ticket->AdminCcAddresses, qr/root\@localhost/, 'root is there';
 }
 
-diag "check that previous trick doesn't work without sufficient rights"
-    if $ENV{'TEST_VERBOSE'};
+diag "check that previous trick doesn't work without sufficient rights";
 {
     RT::Test->set_rights(
         { Principal => $tester->PrincipalObj,
@@ -61,13 +56,13 @@ diag "check that previous trick doesn't work without sufficient rights"
         Owner   => $tester->id,
         AdminCc => 'root@localhost',
     );
-    diag $msg if $msg && $ENV{'TEST_VERBOSE'};
+    diag $msg if $msg;
     ok $tid, "created a ticket";
     is $ticket->Owner, $tester->id, 'correct owner';
-    unlike $ticket->AdminCcAddresses, qr/root\@localhost/, 'root is there';
+    unlike $ticket->AdminCcAddresses, qr/root\@localhost/, 'root is not there';
 }
 
-diag "check that deffering owner really works" if $ENV{'TEST_VERBOSE'};
+diag "check that deffering owner really works";
 {
     RT::Test->set_rights(
         { Principal => $tester->PrincipalObj,
@@ -85,13 +80,16 @@ diag "check that deffering owner really works" if $ENV{'TEST_VERBOSE'};
         Owner => $tester->id,
         Cc    => 'tester@localhost',
     );
-    diag $msg if $msg && $ENV{'TEST_VERBOSE'};
+    diag $msg if $msg;
     ok $tid, "created a ticket";
     like $ticket->CcAddresses, qr/tester\@localhost/, 'tester is in the cc list';
     is $ticket->Owner, $tester->id, 'tester is also owner';
+    my $owners = $ticket->OwnerGroup->MembersObj;
+    is $owners->Count, 1, 'one record in owner group';
+    is $owners->First->MemberObj->Id, $tester->id, 'and it is tester';
 }
 
-diag "check that deffering doesn't work without correct rights" if $ENV{'TEST_VERBOSE'};
+diag "check that deffering doesn't work without correct rights";
 {
     RT::Test->set_rights(
         { Principal => $tester->PrincipalObj,
@@ -110,11 +108,13 @@ diag "check that deffering doesn't work without correct rights" if $ENV{'TEST_VE
         );
     } qr/User .* was proposed as a ticket owner but has no rights to own tickets in General/;
 
-    diag $msg if $msg && $ENV{'TEST_VERBOSE'};
+    diag $msg if $msg;
     ok $tid, "created a ticket";
     like $ticket->CcAddresses, qr/tester\@localhost/, 'tester is in the cc list';
-    isnt $ticket->Owner, $tester->id, 'tester is also owner';
+    is $ticket->Owner, RT->Nobody->id, 'nobody is the owner';
+    my $owners = $ticket->OwnerGroup->MembersObj;
+    is $owners->Count, 1, 'one record in owner group';
+    is $owners->First->MemberObj->Id, RT->Nobody->id, 'and it is nobody';
 }
 
-
-
+done_testing;