X-Git-Url: http://git.freeside.biz/gitweb/?a=blobdiff_plain;f=rt%2Ft%2Fcustomfields%2Fapi.t;h=a50ca770c9d0c8e373dbba036166eb288f2dd403;hb=4e282b89c158949c1726f044e0102e126fbf5bf2;hp=d739a572d1313e8cee248d2ce7a8e2b86ecc0890;hpb=6587f6ba7d047ddc1686c080090afe7d53365bd4;p=freeside.git

diff --git a/rt/t/customfields/api.t b/rt/t/customfields/api.t
index d739a572d..a50ca770c 100644
--- a/rt/t/customfields/api.t
+++ b/rt/t/customfields/api.t
@@ -1,16 +1,16 @@
-#!/usr/bin/perl
 
 use strict;
 use warnings FATAL => 'all';
 
-use RT::Test nodata => 1, tests => 139;
+use RT::Test nodata => 1, tests => 145;
+use Test::Warn;
 
-# Before we get going, ditch all object_cfs; this will remove 
+# Before we get going, ditch all object_cfs; this will remove
 # all custom fields systemwide;
 my $object_cfs = RT::ObjectCustomFields->new(RT->SystemUser);
 $object_cfs->UnLimit();
 while (my $ocf = $object_cfs->Next) {
-	$ocf->Delete();
+    $ocf->Delete();
 }
 
 
@@ -23,9 +23,9 @@ $queue2->Create( Name => 'RecordCustomFields2' );
 
 my $ticket = RT::Ticket->new( RT->SystemUser );
 $ticket->Create(
-	Queue => $queue->Id,
-	Requestor => 'root@localhost',
-	Subject => 'RecordCustomFields1',
+    Queue => $queue->Id,
+    Requestor => 'root@localhost',
+    Subject => 'RecordCustomFields1',
 );
 
 my $cfs = $ticket->CustomFields;
@@ -69,22 +69,30 @@ is( $cfvs->Count, 0 );
 is( $ticket->FirstCustomFieldValue, undef );
 
 # CF with ID -1 shouldnt exist at all
-$cfvs = $ticket->CustomFieldValues( -1 );
+warning_like {
+    $cfvs = $ticket->CustomFieldValues( -1 );
+} qr{Couldn't load custom field};
 is( $cfvs->Count, 0 );
-is( $ticket->FirstCustomFieldValue( -1 ), undef );
+warning_like {
+    is( $ticket->FirstCustomFieldValue( -1 ), undef );
+} qr{Couldn't load custom field};
 
-$cfvs = $ticket->CustomFieldValues( 'SomeUnexpedCustomFieldName' );
+warning_like {
+    $cfvs = $ticket->CustomFieldValues( 'SomeUnexpedCustomFieldName' );
+} qr{Couldn't load custom field};
 is( $cfvs->Count, 0 );
-is( $ticket->FirstCustomFieldValue( 'SomeUnexpedCustomFieldName' ), undef );
+warning_like {
+    is( $ticket->FirstCustomFieldValue( 'SomeUnexpedCustomFieldName' ), undef );
+} qr{Couldn't load custom field};
 
 for (@custom_fields) {
-	$cfvs = $ticket->CustomFieldValues( $_->id );
-	is( $cfvs->Count, 0 );
+    $cfvs = $ticket->CustomFieldValues( $_->id );
+    is( $cfvs->Count, 0 );
 
-	$cfvs = $ticket->CustomFieldValues( $_->Name );
-	is( $cfvs->Count, 0 );
-	is( $ticket->FirstCustomFieldValue( $_->id ), undef );
-	is( $ticket->FirstCustomFieldValue( $_->Name ), undef );
+    $cfvs = $ticket->CustomFieldValues( $_->Name );
+    is( $cfvs->Count, 0 );
+    is( $ticket->FirstCustomFieldValue( $_->id ), undef );
+    is( $ticket->FirstCustomFieldValue( $_->Name ), undef );
 }
 
 # try to add field value with fields that do not exist {{{
@@ -95,84 +103,84 @@ ok(!$status, "shouldn't add value" );
 
 SKIP: {
 
-	skip "TODO: We want fields that are not allowed to set unexpected values", 10;
-	for (@custom_fields) {
-		($status, $msg) = $ticket->AddCustomFieldValue( Field => $_ , Value => 'SomeUnexpectedCFValue' );
-		ok( !$status, 'value doesn\'t exist');
-	
-		($status, $msg) = $ticket->AddCustomFieldValue( Field => $_->id , Value => 'SomeUnexpectedCFValue' );
-		ok( !$status, 'value doesn\'t exist');
-	
-		($status, $msg) = $ticket->AddCustomFieldValue( Field => $_->Name , Value => 'SomeUnexpectedCFValue' );
-		ok( !$status, 'value doesn\'t exist');
-	}
-	
-	# Let check that we did not add value to be sure
-	# using only FirstCustomFieldValue sub because
-	# we checked other variants allready
-	for (@custom_fields) {
-		is( $ticket->FirstCustomFieldValue( $_->id ), undef );
-	}
-	
+    skip "TODO: We want fields that are not allowed to set unexpected values", 10;
+    for (@custom_fields) {
+        ($status, $msg) = $ticket->AddCustomFieldValue( Field => $_ , Value => 'SomeUnexpectedCFValue' );
+        ok( !$status, 'value doesn\'t exist');
+
+        ($status, $msg) = $ticket->AddCustomFieldValue( Field => $_->id , Value => 'SomeUnexpectedCFValue' );
+        ok( !$status, 'value doesn\'t exist');
+
+        ($status, $msg) = $ticket->AddCustomFieldValue( Field => $_->Name , Value => 'SomeUnexpectedCFValue' );
+        ok( !$status, 'value doesn\'t exist');
+    }
+
+    # Let check that we did not add value to be sure
+    # using only FirstCustomFieldValue sub because
+    # we checked other variants allready
+    for (@custom_fields) {
+        is( $ticket->FirstCustomFieldValue( $_->id ), undef );
+    }
+
 }
 # Add some values to our custom fields
 for (@custom_fields) {
-	# this should be tested elsewhere
-	$_->AddValue( Name => 'Foo' );
-	$_->AddValue( Name => 'Bar' );
+    # this should be tested elsewhere
+    $_->AddValue( Name => 'Foo' );
+    $_->AddValue( Name => 'Bar' );
 }
 
 my $test_add_delete_cycle = sub {
-	my $cb = shift;
-	for (@custom_fields) {
-		($status, $msg) = $ticket->AddCustomFieldValue( Field => $cb->($_) , Value => 'Foo' );
-		ok( $status, "message: $msg");
-	}
-	
-	# does it exist?
-	$cfvs = $ticket->CustomFieldValues;
-	is( $cfvs->Count, 3, "We found all three custom fields on our ticket" );
-	for (@custom_fields) {
-		$cfvs = $ticket->CustomFieldValues( $_->id );
-		is( $cfvs->Count, 1 , "we found one custom field when searching by id");
-	
-		$cfvs = $ticket->CustomFieldValues( $_->Name );
-		is( $cfvs->Count, 1 , " We found one custom field when searching by name for " . $_->Name);
-		is( $ticket->FirstCustomFieldValue( $_->id ), 'Foo' , "first value by id is foo");
-		is( $ticket->FirstCustomFieldValue( $_->Name ), 'Foo' , "first value by name is foo");
-	}
-	# because our CFs are SingleValue then new value addition should override
-	for (@custom_fields) {
-		($status, $msg) = $ticket->AddCustomFieldValue( Field => $_ , Value => 'Bar' );
-		ok( $status, "message: $msg");
-	}
-	$cfvs = $ticket->CustomFieldValues;
-	is( $cfvs->Count, 3 );
-	for (@custom_fields) {
-		$cfvs = $ticket->CustomFieldValues( $_->id );
-		is( $cfvs->Count, 1 );
-	
-		$cfvs = $ticket->CustomFieldValues( $_->Name );
-		is( $cfvs->Count, 1 );
-		is( $ticket->FirstCustomFieldValue( $_->id ), 'Bar' );
-		is( $ticket->FirstCustomFieldValue( $_->Name ), 'Bar' );
-	}
-	# delete it
-	for (@custom_fields ) { 
-		($status, $msg) = $ticket->DeleteCustomFieldValue( Field => $_ , Value => 'Bar' );
-		ok( $status, "Deleted a custom field value 'Bar' for field ".$_->id.": $msg");
-	}
-	$cfvs = $ticket->CustomFieldValues;
-	is( $cfvs->Count, 0, "The ticket (".$ticket->id.") no longer has any custom field values"  );
-	for (@custom_fields) {
-		$cfvs = $ticket->CustomFieldValues( $_->id );
-		is( $cfvs->Count, 0,  $ticket->id." has no values for cf  ".$_->id );
-	
-		$cfvs = $ticket->CustomFieldValues( $_->Name );
-		is( $cfvs->Count, 0 , $ticket->id." has no values for cf  '".$_->Name. "'" );
-		is( $ticket->FirstCustomFieldValue( $_->id ), undef , "There is no first custom field value when loading by id" );
-		is( $ticket->FirstCustomFieldValue( $_->Name ), undef, "There is no first custom field value when loading by Name" );
-	}
+    my $cb = shift;
+    for (@custom_fields) {
+        ($status, $msg) = $ticket->AddCustomFieldValue( Field => $cb->($_) , Value => 'Foo' );
+        ok( $status, "message: $msg");
+    }
+
+    # does it exist?
+    $cfvs = $ticket->CustomFieldValues;
+    is( $cfvs->Count, 3, "We found all three custom fields on our ticket" );
+    for (@custom_fields) {
+        $cfvs = $ticket->CustomFieldValues( $_->id );
+        is( $cfvs->Count, 1 , "we found one custom field when searching by id");
+
+        $cfvs = $ticket->CustomFieldValues( $_->Name );
+        is( $cfvs->Count, 1 , " We found one custom field when searching by name for " . $_->Name);
+        is( $ticket->FirstCustomFieldValue( $_->id ), 'Foo' , "first value by id is foo");
+        is( $ticket->FirstCustomFieldValue( $_->Name ), 'Foo' , "first value by name is foo");
+    }
+    # because our CFs are SingleValue then new value addition should override
+    for (@custom_fields) {
+        ($status, $msg) = $ticket->AddCustomFieldValue( Field => $_ , Value => 'Bar' );
+        ok( $status, "message: $msg");
+    }
+    $cfvs = $ticket->CustomFieldValues;
+    is( $cfvs->Count, 3 );
+    for (@custom_fields) {
+        $cfvs = $ticket->CustomFieldValues( $_->id );
+        is( $cfvs->Count, 1 );
+
+        $cfvs = $ticket->CustomFieldValues( $_->Name );
+        is( $cfvs->Count, 1 );
+        is( $ticket->FirstCustomFieldValue( $_->id ), 'Bar' );
+        is( $ticket->FirstCustomFieldValue( $_->Name ), 'Bar' );
+    }
+    # delete it
+    for (@custom_fields ) {
+        ($status, $msg) = $ticket->DeleteCustomFieldValue( Field => $_ , Value => 'Bar' );
+        ok( $status, "Deleted a custom field value 'Bar' for field ".$_->id.": $msg");
+    }
+    $cfvs = $ticket->CustomFieldValues;
+    is( $cfvs->Count, 0, "The ticket (".$ticket->id.") no longer has any custom field values"  );
+    for (@custom_fields) {
+        $cfvs = $ticket->CustomFieldValues( $_->id );
+        is( $cfvs->Count, 0,  $ticket->id." has no values for cf  ".$_->id );
+
+        $cfvs = $ticket->CustomFieldValues( $_->Name );
+        is( $cfvs->Count, 0 , $ticket->id." has no values for cf  '".$_->Name. "'" );
+        is( $ticket->FirstCustomFieldValue( $_->id ), undef , "There is no first custom field value when loading by id" );
+        is( $ticket->FirstCustomFieldValue( $_->Name ), undef, "There is no first custom field value when loading by Name" );
+    }
 };
 
 # lets test cycle via CF id
@@ -183,9 +191,13 @@ $test_add_delete_cycle->( sub { return $_[0] } );
 $ticket->AddCustomFieldValue( Field => $local_cf2->id , Value => 'Baz' );
 $ticket->AddCustomFieldValue( Field => $global_cf3->id , Value => 'Baz' );
 # now if we ask for cf values on RecordCustomFields4 we should not get any
-$cfvs = $ticket->CustomFieldValues( 'RecordCustomFields4' );
+warning_like {
+    $cfvs = $ticket->CustomFieldValues( 'RecordCustomFields4' );
+} qr{Couldn't load custom field};
 is( $cfvs->Count, 0, "No custom field values for non-Queue cf" );
-is( $ticket->FirstCustomFieldValue( 'RecordCustomFields4' ), undef, "No first custom field value for non-Queue cf" );
+warning_like {
+    is( $ticket->FirstCustomFieldValue( 'RecordCustomFields4' ), undef, "No first custom field value for non-Queue cf" );
+} qr{Couldn't load custom field};
 
 {
     my $cfname = $global_cf3->Name;
@@ -212,10 +224,10 @@ is( $ticket->FirstCustomFieldValue( 'RecordCustomFields4' ), undef, "No first cu
 }
 
 #SKIP: {
-#	skip "TODO: should we add CF values to objects via CF Name?", 48;
+#       skip "TODO: should we add CF values to objects via CF Name?", 48;
 # names are not unique
-	# lets test cycle via CF Name
-#	$test_add_delete_cycle->( sub { return $_[0]->Name } );
+        # lets test cycle via CF Name
+#       $test_add_delete_cycle->( sub { return $_[0]->Name } );
 #}