X-Git-Url: http://git.freeside.biz/gitweb/?a=blobdiff_plain;f=rt%2Flib%2FRT%2FObjectCustomFieldValues.pm;h=b1cf3caa2f41b8804114b2a30c2095b811cdac2a;hb=bd6e42634e0ff49f387b40b2e15029e41fdad852;hp=a2ec317e8fbaaaef1124c6d3d1a251e5608019ac;hpb=c71b2dc296da6207c525a064d322f7153c284d4e;p=freeside.git diff --git a/rt/lib/RT/ObjectCustomFieldValues.pm b/rt/lib/RT/ObjectCustomFieldValues.pm index a2ec317e8..b1cf3caa2 100644 --- a/rt/lib/RT/ObjectCustomFieldValues.pm +++ b/rt/lib/RT/ObjectCustomFieldValues.pm @@ -2,7 +2,7 @@ # # COPYRIGHT: # -# This software is Copyright (c) 1996-2014 Best Practical Solutions, LLC +# This software is Copyright (c) 1996-2016 Best Practical Solutions, LLC # # # (Except where explicitly superseded by other copyright notices) @@ -51,11 +51,10 @@ package RT::ObjectCustomFieldValues; use strict; use warnings; +use base 'RT::SearchBuilder'; use RT::ObjectCustomFieldValue; -use base 'RT::SearchBuilder'; - sub Table { 'ObjectCustomFieldValues'} sub _Init { @@ -63,12 +62,12 @@ sub _Init { # By default, order by SortOrder $self->OrderByCols( - { ALIAS => 'main', - FIELD => 'SortOrder', - ORDER => 'ASC' }, - { ALIAS => 'main', - FIELD => 'id', - ORDER => 'ASC' }, + { ALIAS => 'main', + FIELD => 'SortOrder', + ORDER => 'ASC' }, + { ALIAS => 'main', + FIELD => 'id', + ORDER => 'ASC' }, ); return ( $self->SUPER::_Init(@_) ); @@ -146,7 +145,7 @@ sub HasEntry { return $item if lc $item->Content eq lc $args->{Content}; } else { - if ( $item->_Value('Content') eq $args->{Content} ) { + if ( ($item->_Value('Content') || '') eq $args->{Content} ) { if ( defined $item->LargeContent ) { return $item if defined $args->{LargeContent} @@ -155,6 +154,8 @@ sub HasEntry { else { return $item unless defined $args->{LargeContent}; } + } elsif ( $item->LargeContent && $args->{Content} ) { + return $item if ($item->LargeContent eq $args->{Content}); } } } @@ -185,17 +186,6 @@ sub _DoCount { return $self->SUPER::_DoCount(@_); } - -=head2 NewItem - -Returns an empty new RT::ObjectCustomFieldValue item - -=cut - -sub NewItem { - my $self = shift; - return(RT::ObjectCustomFieldValue->new($self->CurrentUser)); -} RT::Base->_ImportOverlays(); 1;