X-Git-Url: http://git.freeside.biz/gitweb/?a=blobdiff_plain;f=PayflowPro.pm;h=c3727bc50ee4e8f962e6a9679f743bd6af2c25d4;hb=ac87a6d1b67c9f274900945b80d1abda7ba2031f;hp=16e499b979439b8f92302e2aede81c6a0acac36c;hpb=a6890d361554f119a7230efec5c59e615b1728ed;p=Business-OnlinePayment-PayflowPro.git

diff --git a/PayflowPro.pm b/PayflowPro.pm
index 16e499b..c3727bc 100644
--- a/PayflowPro.pm
+++ b/PayflowPro.pm
@@ -1,30 +1,25 @@
 package Business::OnlinePayment::PayflowPro;
 
 use strict;
-use vars qw($VERSION @ISA @EXPORT @EXPORT_OK);
+use vars qw($VERSION);
 use Carp qw(croak);
-use AutoLoader;
-use Business::OnlinePayment;
+use base qw(Business::OnlinePayment);
 
-#PayflowPRO SDK from Verisign
+# PayflowPRO SDK from PayPal/Verisign
 use PFProAPI qw( pfpro );
 
-require Exporter;
-
-@ISA = qw(Exporter AutoLoader Business::OnlinePayment);
-@EXPORT = qw();
-@EXPORT_OK = qw();
-$VERSION = '0.01';
+$VERSION = '0.05';
+$VERSION = eval $VERSION;
 
 sub set_defaults {
     my $self = shift;
 
-    #$self->server('staging.linkpt.net');
     $self->server('payflow.verisign.com');
     $self->port('443');
 
-    $self->build_subs(qw( vendor partner order_number cert_path ));
-
+    $self->build_subs(qw(
+      vendor partner order_number cert_path avs_code cvv2_code
+    ));
 }
 
 sub map_fields {
@@ -32,17 +27,12 @@ sub map_fields {
 
     my %content = $self->content();
 
-    my $action = lc($content{'action'});
-    if ( $action eq 'normal authorization' ) {
-    } else {
-      croak "$action not (yet) supported";
-    }
-
     #ACTION MAP
     my %actions = ('normal authorization' => 'S', #Sale
                    'authorization only'   => 'A', #Authorization
                    'credit'               => 'C', #Credit (refund)
                    'post authorization'   => 'D', #Delayed Capture
+                   'void'                 => 'V',
                   );
     $content{'action'} = $actions{lc($content{'action'})} || $content{'action'};
 
@@ -61,15 +51,6 @@ sub map_fields {
     $self->content(%content);
 }
 
-sub build_subs {
-    my $self = shift;
-    foreach(@_) {
-        #no warnings; #not 5.005
-        local($^W)=0;
-        eval "sub $_ { my \$self = shift; if(\@_) { \$self->{$_} = shift; } return \$self->{$_}; }";
-    }
-}
-
 sub remap_fields {
     my($self,%map) = @_;
 
@@ -94,56 +75,40 @@ sub revmap_fields {
     $self->content(%content);
 }
 
-sub get_fields {
-    my($self,@fields) = @_;
-
-    my %content = $self->content();
-    my %new = ();
-    foreach( grep defined $content{$_}, @fields) { $new{$_} = $content{$_}; }
-    return %new;
-}
-
 sub submit {
     my($self) = @_;
 
-
-    
-
     $self->map_fields();
 
     my %content = $self->content;
 
     my($month, $year, $zip);
 
-    #unless ( $content{action} eq 'BillOrders' ) {
-
-        if (  $self->transaction_type() eq 'C' ) {
-        } else {
-            Carp::croak("PayflowPro can't (yet?) handle transaction type: ".
-                        $self->transaction_type());
-        }
-
-      $content{'expiration'} =~ /^(\d+)\D+\d*(\d{2})$/
-        or croak "unparsable expiration $content{expiration}";
+    if ( $self->transaction_type() ne 'C' ) {
+        croak("PayflowPro can't (yet?) handle transaction type: " .
+              $self->transaction_type());
+    }
 
-      ( $month, $year ) = ( $1, $2 );
-      $month = '0'. $month if $month =~ /^\d$/;
+    if ( defined($content{'expiration'}) && length($content{'expiration'}) ) {
+        $content{'expiration'} =~ /^(\d+)\D+\d*(\d{2})$/
+            or croak "unparsable expiration $content{expiration}";
 
-      $zip = $content{'zip'} =~ s/\D//;
-    #}
+        ( $month, $year ) = ( $1, $2 );
+        $month = '0'. $month if $month =~ /^\d$/;
+    }
 
-    #$content{'address'} =~ /^(\S+)\s/;
-    #my $addrnum = $1;
+    ( $zip = $content{'zip'} ) =~ s/\D//g;
 
     $self->server('test-payflow.verisign.com') if $self->test_transaction;
 
     $self->revmap_fields(
-      ACCT       => 'card_number',
+      ACCT        => 'card_number',
       EXPDATE     => \( $month.$year ),
       AMT         => 'amount',
       USER        => 'login',
-      #VENDOR      => \( $self->vendor ),
-      VENDOR      => 'login',
+      # (BUG?) VENDOR B::OP:PayflowPro < 0.05 backward compatibility.  If
+      # vendor not set use login (although test indicate undef vendor is ok)
+      VENDOR      => $self->vendor ? \( $self->vendor ) : 'login',
       PARTNER     => \( $self->partner ),
       PWD         => 'password',
       TRXTYPE     => 'action',
@@ -163,31 +128,57 @@ sub submit {
       EMAIL       => 'email',
       STATE       => 'state',
 
+      CVV2        => 'cvv2',
+      ORIGID      => 'order_number'
+
     );
 
-    $self->required_fields(qw(
-      ACCT EXPDATE AMT USER VENDOR PARTNER PWD TRXTYPE TENDER ));
+    my @required = qw( TRXTYPE TENDER PARTNER VENDOR USER PWD );
+    if (  $self->transaction_type() eq 'C' ) { #credit card
+      if ( $content{'action'} =~ /^[CDV]$/
+           && defined($content{'ORIGID'})
+           && length($content{'ORIGID'})
+         )
+      {
+        push @required, qw(ORIGID);
+      } else {
+        push @required, qw(AMT ACCT EXPDATE);
+      }
+    }
+    $self->required_fields(@required);
 
     my %params = $self->get_fields(qw(
       ACCT EXPDATE AMT USER VENDOR PARTNER PWD TRXTYPE TENDER
-      STREET ZIP
-      CITY COMMENT1 COMMENT2 COMPANYNAME COUNTRY FIRSTNAME LASTNAME NAME EMAIL
-        STATE
+      STREET ZIP CITY COMMENT1 COMMENT2 COMPANYNAME COUNTRY
+      FIRSTNAME LASTNAME NAME EMAIL STATE
+      CVV2 ORIGID
     ));
 
-    #print "$_ => $params{$_}\n" foreach keys %params;
-
     $ENV{'PFPRO_CERT_PATH'} = $self->cert_path;
     my( $response, $resultstr ) = pfpro( \%params, $self->server, $self->port );
+    # PNREF (aka transaction id) is set on success and failure
+    $self->order_number( $response->{'PNREF'} );
 
-    #if ( $response->{'RESULT'} == 0 ) {
     if ( $response->{'RESULT'} eq '0' ) { #want an explicit zero, not just
                                           #numerically equal
       $self->is_success(1);
       $self->result_code(   $response->{'RESULT'}   );
       $self->error_message( $response->{'RESPMSG'}  );
       $self->authorization( $response->{'AUTHCODE'} );
-      $self->order_number(  $response->{'PNREF'}    );
+      my $avs_code = '';
+      if ( exists $response->{AVSADDR} || exists $response->{AVSZIP} ) {
+        if ( $response->{AVSADDR} eq 'Y' && $response->{AVSZIP} eq 'Y' ) {
+          $avs_code = 'Y';
+        } elsif ( $response->{AVSADDR} eq 'Y' ) {
+          $avs_code = 'A';
+        } elsif ( $response->{AVSZIP} eq 'Y' ) {
+          $avs_code = 'Z';
+        } elsif ( $response->{AVSADDR} eq 'N' || $response->{AVSZIP} eq 'N' ) {
+          $avs_code = 'N';
+        }
+      }
+      $self->avs_code(      $avs_code               );
+      $self->cvv2_code(     $response->{'CVV2MATCH'});
     } else {
       $self->is_success(0);
       $self->result_code(   $response->{'RESULT'}  );
@@ -197,6 +188,7 @@ sub submit {
 }
 
 1;
+
 __END__
 
 =head1 NAME
@@ -210,6 +202,7 @@ Business::OnlinePayment::PayflowPro - Verisign PayflowPro backend for Business::
   my $tx = new Business::OnlinePayment( 'PayflowPro',
     'vendor'    => 'your_vendor',
     'partner'   => 'your_partner',
+    'cert_path' => '/path/to/your/certificate/file/', #just the dir
   );
 
   $tx->content(
@@ -227,18 +220,40 @@ Business::OnlinePayment::PayflowPro - Verisign PayflowPro backend for Business::
       email          => 'ivan-payflowpro@420.am',
       card_number    => '4007000000027',
       expiration     => '09/04',
+
+      #advanced params
+      cvv2           => '420',
+      order_number   => 'string', # returned by $tx->order_number() from an
+                                  # "authorization only" or
+                                  # "normal authorization" action, used by a
+                                  # "credit", "void", or "post authorization"
   );
   $tx->submit();
 
   if($tx->is_success()) {
-      print "Card processed successfully: ".$tx->authorization."\n";
+      print "Card processed successfully: ", $tx->authorization, "\n";
+      print "order number: ", $tx->order_number, "\n";
+      print "AVS code: ", $tx->avs_code, "\n"; # Y - Address and ZIP match
+                                               # A - Address matches but not ZIP
+                                               # Z - ZIP matches bu tnot address
+                                               # N - no match
+                                               # E - AVS error or unsupported
+                                               # (null) - AVS error
+      print "CVV2 code: ", $tx->cvv2_code, "\n";
+
   } else {
-      print "Card was rejected: ".$tx->error_message."\n";
+      print "Card was rejected: ", $tx->error_message;
+      print " (CVV2 mismatch)" if $tx->result_code == 114;
+      print "\n";
   }
 
 =head1 SUPPORTED TRANSACTION TYPES
 
-=head2 Visa, MasterCard, American Express, JCB, Discover/Novus, Carte blanche/Diners Club
+=head2 Visa, MasterCard, American Express, JCB, Discover/Novus, Carte blanche/Diners Club, CC
+
+=head1 SUPPORTED ACTIONS
+
+=head2 Normal Authorization, Authorization Only, Post Authorization, Credit, Void
 
 =head1 DESCRIPTION
 
@@ -246,8 +261,8 @@ For detailed information see L<Business::OnlinePayment>.
 
 =head1 COMPATIBILITY
 
-This module implements an interface to the PayflowPro Perl API, which can
-be downloaded at https://manager.verisign.com/ with a valid login.
+This module implements an interface to the PayflowPro Perl API, which
+can be downloaded at https://manager.verisign.com/ with a valid login.
 
 =head1 BUGS
 
@@ -262,4 +277,3 @@ Based on Busienss::OnlinePayment::AuthorizeNet written by Jason Kohles.
 perl(1), L<Business::OnlinePayment>.
 
 =cut
-