X-Git-Url: http://git.freeside.biz/gitweb/?a=blobdiff_plain;f=OnlinePayment.pm;h=dbb28ce8ce2bb7f43f19a78136ea9fbd0722d35f;hb=17bd710d349b52c0b3f6defaa32e188825af4872;hp=3f95cd112701eb4f38fd0415a5be5cd414a65758;hpb=7e7195b0842a1c547cc4260ad4c25d1018961d27;p=Business-OnlinePayment.git

diff --git a/OnlinePayment.pm b/OnlinePayment.pm
index 3f95cd1..dbb28ce 100644
--- a/OnlinePayment.pm
+++ b/OnlinePayment.pm
@@ -6,7 +6,7 @@ use Carp;
 
 require 5.005;
 
-$VERSION = '3.00_04';
+$VERSION = '3.00_05';
 $VERSION = eval $VERSION; # modperlstyle: convert the string into a number
 
 # Remember subclasses we have "wrapped" submit() with _pre_submit()
@@ -83,13 +83,13 @@ sub _risk_detect {
 	if ( $risk_transaction->fraud_score <= $self->maximum_fraud_score()) {
 	    return 1;
 	} else {
-	    $self->is_success(0);
 	    $self->error_message('Excessive risk from risk management');
 	}
     } else {
 	$self->error_message('Error in risk detection stage: ' .  $risk_transaction->error_message);
-	$self->is_success(0);
     }
+    $self->is_success(0);
+    return 0;
 }
 
 sub _pre_submit {
@@ -119,6 +119,7 @@ sub _pre_submit {
 	    }
 	}
     }
+    return 1; # BUG?: success if fraud_detection module not found!
 }
 
 sub content {