X-Git-Url: http://git.freeside.biz/gitweb/?a=blobdiff_plain;f=InternetSecure.pm;h=a14fca9d59d8f951a43766c28695ef0ce5e88243;hb=38702efa45d6b20fa13617c3c36599148a435ce1;hp=86e16e20409a20f97cc0038141e930f487b668af;hpb=4f7f63abf30377deba653d2704df43c11061bb66;p=Business-OnlinePayment-InternetSecure.git

diff --git a/InternetSecure.pm b/InternetSecure.pm
index 86e16e2..a14fca9 100755
--- a/InternetSecure.pm
+++ b/InternetSecure.pm
@@ -18,8 +18,9 @@ our $VERSION = '0.01';
 use constant CARD_TYPES => {
 				VI => 'Visa',
 				MC => 'MasterCard',
-				AX => 'American Express',
+				AX => 'American Express', # FIXME: AM?
 				NN => 'Discover',
+				# JB?
 			};
 
 
@@ -157,7 +158,7 @@ sub to_xml {
 	$content{taxes} = uc $content{taxes};
 
 	my %data = $self->get_remap_fields(qw(
-			xxxCardNumber		card_number
+			xxxCard_Number		card_number
 
 			xxxName			name
 			xxxCompany		company
@@ -182,7 +183,8 @@ sub to_xml {
 	
 	$data{MerchantNumber} = $self->merchant_id;
 
-	$data{xxxCardNumber} =~ tr/ //d;
+	$data{xxxCard_Number} =~ tr/ //d;
+	$data{xxxCard_Number} =~ s/^[0-36-9]/4/ if $self->test_transaction;
 
 	my ($y, $m) = $self->parse_expdate($content{exp_date});
 	$data{xxxCCYear} = sprintf '%.4u' => $y;
@@ -262,6 +264,9 @@ sub parse_response {
 			CVV2ResponseCode	cvv2_response
 		));
 	
+	# Completely undocumented field that sometimes override <Verbiage>
+	$self->error_message($response->{Error}) if $response->{Error};
+	
 	$self->card_type(CARD_TYPES->{$self->card_type});
 	
 	$self->{products_raw} = $response->{Products};
@@ -446,9 +451,8 @@ separating them with spaces, such as C<GST HST>.
 
 =item name / company / address / city / state / zip / country / phone / email
 
-Facultative customer information.  B<state> should be either a postal
-abbreviation or a two-letter code taken from ISO 3166-2, and B<country> should
-be a two-letter code taken from ISO 3166-1.
+Customer information.  B<Country> should be a two-letter code taken from ISO
+3166-1.
 
 =back
 
@@ -518,7 +522,7 @@ Unit price of this product.
 
 =item quantity
 
-Ordered quantity of this product.  This can be a decimal value.
+Ordered quantity of this product.
 
 =item sku