X-Git-Url: http://git.freeside.biz/gitweb/?a=blobdiff_plain;f=InternetSecure.pm;h=85bb05ec6eae36f4826574e3c5303870c76757ae;hb=009f4489b1400b4990a69464cf580678552cd818;hp=58a6ce7f32fffc967183277047d3cd4eefb25ffd;hpb=117b28d8b8364db55a208e9c6c9bdcc750becbcf;p=Business-OnlinePayment-InternetSecure.git diff --git a/InternetSecure.pm b/InternetSecure.pm index 58a6ce7..85bb05e 100755 --- a/InternetSecure.pm +++ b/InternetSecure.pm @@ -18,8 +18,9 @@ our $VERSION = '0.01'; use constant CARD_TYPES => { VI => 'Visa', MC => 'MasterCard', - AX => 'American Express', + AX => 'American Express', # FIXME: AM? NN => 'Discover', + # JB? }; @@ -36,13 +37,25 @@ sub set_defaults { $self->path('/process.cgi'); $self->build_subs(qw( - receipt_number sales_order_number - cardholder card_type + receipt_number sales_number + card_type total_amount avs_response cvv2_response )); } +# OnlinePayment's get_fields now filters out undefs in 3.x. :( +# +sub get_fields { + my ($self, @fields) = @_; + + my %content = $self->content; + + my %new = map +($_ => $content{$_}), @fields; + + return %new; +} + # OnlinePayment's remap_fields is buggy, so we simply rewrite it # sub remap_fields { @@ -63,10 +76,6 @@ sub get_remap_fields { $self->remap_fields(reverse %map); my %data = $self->get_fields(keys %map); - foreach (values %data) { - $_ = '' unless defined; - } - return %data; } @@ -99,14 +108,13 @@ sub parse_expdate { # Convert a single product into a product string # sub prod_string { - my ($self, $currency, $taxes, %data) = @_; + my ($self, $currency, %data) = @_; croak "Missing amount in product" unless defined $data{amount}; my @flags = ($currency); - $taxes = uc $data{taxes} if defined $data{taxes}; - foreach (split ' ' => $taxes) { + foreach (split ' ' => uc($data{taxes} || '')) { croak "Unknown tax code $_" unless /^(GST|PST|HST)$/; push @flags, $_; } @@ -140,16 +148,14 @@ sub to_xml { croak 'Unsupported action' unless $content{action} =~ /^Normal Authori[zs]ation$/i; - $content{currency} ||= 'CAD'; - $content{currency} = uc $content{currency}; + $content{currency} = uc($content{currency} || 'CAD'); croak "Unknown currency code ", $content{currency} unless $content{currency} =~ /^(CAD|USD)$/; - $content{taxes} ||= ''; - $content{taxes} = uc $content{taxes}; + $content{taxes} = uc($content{taxes} || ''); my %data = $self->get_remap_fields(qw( - xxxCardNumber card_number + xxxCard_Number card_number xxxName name xxxCompany company @@ -174,7 +180,8 @@ sub to_xml { $data{MerchantNumber} = $self->merchant_id; - $data{xxxCardNumber} =~ tr/ //d; + $data{xxxCard_Number} =~ tr/ //d; + $data{xxxCard_Number} =~ s/^[^3-6]/4/ if $self->test_transaction; my ($y, $m) = $self->parse_expdate($content{exp_date}); $data{xxxCCYear} = sprintf '%.4u' => $y; @@ -190,16 +197,16 @@ sub to_xml { if (ref $content{description}) { $data{Products} = join '|' => map $self->prod_string( - $content{currency}, - $content{taxes}, - %$_), - @{ $content{description} }; + $content{currency}, + taxes => $content{taxes}, + %$_), + @{ $content{description} }; } else { $self->required_fields(qw(amount)); $data{Products} = $self->prod_string( $content{currency}, - $content{taxes}, - amount => $content{amount}, + taxes => $content{taxes}, + amount => $content{amount}, description => $content{description}, ); } @@ -207,6 +214,7 @@ sub to_xml { xml_out(\%data, NoAttr => 1, RootName => 'TranxRequest', + SuppressEmpty => undef, XMLDecl => '', ); } @@ -242,8 +250,7 @@ sub parse_response { $self->infuse($response, qw( ReceiptNumber receipt_number - SalesOrderNumber sales_order_number - xxxName cardholder + SalesOrderNumber sales_number CardType card_type Page result_code ApprovalCode authorization @@ -253,6 +260,9 @@ sub parse_response { CVV2ResponseCode cvv2_response )); + # Completely undocumented field that sometimes override + $self->error_message($response->{Error}) if $response->{Error}; + $self->card_type(CARD_TYPES->{$self->card_type}); $self->{products_raw} = $response->{Products}; @@ -352,7 +362,8 @@ to the merchant ID assigned to you by InternetSecure. =head1 METHODS -(See L for more methods.) +(Other methods are also available -- see L for more +details.) =head2 Before order submission @@ -415,12 +426,14 @@ Code (CVC2) or Card Identification number (CID), depending on the card issuer. A short description of the purchase. See L<"Products list syntax"> for an alternate syntax that allows a list of products to be specified. -=item amount +=item amount (usually required) + +Total amount to be billed, excluding taxes if they are to be added separately +by InternetSecure. -Total amount to be billed, excluding taxes if they are to be added separately. -This field is required if B is a string, and should be left -undefined if B contains a list of products, as outlined in -L<"Products list syntax">. +This field is required if B is a string, but should be left +undefined if B contains a list of products instead, as outlined +in L<"Products list syntax">. =item currency @@ -429,17 +442,15 @@ C (default) or C. =item taxes -Taxes to be added automatically. These should not be included in B; -they will be automatically added by InternetSecure later on. +Taxes to be added automatically to B by InternetSecure. -Available taxes are C, C and C. Taxes can be combined by -separating them with spaces, such as C. +Available taxes are C, C and C. Multiple taxes can specified +by concatenating them with spaces, such as C. =item name / company / address / city / state / zip / country / phone / email -Facultative customer information. B should be either a postal -abbreviation or a two-letter code taken from ISO 3166-2, and B should -be a two-letter code taken from ISO 3166-1. +Customer information. B should be a two-letter code taken from ISO +3166-1. =back @@ -449,18 +460,19 @@ be a two-letter code taken from ISO 3166-1. =over 4 -=item receipt_number() / sales_order_number() +=item receipt_number() -Receipt number and sales order number of submitted order. +Receipt number of this transaction; this is actually a string, unique to all +InternetSecure transactions. -=item total_amount() +=item sales_number() -Total amount billed for this order, including taxes. +Sales order number of this transaction. This is a number, unique to each +merchant, which is incremented by 1 each time. -=item cardholder() +=item total_amount() -Cardholder's name. This is currently a mere copy of the B field passed -to B. +Total amount billed for this order, including taxes. =item card_type() @@ -509,7 +521,7 @@ Unit price of this product. =item quantity -Ordered quantity of this product. This can be a decimal value. +Ordered quantity of this product. =item sku