X-Git-Url: http://git.freeside.biz/gitweb/?a=blobdiff_plain;f=FS%2FFS%2Fusage_class.pm;h=b64d26ac4198c9bf3038c15aed43d8987377a8b8;hb=7b125e587a4d1ee0aca692e23ea7897f671855ae;hp=26520e57934f9d4279e8a7341169cd5143fb60ba;hpb=f8f4c51eaa6f5aa3d49672fe7a17f19fa22494c0;p=freeside.git

diff --git a/FS/FS/usage_class.pm b/FS/FS/usage_class.pm
index 26520e579..b64d26ac4 100644
--- a/FS/FS/usage_class.pm
+++ b/FS/FS/usage_class.pm
@@ -127,7 +127,6 @@ my %summary_formats = (
     'align'  => [ qw( l r r r ) ],
     'span'   => [ qw( 4 1 1 1 ) ],            # unitprices?
     'width'  => [ qw( 8.2cm 2.5cm 1.4cm 1.6cm ) ],   # don't like this
-    'show'   => 1,
   },
   'simpler' => { 
     'label' =>  [ qw( Description Calls Amount ) ],
@@ -139,7 +138,6 @@ my %summary_formats = (
     'align'  => [ qw( l r r ) ],
     'span'   => [ qw( 5 1 1 ) ],
     'width'  => [ qw( 10.7cm 1.4cm 1.6cm ) ],   # don't like this
-    'show'   => 1,
   },
   'usage_simple' => { 
     'label' => [ qw( Date Time Number Destination Duration Amount ) ],
@@ -149,56 +147,16 @@ my %summary_formats = (
                   sub { ' ' },
                   sub { ' ' },
                   sub { ' ' },
-                  sub { my $href = shift;  #ugh! making bunk of 'normalization'
-                        $href->{subtotal} ? $href->{subtotal} : ' '
-                      },
-                ],
-    'align'  => [ qw( l l l l r r ) ],
-    'span'   => [ qw( 1 1 1 1 1 2 ) ],            # unitprices?
-    'width'  => [ qw( 4.3cm 1.4cm 2.5cm 2.5cm 1.4cm 1.6cm ) ],# don't like this
-    'show'   => 0,
-  },
-  'usage_6col' => { 
-    'label' => [ qw( col1 col2 col3 col4 col5 col6 ) ],
-    'fields' => [
                   sub { ' ' },
-                  sub { ' ' },
-                  sub { ' ' },
-                  sub { ' ' },
-                  sub { ' ' },
-                  sub { my $href = shift;  #ugh! making bunk of 'normalization'
-                        $href->{subtotal} ? $href->{subtotal} : ' '
-                      },
                 ],
     'align'  => [ qw( l l l l r r ) ],
-    'span'   => [ qw( 1 1 1 1 1 2 ) ],            # unitprices?
+    'span'   => [ qw( 2 1 1 1 1 1 ) ],            # unitprices?
     'width'  => [ qw( 4.3cm 1.4cm 2.5cm 2.5cm 1.4cm 1.6cm ) ],# don't like this
-    'show'   => 0,
-  },
-  'usage_7col' => { 
-    'label' => [ qw( col1 col2 col3 col4 col5 col6 col7 ) ],
-    'fields' => [
-                  sub { ' ' },
-                  sub { ' ' },
-                  sub { ' ' },
-                  sub { ' ' },
-                  sub { ' ' },
-                  sub { ' ' },
-                  sub { my $href = shift;  #ugh! making bunk of 'normalization'
-                        $href->{subtotal} ? $href->{subtotal} : ' '
-                      },
-                ],
-    'align'  => [ qw( l l l l l r r ) ],
-    'span'   => [ qw( 1 1 1 1 1 1 1 ) ],            # unitprices?
-    'width'  => [ qw( 2.9cm 1.4cm 1.4cm 2.5cm 2.5cm 1.4cm 1.6cm ) ],# don't like this
-    'show'   => 0,
   },
 );
 
 sub summary_formats_labelhash {
-  map { $_ => join(',', @{$summary_formats{$_}{label}}) }
-    grep { $summary_formats{$_}{show} }
-    keys %summary_formats;
+  map { $_ => join(',', @{$summary_formats{$_}{label}}) } keys %summary_formats;
 }
 
 =item header_generator FORMAT
@@ -215,16 +173,15 @@ my %html_align = (
 );
 
 sub _generator_defaults {
-  my ( $self, $format, %opt ) = @_;
-  my %format = ( %{ $summary_formats{$self->format} }, %opt );
-  return ( \%format, ' ', ' ', ' ', sub { shift } );
+  my ( $self, $format ) = ( shift, shift );
+  return ( $summary_formats{$self->format}, ' ', ' ', ' ', sub { shift } );
 }
 
 sub header_generator {
-  my ( $self, $format, %opt ) = @_;
+  my ( $self, $format ) = ( shift, shift );
 
   my ( $f, $prefix, $suffix, $separator, $column ) =
-    $self->_generator_defaults($format, %opt);
+    $self->_generator_defaults($format);
 
   if ($format eq 'latex') {
     $prefix = "\\hline\n\\rule{0pt}{2.5ex}\n\\makebox[1.4cm]{}&\n";
@@ -248,7 +205,7 @@ sub header_generator {
     my @args = @_;
     my @result = ();
 
-    foreach  (my $i = 0; exists($f->{label}->[$i]); $i++) {
+    foreach  (my $i = 0; $f->{label}->[$i]; $i++) {
       push @result,
         &{$column}( map { $f->{$_}->[$i] } qw(label align span width) );
     }
@@ -266,10 +223,10 @@ usage_class.  FORMAT is either html or latex
 =cut
 
 sub description_generator {
-  my ( $self, $format, %opt ) = @_;
+  my ( $self, $format ) = ( shift, shift );
 
   my ( $f, $prefix, $suffix, $separator, $column ) =
-    $self->_generator_defaults($format, %opt);
+    $self->_generator_defaults($format);
 
   if ($format eq 'latex') {
     $prefix = "\\hline\n\\multicolumn{1}{c}{\\rule{0pt}{2.5ex}~} &\n";
@@ -312,13 +269,13 @@ usage_class.  FORMAT is either html or latex
 =cut
 
 sub total_generator {
-  my ( $self, $format, %opt ) = @_;
+  my ( $self, $format ) = ( shift, shift );
 
 #  $OUT .= '\FStotaldesc{' . $section->{'description'} . ' Total}' .
 #          '{' . $section->{'subtotal'} . '}' . "\n";
 
   my ( $f, $prefix, $suffix, $separator, $column ) =
-    $self->_generator_defaults($format, %opt);
+    $self->_generator_defaults($format);
   my $style = '';
 
   if ($format eq 'latex') {
@@ -371,13 +328,13 @@ usage_class.  FORMAT is either html or latex
 # total_item and amount vs total_amount -- another array of functions?
 
 sub total_line_generator {
-  my ( $self, $format, %opt ) = @_;
+  my ( $self, $format ) = ( shift, shift );
 
 #     $OUT .= '\FStotaldesc{' . $line->{'total_item'} . '}' .
 #             '{' . $line->{'total_amount'} . '}' . "\n";
 
   my ( $f, $prefix, $suffix, $separator, $column ) =
-    $self->_generator_defaults($format, %opt);
+    $self->_generator_defaults($format);
   my $style = '';
 
   if ($format eq 'latex') {