X-Git-Url: http://git.freeside.biz/gitweb/?a=blobdiff_plain;f=FS%2FFS%2Fsvc_phone.pm;h=49453915005e62032156aab254c72d318ef87c9f;hb=bd928f5f74892da75dc3094a189c07fd8848ec07;hp=cffe1e3f6d2b53eae653d9c96f275d168109372f;hpb=1e1d4445682c0e69781654ea7f2851d861031e9f;p=freeside.git diff --git a/FS/FS/svc_phone.pm b/FS/FS/svc_phone.pm index cffe1e3f6..494539150 100644 --- a/FS/FS/svc_phone.pm +++ b/FS/FS/svc_phone.pm @@ -79,10 +79,6 @@ Voicemail PIN Optional svcnum from svc_pbx -=item route - -Route id/number - =item forwarddst Forwarding destination @@ -175,9 +171,6 @@ sub table_info { disable_inventory => 1, disable_select => 1, }, - 'route' => { label => 'Route', - %dis2, - }, 'forwarddst' => { label => 'Forward Destination', %dis2, }, @@ -477,7 +470,6 @@ sub check { || $self->ut_foreign_keyn('pbxsvc', 'svc_pbx', 'svcnum' ) || $self->ut_foreign_keyn('domsvc', 'svc_domain', 'svcnum' ) || $self->ut_foreign_keyn('locationnum', 'cust_location', 'locationnum') - || $self->ut_textn('route') || $self->ut_numbern('forwarddst') || $self->ut_textn('email') || $self->ut_numbern('lrn') @@ -714,8 +706,8 @@ sub get_cdrs { my @orwhere = map " $_ = '$number' ", @fields; push @orwhere, map " $_ = '$prefix$number' ", @fields - if length($prefix); - if ( $prefix =~ /^\+(\d+)$/ ) { + if defined($prefix) && length($prefix); + if ( $prefix && $prefix =~ /^\+(\d+)$/ ) { push @orwhere, map " $_ = '$1$number' ", @fields } @@ -735,7 +727,8 @@ sub get_cdrs { 'table' => 'cdr', 'hashref' => \%hash, 'extra_sql' => $extra_sql, - 'order_by' => "ORDER BY startdate $for_update", + 'order_by' => $options{'billsec_sum'} ? '' : "ORDER BY startdate $for_update", + 'select' => $options{'billsec_sum'} ? 'sum(billsec) as billsec_sum' : '*', } ); @cdrs;