X-Git-Url: http://git.freeside.biz/gitweb/?a=blobdiff_plain;f=FS%2FFS%2Fsvc_phone.pm;h=071b8073cddda48854a6b3d8cc93c1e5b3bfc76d;hb=046395d0a66db2f057c80768e01ae0f5b06bc555;hp=bd92ed84be4122eff29f0658282d16a116396723;hpb=bb5907148eb298e2e509fa37e23dcbe63619db9d;p=freeside.git diff --git a/FS/FS/svc_phone.pm b/FS/FS/svc_phone.pm index bd92ed84b..071b8073c 100644 --- a/FS/FS/svc_phone.pm +++ b/FS/FS/svc_phone.pm @@ -1,12 +1,25 @@ package FS::svc_phone; use strict; -use vars qw( @ISA ); -#use FS::Record qw( qsearch qsearchs ); +use vars qw( @ISA @pw_set $conf ); +use FS::Conf; +use FS::Record qw( qsearch qsearchs dbh ); +use FS::Msgcat qw(gettext); use FS::svc_Common; +use FS::part_svc; +use FS::phone_device; +use FS::svc_pbx; @ISA = qw( FS::svc_Common ); +#avoid l 1 and o O 0 +@pw_set = ( 'a'..'k', 'm','n', 'p-z', 'A'..'N', 'P'..'Z' , '2'..'9' ); + +#ask FS::UID to run this stuff for us later +$FS::UID::callback{'FS::svc_acct'} = sub { + $conf = new FS::Conf; +}; + =head1 NAME FS::svc_phone - Object methods for svc_phone records @@ -39,13 +52,25 @@ from FS::Record. The following fields are currently supported: =over 4 -=item svcnum - primary key +=item svcnum + +primary key + +=item countrycode + +=item phonenum -=item countrycode - +=item sip_password -=item phonenum - +=item pin -=item pin - +Voicemail PIN + +=item phone_name + +=item pbxsvc + +Optional svcnum from svc_pbx =back @@ -71,23 +96,32 @@ sub table_info { 'display_weight' => 60, 'cancel_weight' => 80, 'fields' => { - 'countrycode' => { label => 'Country code', - type => 'text', - disable_inventory => 1, - disable_select => 1, - }, - 'phonenum' => 'Phone number', - 'pin' => { label => 'Personal Identification Number', - type => 'text', - disable_inventory => 1, - disable_select => 1, - }, + 'countrycode' => { label => 'Country code', + type => 'text', + disable_inventory => 1, + disable_select => 1, + }, + 'phonenum' => 'Phone number', + 'pin' => { label => 'Personal Identification Number', + type => 'text', + disable_inventory => 1, + disable_select => 1, + }, + 'sip_password' => 'SIP password', + 'phone_name' => 'Name', + 'pbxsvc' => { label => 'PBX', + type => 'select-svc_pbx.html', + disable_inventory => 1, + disable_select => 1, #UI wonky, pry works otherwise + }, }, }; } sub table { 'svc_phone'; } +sub table_dupcheck_fields { ( 'countrycode', 'phonenum' ); } + =item search_sql STRING Class method which returns an SQL fragment to search for the given string. @@ -96,6 +130,22 @@ Class method which returns an SQL fragment to search for the given string. sub search_sql { my( $class, $string ) = @_; + + if ( $conf->exists('svc_phone-allow_alpha_phonenum') ) { + $string =~ s/\W//g; + } else { + $string =~ s/\D//g; + } + + my $conf = new FS::Conf; + my $ccode = ( $conf->exists('default_phone_countrycode') + && $conf->config('default_phone_countrycode') + ) + ? $conf->config('default_phone_countrycode') + : '1'; + + $string =~ s/^$ccode//; + $class->search_sql_field('phonenum', $string ); } @@ -107,7 +157,10 @@ Returns the phone number. sub label { my $self = shift; - $self->phonenum; #XXX format it better + my $phonenum = $self->phonenum; #XXX format it better + my $label = $phonenum; + $label .= ' ('.$self->phone_name.')' if $self->phone_name; + $label; } =item insert @@ -125,6 +178,39 @@ Delete this record from the database. =cut +sub delete { + my $self = shift; + + local $SIG{HUP} = 'IGNORE'; + local $SIG{INT} = 'IGNORE'; + local $SIG{QUIT} = 'IGNORE'; + local $SIG{TERM} = 'IGNORE'; + local $SIG{TSTP} = 'IGNORE'; + local $SIG{PIPE} = 'IGNORE'; + + my $oldAutoCommit = $FS::UID::AutoCommit; + local $FS::UID::AutoCommit = 0; + my $dbh = dbh; + + foreach my $phone_device ( $self->phone_device ) { + my $error = $phone_device->delete; + if ( $error ) { + $dbh->rollback if $oldAutoCommit; + return $error; + } + } + + my $error = $self->SUPER::delete; + if ( $error ) { + $dbh->rollback if $oldAutoCommit; + return $error; + } + + $dbh->commit or die $dbh->errstr if $oldAutoCommit; + ''; + +} + # the delete method can be inherited from FS::Record =item replace OLD_RECORD @@ -162,24 +248,104 @@ and replace methods. sub check { my $self = shift; + my $conf = new FS::Conf; + my $phonenum = $self->phonenum; - $phonenum =~ s/\D//g; + my $phonenum_check_method; + if ( $conf->exists('svc_phone-allow_alpha_phonenum') ) { + $phonenum =~ s/\W//g; + $phonenum_check_method = 'ut_alpha'; + } else { + $phonenum =~ s/\D//g; + $phonenum_check_method = 'ut_number'; + } $self->phonenum($phonenum); my $error = $self->ut_numbern('svcnum') || $self->ut_numbern('countrycode') - || $self->ut_number('phonenum') - || $self->ut_anythingn('sip_password') + || $self->$phonenum_check_method('phonenum') + || $self->ut_anything('sip_password') || $self->ut_numbern('pin') + || $self->ut_textn('phone_name') + || $self->ut_foreign_keyn('pbxsvc', 'svc_pbx', 'svcnum' ) ; return $error if $error; $self->countrycode(1) unless $self->countrycode; + unless ( length($self->sip_password) ) { + + $self->sip_password( + join('', map $pw_set[ int(rand $#pw_set) ], (0..16) ) + ); + + } + $self->SUPER::check; } +=item _check duplicate + +Internal method to check for duplicate phone numers. + +=cut + +#false laziness w/svc_acct.pm's _check_duplicate. +sub _check_duplicate { + my $self = shift; + + my $global_unique = $conf->config('global_unique-phonenum') || 'none'; + return '' if $global_unique eq 'disabled'; + + $self->lock_table; + + my @dup_ccphonenum = + grep { !$self->svcnum || $_->svcnum != $self->svcnum } + qsearch( 'svc_phone', { + 'countrycode' => $self->countrycode, + 'phonenum' => $self->phonenum, + }); + + return gettext('phonenum_in_use') + if $global_unique eq 'countrycode+phonenum' && @dup_ccphonenum; + + my $part_svc = qsearchs('part_svc', { 'svcpart' => $self->svcpart } ); + unless ( $part_svc ) { + return 'unknown svcpart '. $self->svcpart; + } + + if ( @dup_ccphonenum ) { + + my $exports = FS::part_export::export_info('svc_phone'); + my %conflict_ccphonenum_svcpart = ( $self->svcpart => 'SELF', ); + + foreach my $part_export ( $part_svc->part_export ) { + + #this will catch to the same exact export + my @svcparts = map { $_->svcpart } $part_export->export_svc; + + $conflict_ccphonenum_svcpart{$_} = $part_export->exportnum + foreach @svcparts; + + } + + foreach my $dup_ccphonenum ( @dup_ccphonenum ) { + my $dup_svcpart = $dup_ccphonenum->cust_svc->svcpart; + if ( exists($conflict_ccphonenum_svcpart{$dup_svcpart}) ) { + return "duplicate phone number ". + $self->countrycode. ' '. $self->phonenum. + ": conflicts with svcnum ". $dup_ccphonenum->svcnum. + " via exportnum ". $conflict_ccphonenum_svcpart{$dup_svcpart}; + } + } + + } + + return ''; + +} + =item check_pin Checks the supplied PIN against the PIN in the database. Returns true for a @@ -189,7 +355,47 @@ sucessful authentication, false if no match. sub check_pin { my($self, $check_pin) = @_; - $check_pin eq $self->pin; + length($self->pin) && $check_pin eq $self->pin; +} + +=item radius_reply + +=cut + +sub radius_reply { + my $self = shift; + #XXX Session-Timeout! holy shit, need rlm_perl to ask for this in realtime + (); +} + +=item radius_check + +=cut + +sub radius_check { + my $self = shift; + my %check = (); + + my $conf = new FS::Conf; + + $check{'User-Password'} = $conf->config('svc_phone-radius-default_password'); + + %check; +} + +sub radius_groups { + (); +} + +=item phone_device + +Returns any FS::phone_device records associated with this service. + +=cut + +sub phone_device { + my $self = shift; + qsearch('phone_device', { 'svcnum' => $self->svcnum } ); } =back