X-Git-Url: http://git.freeside.biz/gitweb/?a=blobdiff_plain;f=FS%2FFS%2Frate.pm;h=f30e4c772c5b2d5d1f69954686a0932d2cc177c5;hb=387c96b0d8f224f3ade27bed9348f37b432bbb8a;hp=1cc215244f460fc48300c63f687ff2ae8409ea08;hpb=76a0c0009d9780cedd74e481ae6530010d210b3f;p=freeside.git diff --git a/FS/FS/rate.pm b/FS/FS/rate.pm index 1cc215244..f30e4c772 100644 --- a/FS/FS/rate.pm +++ b/FS/FS/rate.pm @@ -2,14 +2,12 @@ package FS::rate; use strict; use vars qw( @ISA $DEBUG ); -use Storable qw(thaw); -use Data::Dumper; use FS::Record qw( qsearch qsearchs dbh fields ); use FS::rate_detail; @ISA = qw(FS::Record); -$DEBUG = 1; +$DEBUG = 0; =head1 NAME @@ -271,18 +269,82 @@ sub check { $self->SUPER::check; } -=item dest_detail REGIONNUM | RATE_REGION_OBJECTD +=item dest_detail REGIONNUM | RATE_REGION_OBJECTD | HASHREF Returns the rate detail (see L) for this rate to the -specificed destination. +specificed destination, or the empty string if no rate can be found for +the given destination. + +Destination can be specified as an FS::rate_detail object or regionnum +(see L), or as a hashref with two keys: I +and I. + +An optional third key, I, will return a timed rate (one with +a non-null I) if one exists for a call at that time. If +no matching timed rate exists, the non-timed rate will be returned. =cut sub dest_detail { my $self = shift; - my $regionnum = ref($_[0]) ? shift->regionnum : shift; - qsearchs( 'rate_detail', { 'ratenum' => $self->ratenum, - 'dest_regionnum' => $regionnum, } ); + + my $regionnum; + my $weektime; + if ( ref($_[0]) eq 'HASH' ) { + + my $countrycode = $_[0]->{'countrycode'}; + my $phonenum = $_[0]->{'phonenum'}; + $weektime = $_[0]->{'weektime'}; + + #find a rate prefix, first look at most specific, then fewer digits, + # finally trying the country code only + my $rate_prefix = ''; + for my $len ( reverse(1..10) ) { + $rate_prefix = qsearchs('rate_prefix', { + 'countrycode' => $countrycode, + #'npa' => { op=> 'LIKE', value=> substr($number, 0, $len) } + 'npa' => substr($phonenum, 0, $len), + } ) and last; + } + $rate_prefix ||= qsearchs('rate_prefix', { + 'countrycode' => $countrycode, + 'npa' => '', + }); + + return '' unless $rate_prefix; + + $regionnum = $rate_prefix->regionnum; + + #$rate_region = $rate_prefix->rate_region; + + } else { + $regionnum = ref($_[0]) ? shift->regionnum : shift; + } + + if(!defined($weektime)) { + return qsearchs( 'rate_detail', + { 'ratenum' => $self->ratenum, + 'dest_regionnum' => $regionnum, + 'ratetimenum' => '', + } ); + } + else { + my @details = grep { my $rate_time = $_->rate_time; + $rate_time && $rate_time->contains($weektime) } + qsearch( 'rate_detail', + { 'ratenum' => $self->ratenum, + 'dest_regionnum' => $regionnum, } ); + if(!@details) { + # this may change at some point + return $self->dest_detail($regionnum); + } + elsif(@details == 1) { + return $details[0]; + } + else { + die "overlapping rate_detail times (region $regionnum, time $weektime)\n"; + } + } } =item rate_detail @@ -309,6 +371,8 @@ Experimental job-queue processor for web interface adds/edits =cut +use Storable qw(thaw); +use Data::Dumper; use MIME::Base64; sub process { my $job = shift; @@ -328,6 +392,7 @@ sub process { 'dest_regionnum' => $regionnum, map { $_ => $param->{"$_$regionnum"} } qw( min_included min_charge sec_granularity ) + #qw( min_included conn_charge conn_sec min_charge sec_granularity ) }; } else { @@ -335,6 +400,9 @@ sub process { new FS::rate_detail { 'dest_regionnum' => $regionnum, 'min_included' => 0, + 'conn_charge' => 0, + 'conn_sec' => 0, + 'conn_charge' => 0, 'min_charge' => 0, 'sec_granularity' => '60' }; @@ -351,10 +419,13 @@ sub process { my $error = ''; if ( $param->{'ratenum'} ) { warn "$rate replacing $old (". $param->{'ratenum'}. ")\n" if $DEBUG; - $error = $rate->replace( $old, - 'rate_detail' => \@rate_detail, - 'job' => $job, - ); + + my @param = ( 'job'=>$job ); + push @param, 'rate_detail'=>\@rate_detail + unless $param->{'preserve_rate_detail'}; + + $error = $rate->replace( $old, @param ); + } else { warn "inserting $rate\n" if $DEBUG; $error = $rate->insert( 'rate_detail' => \@rate_detail, @@ -363,7 +434,7 @@ sub process { #$ratenum = $rate->getfield('ratenum'); } - die $error if $error; + die "$error\n" if $error; }