X-Git-Url: http://git.freeside.biz/gitweb/?a=blobdiff_plain;f=FS%2FFS%2Fpayinfo_Mixin.pm;h=01b222634130d6b6ee2fe15a83be00fd07b30f5f;hb=103dfde149eec5034696d073253255f508a1be78;hp=7401eb9c8eced76c54604f87c10db785585a6726;hpb=edd6a339eb7ea156272264ffd164711fc8af792e;p=freeside.git diff --git a/FS/FS/payinfo_Mixin.pm b/FS/FS/payinfo_Mixin.pm index 7401eb9c8..01b222634 100644 --- a/FS/FS/payinfo_Mixin.pm +++ b/FS/FS/payinfo_Mixin.pm @@ -197,20 +197,18 @@ sub payinfo_check { if ( $self->payby eq 'CARD' && ! $self->is_encrypted($self->payinfo) ) { - unless ( $self->paycardtype ) { - - if ( $self->tokenized ) { - if ( $self->paymask =~ /^\d+x/ ) { - $self->set('paycardtype', cardtype($self->paymask)); - } else { - $self->set('paycardtype', ''); - # return "paycardtype required ". - # "(can't derive from a token and no paymask w/prefix provided)"; - } + # see parallel checks in cust_payby::check & cust_payby::check_payinfo_cardtype + if ( $self->tokenized ) { + $self->set('is_tokenized', 'Y'); #so we don't try to do it again + if ( $self->paymask =~ /^\d+x/ ) { + $self->set('paycardtype', cardtype($self->paymask)); } else { - $self->set('paycardtype', cardtype($self->payinfo)); + $self->set('paycardtype', '') unless $self->paycardtype; + #return "paycardtype required ". + # "(can't derive from a token and no paymask w/prefix provided)"; } - + } else { + $self->set('paycardtype', cardtype($self->payinfo)); } if ( $ignore_masked_payinfo and $self->mask_payinfo eq $self->payinfo ) { @@ -220,7 +218,7 @@ sub payinfo_check { $payinfo =~ s/\D//g; $self->payinfo($payinfo); if ( $self->payinfo ) { - $self->payinfo =~ /^(\d{13,16}|\d{8,9})$/ + $self->payinfo =~ /^(\d{13,19}|\d{8,9})$/ or return "Illegal (mistyped?) credit card number (payinfo)"; $self->payinfo($1); validate($self->payinfo) or return "Illegal credit card number"; @@ -232,17 +230,13 @@ sub payinfo_check { } else { - unless ( $self->paycardtype ) { - - if ( $self->payby eq 'CARD' && $self->paymask =~ /^\d+x/ ) { - # if we can't decrypt the card, at least detect the cardtype - $self->set('paycardtype', cardtype($self->paymask)); - } else { - $self->set('paycardtype', ''); - # return "paycardtype required ". - # "(can't derive from a token and no paymask w/prefix provided)"; - } - + if ( $self->payby eq 'CARD' && $self->paymask =~ /^\d+x/ ) { + # if we can't decrypt the card, at least detect the cardtype + $self->set('paycardtype', cardtype($self->paymask)); + } else { + $self->set('paycardtype', '') unless $self->paycardtype; + # return "paycardtype required ". + # "(can't derive from a token and no paymask w/prefix provided)"; } if ( $self->is_encrypted($self->payinfo) ) {