X-Git-Url: http://git.freeside.biz/gitweb/?a=blobdiff_plain;f=FS%2FFS%2Fpart_pkg%2Fsubscription.pm;h=0dfe049fe734c639b5432e25d1b6780b528d60e9;hb=d62206a94d9d49ef96640e0a8ec492679f8345e9;hp=3e5a41669e5b35bc3328a1916d2f2fd4c9171763;hpb=093fbb43eb8cfa3f94c8416ac9d2b7b078d8ee18;p=freeside.git diff --git a/FS/FS/part_pkg/subscription.pm b/FS/FS/part_pkg/subscription.pm index 3e5a41669..0dfe049fe 100644 --- a/FS/FS/part_pkg/subscription.pm +++ b/FS/FS/part_pkg/subscription.pm @@ -10,14 +10,10 @@ use FS::part_pkg::flat; %info = ( 'name' => 'First partial month full charge, then flat-rate (selectable billing day)', + 'shortname' => 'Subscription (Nth of month, full charge for first)', + 'inherit_fields' => [ 'usage_Mixin', 'global_Mixin' ], 'fields' => { - 'setup_fee' => { 'name' => 'Setup fee for this package', - 'default' => 0, - }, - 'recur_fee' => { 'name' => 'Recurring fee for this package', - 'default' => 0, - }, - 'cutoff_day' => { 'name' => 'billing day', + 'cutoff_day' => { 'name' => 'Billing day', 'default' => 1, }, 'seconds' => { 'name' => 'Time limit for this package', @@ -70,28 +66,27 @@ use FS::part_pkg::flat; 'over into current period', 'type' => 'checkbox', }, + 'recharge_reset' => { 'name' => 'Reset usage to these values on manual '. + 'package recharge', + 'type' => 'checkbox', + }, + #it would be better if this had to be turned on, its confusing 'externalid' => { 'name' => 'Optional External ID', 'default' => '', }, }, - 'fieldorder' => [ 'setup_fee', 'recur_fee', 'cutoff_day', 'seconds', + 'fieldorder' => [ 'cutoff_day', 'seconds', 'upbytes', 'downbytes', 'totalbytes', 'recharge_amount', 'recharge_seconds', 'recharge_upbytes', 'recharge_downbytes', 'recharge_totalbytes', - 'externalid' ], - 'fieldorder' => [ 'setup_fee', 'recur_fee','cutoff_day', 'seconds', - 'upbytes', 'downbytes', 'totalbytes', - 'recharge_amount', 'recharge_seconds', 'recharge_upbytes', - 'recharge_downbytes', 'recharge_totalbytes', - 'usage_rollover', - ], + 'usage_rollover', 'recharge_reset', 'externalid' ], 'freq' => 'm', 'weight' => 30, ); sub calc_recur { - my($self, $cust_pkg, $sdate ) = @_; + my($self, $cust_pkg, $sdate, $details, $param ) = @_; my $cutoff_day = $self->option('cutoff_day', 1) || 1; my $mnow = $$sdate; my ($sec,$min,$hour,$mday,$mon,$year) = (localtime($mnow) )[0,1,2,3,4,5]; @@ -103,7 +98,11 @@ sub calc_recur { $$sdate = timelocal(0,0,0,$cutoff_day,$mon,$year); - $self->option('recur_fee'); + my $br = $self->base_recur($cust_pkg, $sdate); + + my $discount = $self->calc_discount($cust_pkg, $sdate, $details, $param); + + sprintf('%.2f', ($cust_pkg->quantity || 1) * ($br - $discount) ); } 1;