X-Git-Url: http://git.freeside.biz/gitweb/?a=blobdiff_plain;f=FS%2FFS%2Fpart_pkg%2Fprorate.pm;h=d3ca77ae98d00979060a019f8dc6f4bcd384e181;hb=2b311f86e0560428f34d798fe95161dab52e321e;hp=02ce6b9a73b082fcadd029ef43eefd24d6804447;hpb=eb4ff7f73c5d4bdf74a3472448b5a195598ff4cd;p=freeside.git diff --git a/FS/FS/part_pkg/prorate.pm b/FS/FS/part_pkg/prorate.pm index 02ce6b9a7..d3ca77ae9 100644 --- a/FS/FS/part_pkg/prorate.pm +++ b/FS/FS/part_pkg/prorate.pm @@ -10,7 +10,8 @@ use FS::part_pkg::flat; %info = ( 'name' => 'First partial month pro-rated, then flat-rate (selectable billing day)', - 'fields' => { + 'shortname' => 'Prorate (Nth of month billing)', + 'fields' => { 'setup_fee' => { 'name' => 'Setup fee for this package', 'default' => 0, }, @@ -21,56 +22,74 @@ use FS::part_pkg::flat; ' of service at cancellation', 'type' => 'checkbox', }, - 'cutoff_day' => { 'name' => 'Billing_Day (1 - 28)', - 'default' => 1, - }, + 'cutoff_day' => { 'name' => 'Billing Day (1 - 28)', + 'default' => 1, + }, 'seconds' => { 'name' => 'Time limit for this package', 'default' => '', + 'check' => sub { shift =~ /^\d*$/ }, }, 'upbytes' => { 'name' => 'Upload limit for this package', 'default' => '', + 'check' => sub { shift =~ /^\d*$/ }, 'format' => \&FS::UI::bytecount::display_bytecount, 'parse' => \&FS::UI::bytecount::parse_bytecount, }, 'downbytes' => { 'name' => 'Download limit for this package', 'default' => '', + 'check' => sub { shift =~ /^\d*$/ }, 'format' => \&FS::UI::bytecount::display_bytecount, 'parse' => \&FS::UI::bytecount::parse_bytecount, }, 'totalbytes' => { 'name' => 'Transfer limit for this package', 'default' => '', + 'check' => sub { shift =~ /^\d*$/ }, 'format' => \&FS::UI::bytecount::display_bytecount, 'parse' => \&FS::UI::bytecount::parse_bytecount, }, 'recharge_amount' => { 'name' => 'Cost of recharge for this package', 'default' => '', + 'check' => sub { shift =~ /^\d*(\.\d{2})?$/ }, }, 'recharge_seconds' => { 'name' => 'Recharge time for this package', 'default' => '', + 'check' => sub { shift =~ /^\d*$/ }, }, 'recharge_upbytes' => { 'name' => 'Recharge upload for this package', 'default' => '', + 'check' => sub { shift =~ /^\d*$/ }, 'format' => \&FS::UI::bytecount::display_bytecount, 'parse' => \&FS::UI::bytecount::parse_bytecount, }, 'recharge_downbytes' => { 'name' => 'Recharge download for this package', 'default' => '', + 'check' => sub { shift =~ /^\d*$/ }, 'format' => \&FS::UI::bytecount::display_bytecount, 'parse' => \&FS::UI::bytecount::parse_bytecount, }, 'recharge_totalbytes' => { 'name' => 'Recharge transfer for this package', 'default' => '', + 'check' => sub { shift =~ /^\d*$/ }, 'format' => \&FS::UI::bytecount::display_bytecount, 'parse' => \&FS::UI::bytecount::parse_bytecount, }, + 'usage_rollover' => { 'name' => 'Allow usage from previous period to roll '. + 'over into current period', + 'type' => 'checkbox', + }, + 'recharge_reset' => { 'name' => 'Reset usage to these values on manual '. + 'package recharge', + 'type' => 'checkbox', + }, + #it would be better if this had to be turned on, its confusing 'externalid' => { 'name' => 'Optional External ID', 'default' => '', }, - }, + }, 'fieldorder' => [ 'setup_fee', 'recur_fee', 'unused_credit', 'cutoff_day', 'seconds', 'upbyte', 'downbytes', 'totalbytes', 'recharge_amount', 'recharge_seconds', 'recharge_upbytes', 'recharge_downbytes', 'recharge_totalbytes', - 'externalid', ], + 'usage_rollover', 'recharge_reset', 'externalid', ], 'freq' => 'm', 'weight' => 20, ); @@ -83,8 +102,6 @@ sub calc_recur { my $mend; my $mstart; - $self->reset_usage($cust_pkg); - if ( $mday >= $cutoff_day ) { $mend = timelocal(0,0,0,$cutoff_day, $mon == 11 ? 0 : $mon+1, $year+($mon==11));