X-Git-Url: http://git.freeside.biz/gitweb/?a=blobdiff_plain;f=FS%2FFS%2Fcust_bill_pkg_void.pm;h=604c615de18dab202b367d8bcfb18205f0065610;hb=91c7741223e84c67b64693cf4bbab6cfbd944e7e;hp=8bd80887ed71cbae2b99221bb39a67715c1c66db;hpb=392d4b113894af4ff051e3363d8b3c78c2d223dc;p=freeside.git diff --git a/FS/FS/cust_bill_pkg_void.pm b/FS/FS/cust_bill_pkg_void.pm index 8bd80887e..604c615de 100644 --- a/FS/FS/cust_bill_pkg_void.pm +++ b/FS/FS/cust_bill_pkg_void.pm @@ -276,6 +276,7 @@ sub _upgrade_data { # class method my $error; # fix voids with tax from before July 2013, when the taxable_billpkgnum # field was added to the void table + local $FS::Record::nowarn_classload = 1; my $search = FS::Cursor->new({ 'table' => 'cust_bill_pkg_tax_location_void', 'hashref' => { 'taxable_billpkgnum' => '' } @@ -287,11 +288,14 @@ sub _upgrade_data { # class method my $unvoid = qsearchs({ 'table' => 'h_cust_bill_pkg_tax_location', 'hashref' => { 'billpkgtaxlocationnum' => $num }, + 'extra_sql' => ' AND taxable_billpkgnum IS NOT NULL', 'order_by' => ' ORDER BY history_date DESC LIMIT 1' }); if (!$unvoid) { # should never happen - die "billpkgtaxlocationnum $num: could not find pre-void history record to restore taxable_billpkgnum."; + # but should this be fatal? or wait until someone actually tries to + # use the record? + warn "billpkgtaxlocationnum $num: could not find pre-void history record to restore taxable_billpkgnum."; } if ($unvoid) { $void->set('taxable_billpkgnum', $unvoid->taxable_billpkgnum);