X-Git-Url: http://git.freeside.biz/gitweb/?a=blobdiff_plain;f=FS%2FFS%2Faccess_user.pm;h=8cc8b64fc4f5c35de641656ad41f0bf4c763cd6d;hb=e078ca418dcf3c7b92efcd371ce761df3314c369;hp=63ae30d36f76f6505f2f2443e5a941b97ab452e3;hpb=df676d82034cb63ff357f8d8ed0f95ce788fb98b;p=freeside.git diff --git a/FS/FS/access_user.pm b/FS/FS/access_user.pm index 63ae30d36..8cc8b64fc 100644 --- a/FS/FS/access_user.pm +++ b/FS/FS/access_user.pm @@ -1,7 +1,7 @@ package FS::access_user; use strict; -use vars qw( @ISA $htpasswd_file ); +use vars qw( @ISA $DEBUG $me $conf $htpasswd_file ); use FS::UID; use FS::Conf; use FS::Record qw( qsearch qsearchs dbh ); @@ -14,9 +14,12 @@ use FS::agent; @ISA = qw( FS::m2m_Common FS::option_Common FS::Record ); #@ISA = qw( FS::m2m_Common FS::option_Common ); +$DEBUG = 0; +$me = '[FS::access_user]'; + #kludge htpasswd for now (i hope this bootstraps okay) FS::UID->install_callback( sub { - my $conf = new FS::Conf; + $conf = new FS::Conf; $htpasswd_file = $conf->base_dir. '/htpasswd'; } ); @@ -41,8 +44,8 @@ FS::access_user - Object methods for access_user records =head1 DESCRIPTION -An FS::access_user object represents an internal access user. FS::access_user inherits from -FS::Record. The following fields are currently supported: +An FS::access_user object represents an internal access user. FS::access_user +inherits from FS::Record. The following fields are currently supported: =over 4 @@ -271,6 +274,9 @@ sub name { =item access_usergroup +Returns links to the the groups this user is a part of, as FS::access_usergroup +objects (see L). + =cut sub access_usergroup { @@ -413,16 +419,29 @@ sub access_right { $rightname = [ $rightname ] unless ref($rightname); + warn "$me access_right called on ". join(', ', @$rightname). "\n" + if $DEBUG; + #some caching of ACL requests for low-hanging fruit perf improvement #since we get a new $CurrentUser object each page view there shouldn't be any #issues with stickiness if ( $self->{_ACLcache} ) { - return grep $self->{_ACLcache}{$_}, @$rightname - unless grep !exists($self->{_ACLcache}{$_}), @$rightname; + unless ( grep !exists($self->{_ACLcache}{$_}), @$rightname ) { + warn "$me ACL cache hit for ". join(', ', @$rightname). "\n" + if $DEBUG; + return grep $self->{_ACLcache}{$_}, @$rightname + } + + warn "$me ACL cache miss for ". join(', ', @$rightname). "\n" + if $DEBUG; } else { + + warn "initializing ACL cache\n" + if $DEBUG; $self->{_ACLcache} = {}; + } my $has_right = ' rightname IN ('. join(',', map '?', @$rightname ). ') '; @@ -440,8 +459,31 @@ sub access_right { $sth->execute($self->usernum, @$rightname) or die $sth->errstr; my $row = $sth->fetchrow_arrayref; - #$row ? $row->[0] : ''; - $self->{_ACLcache}{$rightname} = ( $row ? $row->[0] : '' ); + my $return = $row ? $row->[0] : ''; + + #just caching the single-rightname hits should be enough of a win for now + if ( scalar(@$rightname) == 1 ) { + $self->{_ACLcache}{${$rightname}[0]} = $return; + } + + $return; + +} + +=item default_customer_view + +Returns the default customer view for this user, from the +"default_customer_view" user preference, the "cust_main-default_view" config, +or the hardcoded default, "jumbo" (may change to "basics" in the near future). + +=cut + +sub default_customer_view { + my $self = shift; + + $self->option('default_customer_view') + || $conf->config('cust_main-default_view') + || 'jumbo'; #'basics' in 1.9.1? }