X-Git-Url: http://git.freeside.biz/gitweb/?a=blobdiff_plain;f=FS%2FFS%2FTicketSystem%2FRT_External.pm;h=2995b88a494917a4d813d5ade34b122d11469d6c;hb=ad7f49821d40ffd099a45acc32ba91e0e211aede;hp=7dde8622814580be28b912ac61fa5d0dda5024fe;hpb=c8cccb4a92adceb943c635fe62dad0d034462ce0;p=freeside.git diff --git a/FS/FS/TicketSystem/RT_External.pm b/FS/FS/TicketSystem/RT_External.pm index 7dde86228..2995b88a4 100644 --- a/FS/FS/TicketSystem/RT_External.pm +++ b/FS/FS/TicketSystem/RT_External.pm @@ -1,22 +1,29 @@ package FS::TicketSystem::RT_External; use strict; -use vars qw( $conf $default_queueid +use vars qw( $DEBUG $me $conf $dbh $default_queueid $external_url + $priority_reverse $priority_field $priority_field_queue $field - $dbh $external_url ); + ); use URI::Escape; use FS::UID qw(dbh); use FS::Record qw(qsearchs); use FS::cust_main; +use Carp qw(cluck); + +$me = '[FS::TicketSystem::RT_External]'; +$DEBUG = 0; FS::UID->install_callback( sub { $conf = new FS::Conf; $default_queueid = $conf->config('ticket_system-default_queueid'); + $priority_reverse = $conf->exists('ticket_system-priority_reverse'); $priority_field = $conf->config('ticket_system-custom_priority_field'); if ( $priority_field ) { $priority_field_queue = $conf->config('ticket_system-custom_priority_field_queue'); + $field = $priority_field_queue ? $priority_field_queue. '.%7B'. $priority_field. '%7D' : $priority_field; @@ -35,6 +42,17 @@ FS::UID->install_callback( sub { $external_url = $conf->config('ticket_system-rt_external_url'); } + #kludge... should *use* the id... but good enough for now + if ( $priority_field_queue =~ /^(\d+)$/ ) { + my $id = $1; + my $sql = 'SELECT Name FROM Queues WHERE Id = ?'; + my $sth = $dbh->prepare($sql) or die $dbh->errstr. " preparing $sql"; + $sth->execute($id) or die $sth->errstr. " executing $sql"; + + $priority_field_queue = $sth->fetchrow_arrayref->[0]; + + } + } ); sub num_customer_tickets { @@ -43,6 +61,7 @@ sub num_customer_tickets { my( $from_sql, @param) = $self->_from_customer( $custnum, $priority ); my $sql = "SELECT COUNT(*) $from_sql"; + warn "$me $sql (@param)" if $DEBUG; my $sth = $dbh->prepare($sql) or die $dbh->errstr. " preparing $sql"; $sth->execute(@param) or die $sth->errstr. " executing $sql"; @@ -55,9 +74,20 @@ sub customer_tickets { $limit ||= 0; my( $from_sql, @param) = $self->_from_customer( $custnum, $priority ); - my $sql = "SELECT tickets.*, queues.name". - ( length($priority) ? ", objectcustomfieldvalues.content" : '' ). - " $from_sql ORDER BY priority, id DESC LIMIT $limit"; + my $sql = " + SELECT Tickets.*, + Queues.Name AS Queue, + Users.Name AS Owner, + position(Tickets.Status in 'newopenstalledresolvedrejecteddeleted') + AS svalue + ". ( length($priority) ? ", ObjectCustomFieldValues.Content" : '' )." + $from_sql + ORDER BY svalue, + Priority ". ( $priority_reverse ? 'ASC' : 'DESC' ). ", + id DESC + LIMIT $limit + "; + warn "$me $sql (@param)" if $DEBUG; my $sth = $dbh->prepare($sql) or die $dbh->errstr. "preparing $sql"; $sth->execute(@param) or die $sth->errstr. "executing $sql"; @@ -67,6 +97,31 @@ sub customer_tickets { } +sub comments_on_tickets { + my ($self, $custnum, $limit, $time ) = @_; + $limit ||= 0; + + my( $from_sql, @param) = $self->_from_customer( $custnum ); + my $sql = qq{ + SELECT transactions.*, Attachments.content, Tickets.subject + FROM transactions + JOIN Attachments ON( Attachments.transactionid = transactions.id ) + JOIN Tickets ON ( Tickets.id = transactions.objectid ) + JOIN Links ON ( Tickets.id = Links.LocalBase + AND Links.Base LIKE '%/ticket/' || Tickets.id ) + + + WHERE ( Status = 'new' OR Status = 'open' OR Status = 'stalled' ) + AND Target = 'freeside://freeside/cust_main/$custnum' + AND transactions.type = 'Comment' + AND transactions.created >= (SELECT TIMESTAMP WITH TIME ZONE 'epoch' + $time * INTERVAL '1 second') + LIMIT $limit + }; + cluck $sql if $DEBUG > 0; + #AND created > + $dbh->selectall_arrayref( $sql, { Slice => {} } ) or die $dbh->errstr . " $sql"; +} + sub _from_customer { my( $self, $custnum, $priority ) = @_; @@ -75,8 +130,8 @@ sub _from_customer { my $where = ''; if ( defined($priority) ) { - my $queue_sql = " ObjectCustomFields.ObjectId = ( SELECT id FROM queues - WHERE queues.name = ? ) + my $queue_sql = " ObjectCustomFields.ObjectId = ( SELECT id FROM Queues + WHERE Queues.Name = ? ) OR ( ? = '' AND ObjectCustomFields.ObjectId = 0 )"; my $customfield_sql = @@ -85,7 +140,7 @@ sub _from_customer { JOIN ObjectCustomFields ON ( CustomFields.id = ObjectCustomFields.CustomField ) WHERE LookupType = 'RT::Queue-RT::Ticket' - AND name = ? + AND Name = ? AND ( $queue_sql ) )"; @@ -106,18 +161,18 @@ sub _from_customer { unshift @param, $priority; $join = "JOIN ObjectCustomFieldValues - ON ( tickets.id = ObjectCustomFieldValues.ObjectId )"; + ON ( Tickets.id = ObjectCustomFieldValues.ObjectId )"; - $where = " AND content = ? - AND ObjectCustomFieldValues.disabled != 1 + $where = " AND Content = ? + AND ObjectCustomFieldValues.Disabled != 1 AND ObjectType = 'RT::Ticket' AND $customfield_sql"; } else { $where = - "AND 0 = ( SELECT count(*) FROM ObjectCustomFieldValues - WHERE ObjectId = tickets.id + "AND 0 = ( SELECT COUNT(*) FROM ObjectCustomFieldValues + WHERE ObjectId = Tickets.id AND ObjectType = 'RT::Ticket' AND $customfield_sql ) @@ -127,13 +182,16 @@ sub _from_customer { } my $sql = " - FROM tickets - JOIN queues ON ( tickets.queue = queues.id ) - JOIN links ON ( tickets.id = links.localbase ) - $join - WHERE ( ". join(' OR ', map "status = '$_'", $self->statuses ). " ) - AND target = 'freeside://freeside/cust_main/$custnum' - $where + FROM Tickets + JOIN Queues ON ( Tickets.Queue = Queues.id ) + JOIN Users ON ( Tickets.Owner = Users.id ) + JOIN Links ON ( Tickets.id = Links.LocalBase + AND Links.Base LIKE '%/ticket/' || Tickets.id ) + $join + + WHERE ( ". join(' OR ', map "Status = '$_'", $self->statuses ). " ) + AND Target = 'freeside://freeside/cust_main/$custnum' + $where "; ( $sql, @param ); @@ -148,18 +206,28 @@ sub statuses { } sub href_customer_tickets { - my( $self, $custnum, $priority ) = @_; + my( $self, $custnum ) = ( shift, shift ); + my( $priority, @statuses); + if ( ref($_[0]) ) { + my $opt = shift; + $priority = $opt->{'priority'}; + @statuses = $opt->{'statuses'} ? @{$opt->{'statuses'}} : $self->statuses; + } else { + $priority = shift; + @statuses = $self->statuses; + } #my $href = $self->baseurl; #i snarfed this from an RT bookmarked search, then unescaped (some of) it with #perl -npe 's/%([0-9A-F]{2})/pack('C', hex($1))/eg;' - my $href .= + #$href .= + my $href = "Search/Results.html?Order=ASC&". "Query= MemberOf = 'freeside://freeside/cust_main/$custnum' ". #" AND ( Status = 'open' OR Status = 'new' OR Status = 'stalled' )" - " AND ( ". join(' OR ', map "Status = '$_'", $self->statuses ). " ) " + " AND ( ". join(' OR ', map "Status = '$_'", @statuses ). " ) " ; if ( defined($priority) && $field && $priority_field_queue ) { @@ -205,7 +273,7 @@ sub href_customer_tickets { } -sub href_new_ticket { +sub href_params_new_ticket { my( $self, $custnum_or_cust_main, $requestors ) = @_; my( $custnum, $cust_main ); @@ -216,14 +284,25 @@ sub href_new_ticket { $custnum = $custnum_or_cust_main; $cust_main = qsearchs('cust_main', { 'custnum' => $custnum } ); } - my $queueid = $cust_main->agent->ticketing_queueid || $default_queueid; - - $self->baseurl. - 'Ticket/Create.html?'. - "Queue=$queueid". - "&new-MemberOf=freeside://freeside/cust_main/$custnum". - ( $requestors ? '&Requestors='. uri_escape($requestors) : '' ) - ; + + my %param = ( + 'Queue' => ($cust_main->agent->ticketing_queueid || $default_queueid), + 'new-MemberOf'=> "freeside://freeside/cust_main/$custnum", + 'Requestors' => $requestors, + ); + + ( $self->baseurl.'Ticket/Create.html', %param ); +} + +sub href_new_ticket { + my $self = shift; + + my( $base, %param ) = $self->href_params_new_ticket(@_); + + my $uri = new URI $base; + $uri->query_form(%param); + $uri; + } sub href_ticket { @@ -234,7 +313,7 @@ sub href_ticket { sub queues { my($self) = @_; - my $sql = "SELECT id, name FROM queues WHERE disabled = 0"; + my $sql = "SELECT id, Name FROM Queues WHERE Disabled = 0"; my $sth = $dbh->prepare($sql) or die $dbh->errstr. " preparing $sql"; $sth->execute() or die $sth->errstr. " executing $sql"; @@ -247,17 +326,75 @@ sub queue { return '' unless $queueid; - my $sql = "SELECT name FROM queues WHERE id = ?"; + my $sql = "SELECT Name FROM Queues WHERE id = ?"; my $sth = $dbh->prepare($sql) or die $dbh->errstr. " preparing $sql"; $sth->execute($queueid) or die $sth->errstr. " executing $sql"; - $sth->fetchrow_arrayref->[0]; + my $rows = $sth->fetchrow_arrayref; + $rows ? $rows->[0] : ''; } sub baseurl { #my $self = shift; - $external_url; + $external_url. '/'; +} + +sub _retrieve_single_value { + my( $self, $sql ) = @_; + + warn "$me $sql" if $DEBUG; + my $sth = $dbh->prepare($sql) or die $dbh->errstr. "preparing $sql"; + $sth->execute or die $sth->errstr. "executing $sql"; + + my $arrayref = $sth->fetchrow_arrayref; + $arrayref ? $arrayref->[0] : $arrayref; +} + +sub transaction_creator { + my( $self, $transaction_id ) = @_; + + my $sql = "SELECT Name FROM Transactions JOIN Users ON ". + "Transactions.Creator=Users.id WHERE Transactions.id = ". + $transaction_id; + + $self->_retrieve_single_value($sql); +} + +sub transaction_ticketid { + my( $self, $transaction_id ) = @_; + + my $sql = "SELECT ObjectId FROM Transactions WHERE Transactions.id = ". + $transaction_id; + + $self->_retrieve_single_value($sql); +} + +sub transaction_subject { + my( $self, $transaction_id ) = @_; + + my $sql = "SELECT Subject FROM Transactions JOIN Tickets ON ObjectId=". + "Tickets.id WHERE Transactions.id = ". $transaction_id; + + $self->_retrieve_single_value($sql); +} + +sub transaction_status { + my( $self, $transaction_id ) = @_; + + my $sql = "SELECT Status FROM Transactions JOIN Tickets ON ObjectId=". + "Tickets.id WHERE Transactions.id = ". $transaction_id; + + $self->_retrieve_single_value($sql); +} + +sub access_right { + warn "WARNING: no access rights available w/ external RT"; + 0; +} + +sub create_ticket { + return 'create_ticket unimplemented w/external RT (write something w/RT::Client::REST?)'; } 1;