X-Git-Url: http://git.freeside.biz/gitweb/?a=blobdiff_plain;f=FS%2FFS%2FClientAPI%2FMyAccount.pm;h=cb6a938dacb84e03b8f990f1b2f5de2c17e84e33;hb=3872c1d3a2d975989e342be389b8260bfcc5ec41;hp=d724e2c60ef18160e255b53e5bf41478551a81a9;hpb=f464dfb4fed3f68c330938d455083424e7c838de;p=freeside.git diff --git a/FS/FS/ClientAPI/MyAccount.pm b/FS/FS/ClientAPI/MyAccount.pm index d724e2c60..cb6a938da 100644 --- a/FS/FS/ClientAPI/MyAccount.pm +++ b/FS/FS/ClientAPI/MyAccount.pm @@ -236,13 +236,6 @@ sub login { $svc_x = $svc_phone; - } elsif ( $p->{'domain'} eq 'ip_mac' ) { - - my $svc_broadband = qsearchs( 'svc_broadband', { 'mac_addr' => $p->{'username'} } ); - return { error => 'IP address not found' } - unless $svc_broadband; - $svc_x = $svc_broadband; - } elsif ( $p->{email} && (my $contact = FS::contact->by_selfservice_email($p->{email})) ) @@ -620,6 +613,7 @@ sub customer_info_short { $return{payinfo} = $cust_main->paymask; @return{'month', 'year'} = $cust_main->paydate_monthyear; } + else { delete $return{'payinfo'}; } my @invoicing_list = $cust_main->invoicing_list; $return{'invoicing_list'} = @@ -1023,9 +1017,6 @@ sub validate_payment { my $payinfo2 = $1; $payinfo = $payinfo1. '@'. $payinfo2; - $payinfo = $cust_main->payinfo - if $cust_main->paymask eq $payinfo; - my $achonfile = 0; if ( $cust_main->paymask eq $payinfo ) { $payinfo = $cust_main->payinfo; @@ -1662,128 +1653,6 @@ sub payment_receipt { }; } -sub list_payby { - my $p = shift; - - my($context, $session, $custnum) = _custoragent_session_custnum($p); - return { 'error' => $session } if $context eq 'error'; - - my $cust_main = qsearchs('cust_main', { 'custnum' => $custnum } ) - or return { 'error' => "unknown custnum $custnum" }; - - return { - 'payby' => [ map { - my $cust_payby = $_; - +{ - map { $_ => $cust_payby->$_ } - qw( custpaybynum weight payby paymask paydate - payname paystate paytype - ) - }; - } - $cust_main->cust_payby - ], - }; -} - -sub insert_payby { - my $p = shift; - - my($context, $session, $custnum) = _custoragent_session_custnum($p); - return { 'error' => $session } if $context eq 'error'; - - #XXX payinfo1 + payinfo2 for CHEK? - #or take the opportunity to use separate, more well- named fields? - # my $payinfo; - # $p->{'payinfo1'} =~ /^([\dx]+)$/ - # or return { 'error' => "illegal account number ". $p->{'payinfo1'} }; - # my $payinfo1 = $1; - # $p->{'payinfo2'} =~ /^([\dx\.]+)$/ # . turned on by echeck-country CA ? - # or return { 'error' => "illegal ABA/routing number ". $p->{'payinfo2'} }; - # my $payinfo2 = $1; - # $payinfo = $payinfo1. '@'. $payinfo2; - - my $cust_payby = new FS::cust_payby { - 'custnum' => $custnum, - map { $_ => $p->{$_} } qw( weight payby payinfo paycvv paydate payname - paystate paytype payip - ), - }; - - my $error = $cust_payby->insert; - if ( $error ) { - return { 'error' => $error }; - } else { - return { 'custpaybynum' => $cust_payby->custpaybynum }; - } - -} - -sub update_payby { - my $p = shift; - - my($context, $session, $custnum) = _custoragent_session_custnum($p); - return { 'error' => $session } if $context eq 'error'; - - my $cust_payby = qsearchs('cust_payby', { - 'custnum' => $custnum, - 'custpaybynum' => $p->{'custpaybynum'}, - }) - or return { 'error' => 'unknown custpaybynum '. $p->{'custpaybynum'} }; - - foreach my $field ( - qw( weight payby payinfo paycvv paydate payname paystate paytype payip ) - ) { - next unless exists($p->{$field}); - $cust_payby->set($field,$p->{$field}); - } - - my $error = $cust_payby->replace; - if ( $error ) { - return { 'error' => $error }; - } else { - return { 'custpaybynum' => $cust_payby->custpaybynum }; - } - -} - -sub verify_payby { - my $p = shift; - - my($context, $session, $custnum) = _custoragent_session_custnum($p); - return { 'error' => $session } if $context eq 'error'; - - my $cust_payby = qsearchs('cust_payby', { - 'custnum' => $custnum, - 'custpaybynum' => $p->{'custpaybynum'}, - }) - or return { 'error' => 'unknown custpaybynum '. $p->{'custpaybynum'} }; - - return { 'error' => $cust_payby->verify }; - -} - -sub delete_payby { - my $p = shift; - - my($context, $session, $custnum) = _custoragent_session_custnum($p); - return { 'error' => $session } if $context eq 'error'; - - my $cust_payby = qsearchs('cust_payby', { - 'custnum' => $custnum, - 'custpaybynum' => $p->{'custpaybynum'}, - }) - or return { 'error' => 'unknown custpaybynum '. $p->{'custpaybynum'} }; - - my $conf = new FS::Conf; - if (($cust_payby->payby eq "DCHK" || $cust_payby->payby eq "CHEK") && $conf->exists('selfservice-ACH_info_readonly')) { - return { 'error' => "Sorry you do not have permission to delete bank information." }; - } - else { - return { 'error' => $cust_payby->delete }; - } -} - sub cancel { my $p = shift; my $session = _cache->get($p->{'session_id'})