X-Git-Url: http://git.freeside.biz/gitweb/?a=blobdiff_plain;ds=sidebyside;f=FS%2FFS%2Frate.pm;h=f30e4c772c5b2d5d1f69954686a0932d2cc177c5;hb=74e058c8a010ef6feb539248a550d0bb169c1e94;hp=347bb2743bcf229e49145553c7bcead0de5023da;hpb=d206257b5dbb4c3b79a2bb61a3801f41d54e5d59;p=freeside.git diff --git a/FS/FS/rate.pm b/FS/FS/rate.pm index 347bb2743..f30e4c772 100644 --- a/FS/FS/rate.pm +++ b/FS/FS/rate.pm @@ -279,16 +279,22 @@ Destination can be specified as an FS::rate_detail object or regionnum (see L), or as a hashref with two keys: I and I. +An optional third key, I, will return a timed rate (one with +a non-null I) if one exists for a call at that time. If +no matching timed rate exists, the non-timed rate will be returned. + =cut sub dest_detail { my $self = shift; my $regionnum; + my $weektime; if ( ref($_[0]) eq 'HASH' ) { my $countrycode = $_[0]->{'countrycode'}; my $phonenum = $_[0]->{'phonenum'}; + $weektime = $_[0]->{'weektime'}; #find a rate prefix, first look at most specific, then fewer digits, # finally trying the country code only @@ -314,9 +320,31 @@ sub dest_detail { } else { $regionnum = ref($_[0]) ? shift->regionnum : shift; } - - qsearchs( 'rate_detail', { 'ratenum' => $self->ratenum, - 'dest_regionnum' => $regionnum, } ); + + if(!defined($weektime)) { + return qsearchs( 'rate_detail', + { 'ratenum' => $self->ratenum, + 'dest_regionnum' => $regionnum, + 'ratetimenum' => '', + } ); + } + else { + my @details = grep { my $rate_time = $_->rate_time; + $rate_time && $rate_time->contains($weektime) } + qsearch( 'rate_detail', + { 'ratenum' => $self->ratenum, + 'dest_regionnum' => $regionnum, } ); + if(!@details) { + # this may change at some point + return $self->dest_detail($regionnum); + } + elsif(@details == 1) { + return $details[0]; + } + else { + die "overlapping rate_detail times (region $regionnum, time $weektime)\n"; + } + } } =item rate_detail @@ -364,6 +392,7 @@ sub process { 'dest_regionnum' => $regionnum, map { $_ => $param->{"$_$regionnum"} } qw( min_included min_charge sec_granularity ) + #qw( min_included conn_charge conn_sec min_charge sec_granularity ) }; } else { @@ -371,6 +400,9 @@ sub process { new FS::rate_detail { 'dest_regionnum' => $regionnum, 'min_included' => 0, + 'conn_charge' => 0, + 'conn_sec' => 0, + 'conn_charge' => 0, 'min_charge' => 0, 'sec_granularity' => '60' }; @@ -387,10 +419,13 @@ sub process { my $error = ''; if ( $param->{'ratenum'} ) { warn "$rate replacing $old (". $param->{'ratenum'}. ")\n" if $DEBUG; - $error = $rate->replace( $old, - 'rate_detail' => \@rate_detail, - 'job' => $job, - ); + + my @param = ( 'job'=>$job ); + push @param, 'rate_detail'=>\@rate_detail + unless $param->{'preserve_rate_detail'}; + + $error = $rate->replace( $old, @param ); + } else { warn "inserting $rate\n" if $DEBUG; $error = $rate->insert( 'rate_detail' => \@rate_detail,