# BEGIN BPS TAGGED BLOCK {{{
-#
+#
# COPYRIGHT:
-#
-# This software is Copyright (c) 1996-2009 Best Practical Solutions, LLC
-# <jesse@bestpractical.com>
-#
+#
+# This software is Copyright (c) 1996-2017 Best Practical Solutions, LLC
+# <sales@bestpractical.com>
+#
# (Except where explicitly superseded by other copyright notices)
-#
-#
+#
+#
# LICENSE:
-#
+#
# This work is made available to you under the terms of Version 2 of
# the GNU General Public License. A copy of that license should have
# been provided with this software, but in any event can be snarfed
# from www.gnu.org.
-#
+#
# This work is distributed in the hope that it will be useful, but
# WITHOUT ANY WARRANTY; without even the implied warranty of
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
# General Public License for more details.
-#
+#
# You should have received a copy of the GNU General Public License
# along with this program; if not, write to the Free Software
# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA
# 02110-1301 or visit their web page on the internet at
# http://www.gnu.org/licenses/old-licenses/gpl-2.0.html.
-#
-#
+#
+#
# CONTRIBUTION SUBMISSION POLICY:
-#
+#
# (The following paragraph is not intended to limit the rights granted
# to you to modify and distribute this software under the terms of
# the GNU General Public License and is only of importance to you if
# you choose to contribute your changes and enhancements to the
# community by submitting them to Best Practical Solutions, LLC.)
-#
+#
# By intentionally submitting any modifications, corrections or
# derivatives to this work, or any other work intended for use with
# Request Tracker, to Best Practical Solutions, LLC, you confirm that
# royalty-free, perpetual, license to use, copy, create derivative
# works based on those contributions, and sublicense and distribute
# those contributions and any derivatives thereof.
-#
+#
# END BPS TAGGED BLOCK }}}
package RT::Shredder::Plugin;
my %plugins = RT::Shredder::Plugin->List;
# load plugin by name
- my $plugin = new RT::Shredder::Plugin;
+ my $plugin = RT::Shredder::Plugin->new;
my( $status, $msg ) = $plugin->LoadByName( 'Tickets' );
unless( $status ) {
print STDERR "Couldn't load plugin 'Tickets': $msg\n";
}
# load plugin by preformatted string
- my $plugin = new RT::Shredder::Plugin;
+ my $plugin = RT::Shredder::Plugin->new;
my( $status, $msg ) = $plugin->LoadByString( 'Tickets=status,deleted' );
unless( $status ) {
print STDERR "Couldn't load plugin: $msg\n";
my $self = shift;
my %args = ( @_ );
$self->{'opt'} = \%args;
+ return;
}
=head2 List
push @files, glob $mask;
}
- my %res = map { $_ =~ m/([^\\\/]+)\.pm$/; $1 => $_ } reverse @files;
+ my %res;
+ for my $f (reverse @files) {
+ $res{$1} = $f if $f =~ /([^\\\/]+)\.pm$/;
+ }
return %res unless $type;
delete $res{'Base'};
foreach my $name( keys %res ) {
my $class = join '::', qw(RT Shredder Plugin), $name;
- unless( eval "require $class" ) {
+ unless( $class->require ) {
delete $res{ $name };
next;
}
Returns C<$status> and C<$message>. On errors status
is C<false> value.
+In scalar context, returns $status only.
+
=cut
sub LoadByName
{
my $self = shift;
my $name = shift or return (0, "Name not specified");
+ $name =~ /^\w+(::\w+)*$/ or return (0, "Invalid plugin name");
- local $@;
my $plugin = "RT::Shredder::Plugin::$name";
- eval "require $plugin" or return( 0, $@ );
- return( 0, "Plugin '$plugin' has no method new") unless $plugin->can('new');
+ $plugin->require or return( 0, "Failed to load $plugin" );
+ return wantarray ? ( 0, "Plugin '$plugin' has no method new") : 0 unless $plugin->can('new');
my $obj = eval { $plugin->new( @_ ) };
- return( 0, $@ ) if $@;
- return( 0, 'constructor returned empty object' ) unless $obj;
+ return wantarray ? ( 0, $@ ) : 0 if $@;
+ return wantarray ? ( 0, 'constructor returned empty object' ) : 0 unless $obj;
$self->Rebless( $obj );
- return( 1, "successfuly load plugin" );
+ return wantarray ? ( 1, "successfuly load plugin" ) : 1;
}
=head2 LoadByString