%{ $columns{$tablename}->{$colname} }
};
$col->table_obj($table);
- push @sql, $col->sql_add_column($dbh);
+ my ($alter, $postalter) = $col->sql_add_column($dbh);
+ foreach (@$alter) {
+ push @sql, "ALTER TABLE $tablename $_;";
+ }
+ push @sql, @$postalter;
}
} #foreach $colname
} #foreach $tablename
while (my $item = $search->Next) {
my ($c, $a, $t) = map {lc $item->$_->Name}
('ScripConditionObj', 'ScripActionObj', 'TemplateObj');
- if ( exists $scrip{$c}{$a}{$t} and $item->Creator == 1 ) {
+ if ( exists $scrip{$c}{$a} and $item->Creator == 1 ) {
warn "Deleting duplicate scrip $c $a [$t]\n";
my ($val, $msg) = $item->Delete;
warn "error deleting scrip: $msg\n" if !$val;
warn "error deleting scrip: $msg\n" if !$val;
}
else {
- $scrip{$c}{$a}{$t} = $item->id;
+ $scrip{$c}{$a} = $item->id;
}
}
my $Scrip = RT::Scrip->new($CurrentUser);
my $desc = $s->{'Description'};
my ($c, $a, $t) = map lc,
@{ $s }{'ScripCondition', 'ScripAction', 'Template'};
- # skip existing scrips
- next if ( exists($scrip{$c}{$a}{$t}) );
- if ( !exists($condition{$c}) ) {
- warn "ScripCondition '$c' not found.\n";
- next;
- }
- if ( !exists($action{$a}) ) {
- warn "ScripAction '$a' not found.\n";
- next;
- }
- if ( !exists($template{$t}) ) {
- warn "Template '$t' not found.\n";
- next;
+
+ if ( exists($scrip{$c}{$a}) ) {
+ $Scrip->Load( $scrip{$c}{$a} );
+ } else { # need to create it
+
+ if ( !exists($condition{$c}) ) {
+ warn "ScripCondition '$c' not found.\n";
+ next;
+ }
+ if ( !exists($action{$a}) ) {
+ warn "ScripAction '$a' not found.\n";
+ next;
+ }
+ if ( !exists($template{$t}) ) {
+ warn "Template '$t' not found.\n";
+ next;
+ }
+ my %new_param = (
+ ScripCondition => $condition{$c}->[0],
+ ScripAction => $action{$a}->[0],
+ Template => $template{$t}->[0],
+ Queue => 0,
+ Description => $desc,
+ );
+ warn "Creating scrip: $c $a [$t]\n";
+ my ($val, $msg) = $Scrip->Create(%new_param);
+ die $msg if !$val;
+
+ } #if $scrip{...}
+ # set the Immutable attribute on them if needed
+ if ( !$Scrip->FirstAttribute('Immutable') ) {
+ my ($val, $msg) =
+ $Scrip->SetAttribute(Name => 'Immutable', Content => '1');
+ die $msg if !$val;
}
- my %new_param = (
- ScripCondition => $condition{$c}->[0],
- ScripAction => $action{$a}->[0],
- Template => $template{$t}->[0],
- Queue => 0,
- Description => $desc,
- );
- warn "Creating scrip: $c $a [$t]\n";
- my ($val, $msg) = $Scrip->Create(%new_param);
- die $msg if !$val;
+
} #foreach (@Scrips)
# one-time fix: accumulator fields (support time, etc.) that had values
}
}
+ my $cve_2013_3373_sql = '';
+ if ( driver_name =~ /^Pg/i ) {
+ $cve_2013_3373_sql = q(
+ UPDATE Tickets SET Subject = REPLACE(Subject,E'\n','')
+ );
+ } elsif ( driver_name =~ /^mysql/i ) {
+ $cve_2013_3373_sql = q(
+ UPDATE Tickets SET Subject = REPLACE(Subject,'\n','');
+ );
+ } else {
+ warn "WARNING: Don't know how to update RT Ticket Subjects for your database driver for CVE-2013-3373";
+ }
+ if ( $cve_2013_3373_sql ) {
+ my $cve_2013_3373_sth = $dbh->prepare($cve_2013_3373_sql)
+ or die $dbh->errstr;
+ $cve_2013_3373_sth->execute
+ or die $cve_2013_3373_sth->errstr;
+ }
+
+ # Remove dangling customer links, if any
+ my %target_pkey = ('cust_main' => 'custnum', 'cust_svc' => 'svcnum');
+ for my $table (keys %target_pkey) {
+ my $pkey = $target_pkey{$table};
+ my $rows = $dbh->do(
+ "DELETE FROM Links WHERE id IN(
+ SELECT id FROM (
+ SELECT Links.id FROM Links LEFT JOIN $table ON (Links.Target =
+ 'freeside://freeside/$table/' || $table.$pkey)
+ WHERE Links.Target like 'freeside://freeside/$table/%'
+ AND $table.$pkey IS NULL
+ ) AS x
+ )"
+ ) or die $dbh->errstr;
+ warn "Removed $rows dangling ticket-$table links\n" if $rows > 0;
+ }
+
+ # Fix ticket transactions on the Time* fields where the NewValue (or
+ # OldValue, though this is not known to happen) is an empty string
+ foreach (qw(newvalue oldvalue)) {
+ my $rows = $dbh->do(
+ "UPDATE Transactions SET $_ = '0' WHERE ObjectType='RT::Ticket' AND ".
+ "Field IN ('TimeWorked', 'TimeEstimated', 'TimeLeft') AND $_ = ''"
+ ) or die $dbh->errstr;
+ warn "Fixed $rows transactions with empty time values\n" if $rows > 0;
+ }
+
return;
}