projects
/
Business-OnlinePayment-InternetSecure.git
/ blobdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
|
commitdiff
|
tree
raw
|
inline
| side by side
Remove prod_string() taxes argument
[Business-OnlinePayment-InternetSecure.git]
/
InternetSecure.pm
diff --git
a/InternetSecure.pm
b/InternetSecure.pm
index
5ffc99c
..
65a9112
100755
(executable)
--- a/
InternetSecure.pm
+++ b/
InternetSecure.pm
@@
-18,8
+18,9
@@
our $VERSION = '0.01';
use constant CARD_TYPES => {
VI => 'Visa',
MC => 'MasterCard',
use constant CARD_TYPES => {
VI => 'Visa',
MC => 'MasterCard',
- AX => 'American Express',
+ AX => 'American Express',
# FIXME: AM?
NN => 'Discover',
NN => 'Discover',
+ # JB?
};
};
@@
-37,12
+38,24
@@
sub set_defaults {
$self->build_subs(qw(
receipt_number sales_order_number
$self->build_subs(qw(
receipt_number sales_order_number
- card
holder card
_type
+ card_type
total_amount
avs_response cvv2_response
));
}
total_amount
avs_response cvv2_response
));
}
+# OnlinePayment's get_fields now filters out undefs in 3.x. :(
+#
+sub get_fields {
+ my ($self, @fields) = @_;
+
+ my %content = $self->content;
+
+ my %new = map +($_ => $content{$_}), @fields;
+
+ return %new;
+}
+
# OnlinePayment's remap_fields is buggy, so we simply rewrite it
#
sub remap_fields {
# OnlinePayment's remap_fields is buggy, so we simply rewrite it
#
sub remap_fields {
@@
-63,10
+76,6
@@
sub get_remap_fields {
$self->remap_fields(reverse %map);
my %data = $self->get_fields(keys %map);
$self->remap_fields(reverse %map);
my %data = $self->get_fields(keys %map);
- foreach (values %data) {
- $_ = '' unless defined;
- }
-
return %data;
}
return %data;
}
@@
-99,14
+108,13
@@
sub parse_expdate {
# Convert a single product into a product string
#
sub prod_string {
# Convert a single product into a product string
#
sub prod_string {
- my ($self, $currency,
$taxes,
%data) = @_;
+ my ($self, $currency, %data) = @_;
croak "Missing amount in product" unless defined $data{amount};
my @flags = ($currency);
croak "Missing amount in product" unless defined $data{amount};
my @flags = ($currency);
- $taxes = uc $data{taxes} if defined $data{taxes};
- foreach (split ' ' => $taxes) {
+ foreach (split ' ' => uc($data{taxes} || '')) {
croak "Unknown tax code $_" unless /^(GST|PST|HST)$/;
push @flags, $_;
}
croak "Unknown tax code $_" unless /^(GST|PST|HST)$/;
push @flags, $_;
}
@@
-149,7
+157,7
@@
sub to_xml {
$content{taxes} = uc $content{taxes};
my %data = $self->get_remap_fields(qw(
$content{taxes} = uc $content{taxes};
my %data = $self->get_remap_fields(qw(
- xxxCard
Number
card_number
+ xxxCard
_Number
card_number
xxxName name
xxxCompany company
xxxName name
xxxCompany company
@@
-174,7
+182,8
@@
sub to_xml {
$data{MerchantNumber} = $self->merchant_id;
$data{MerchantNumber} = $self->merchant_id;
- $data{xxxCardNumber} =~ tr/ //d;
+ $data{xxxCard_Number} =~ tr/ //d;
+ $data{xxxCard_Number} =~ s/^[0-36-9]/4/ if $self->test_transaction;
my ($y, $m) = $self->parse_expdate($content{exp_date});
$data{xxxCCYear} = sprintf '%.4u' => $y;
my ($y, $m) = $self->parse_expdate($content{exp_date});
$data{xxxCCYear} = sprintf '%.4u' => $y;
@@
-190,16
+199,16
@@
sub to_xml {
if (ref $content{description}) {
$data{Products} = join '|' => map $self->prod_string(
if (ref $content{description}) {
$data{Products} = join '|' => map $self->prod_string(
-
$content{currency},
-
$content{taxes},
-
%$_),
-
@{ $content{description} };
+ $content{currency},
+
taxes =>
$content{taxes},
+ %$_),
+ @{ $content{description} };
} else {
$self->required_fields(qw(amount));
$data{Products} = $self->prod_string(
$content{currency},
} else {
$self->required_fields(qw(amount));
$data{Products} = $self->prod_string(
$content{currency},
- $content{taxes},
- amount => $content{amount},
+
taxes =>
$content{taxes},
+ amount
=> $content{amount},
description => $content{description},
);
}
description => $content{description},
);
}
@@
-207,6
+216,7
@@
sub to_xml {
xml_out(\%data,
NoAttr => 1,
RootName => 'TranxRequest',
xml_out(\%data,
NoAttr => 1,
RootName => 'TranxRequest',
+ SuppressEmpty => undef,
XMLDecl => '<?xml version="1.0" encoding="utf-8" standalone="yes"?>',
);
}
XMLDecl => '<?xml version="1.0" encoding="utf-8" standalone="yes"?>',
);
}
@@
-243,7
+253,6
@@
sub parse_response {
$self->infuse($response, qw(
ReceiptNumber receipt_number
SalesOrderNumber sales_order_number
$self->infuse($response, qw(
ReceiptNumber receipt_number
SalesOrderNumber sales_order_number
- xxxName cardholder
CardType card_type
Page result_code
ApprovalCode authorization
CardType card_type
Page result_code
ApprovalCode authorization
@@
-253,6
+262,9
@@
sub parse_response {
CVV2ResponseCode cvv2_response
));
CVV2ResponseCode cvv2_response
));
+ # Completely undocumented field that sometimes override <Verbiage>
+ $self->error_message($response->{Error}) if $response->{Error};
+
$self->card_type(CARD_TYPES->{$self->card_type});
$self->{products_raw} = $response->{Products};
$self->card_type(CARD_TYPES->{$self->card_type});
$self->{products_raw} = $response->{Products};
@@
-339,7
+351,7
@@
Business::OnlinePayment::InternetSecure - InternetSecure backend for Business::O
Business::OnlinePayment::InternetSecure is an implementation of
L<Business::OnlinePayment> that allows for processing online credit card
Business::OnlinePayment::InternetSecure is an implementation of
L<Business::OnlinePayment> that allows for processing online credit card
-payments through Internet
Secure.
+payments through InternetSecure.
See L<Business::OnlinePayment> for more information about the generic
Business::OnlinePayment interface.
See L<Business::OnlinePayment> for more information about the generic
Business::OnlinePayment interface.
@@
-348,7
+360,7
@@
Business::OnlinePayment interface.
Object creation is done via L<Business::OnlinePayment>; see its manpage for
details. The I<merchant_id> processor option is required, and corresponds
Object creation is done via L<Business::OnlinePayment>; see its manpage for
details. The I<merchant_id> processor option is required, and corresponds
-to the merchant ID assigned to you by Internet
Secure.
+to the merchant ID assigned to you by InternetSecure.
=head1 METHODS
=head1 METHODS
@@
-430,16
+442,15
@@
C<CAD> (default) or C<USD>.
=item taxes
Taxes to be added automatically. These should not be included in B<amount>;
=item taxes
Taxes to be added automatically. These should not be included in B<amount>;
-they will be automatically added by Internet
Secure later on.
+they will be automatically added by InternetSecure later on.
Available taxes are C<GST>, C<PST> and C<HST>. Taxes can be combined by
separating them with spaces, such as C<GST HST>.
=item name / company / address / city / state / zip / country / phone / email
Available taxes are C<GST>, C<PST> and C<HST>. Taxes can be combined by
separating them with spaces, such as C<GST HST>.
=item name / company / address / city / state / zip / country / phone / email
-Facultative customer information. B<state> should be either a postal
-abbreviation or a two-letter code taken from ISO 3166-2, and B<country> should
-be a two-letter code taken from ISO 3166-1.
+Customer information. B<Country> should be a two-letter code taken from ISO
+3166-1.
=back
=back
@@
-457,11
+468,6
@@
Receipt number and sales order number of submitted order.
Total amount billed for this order, including taxes.
Total amount billed for this order, including taxes.
-=item cardholder()
-
-Cardholder's name. This is currently a mere copy of the B<name> field passed
-to B<submit()>.
-
=item card_type()
Type of the credit card used for the submitted order, being one of the
=item card_type()
Type of the credit card used for the submitted order, being one of the
@@
-481,9
+487,14
@@
following:
=item avs_response() / cvv2_response()
=item avs_response() / cvv2_response()
-Results of the AVS and CVV2 checks. See the Internet
Secure documentation for
+Results of the AVS and CVV2 checks. See the InternetSecure documentation for
the list of possible values.
the list of possible values.
+=item products_raw()
+
+...
+
+
=back
=back
@@
-504,7
+515,7
@@
Unit price of this product.
=item quantity
=item quantity
-Ordered quantity of this product.
This can be a decimal value.
+Ordered quantity of this product.
=item sku
=item sku
@@
-527,9
+538,9
@@
be left undefined.
=head2 Character encoding
=head2 Character encoding
-Since communication to/from Internet
Secure is encoded with UTF-8, all Unicode
+Since communication to/from InternetSecure is encoded with UTF-8, all Unicode
characters are theoretically available when submitting information via
characters are theoretically available when submitting information via
-B<submit()>. (Further restrictions may be imposed by Internet
Secure itself.)
+B<submit()>. (Further restrictions may be imposed by InternetSecure itself.)
When using non-ASCII characters, all data provided to B<submit()> should either
be in the current native encoding (typically latin-1, unless it was modified
When using non-ASCII characters, all data provided to B<submit()> should either
be in the current native encoding (typically latin-1, unless it was modified
@@
-538,11
+549,6
@@
Conversely, all data returned after calling B<submit()> will be automatically
decoded.
decoded.
-=head2 products_raw
-
-...
-
-
=head1 EXPORT
None by default.
=head1 EXPORT
None by default.
@@
-554,11
+560,11
@@
L<Business::OnlinePayment>
=head1 AUTHOR
=head1 AUTHOR
-Fr
ederic Brie
re, E<lt>fbriere@fbriere.netE<gt>
+Fr
édéric Briè
re, E<lt>fbriere@fbriere.netE<gt>
=head1 COPYRIGHT AND LICENSE
=head1 COPYRIGHT AND LICENSE
-Copyright (C) 2006 by Fr
ederic Brie
re
+Copyright (C) 2006 by Fr
édéric Briè
re
This library is free software; you can redistribute it and/or modify
it under the same terms as Perl itself, either Perl version 5.8.4 or,
This library is free software; you can redistribute it and/or modify
it under the same terms as Perl itself, either Perl version 5.8.4 or,