From 2c09925cad2ade037e6ae953e4ed6fc056811f2f Mon Sep 17 00:00:00 2001 From: Ivan Kohler Date: Fri, 12 Jun 2015 15:19:00 -0700 Subject: rt 4.0.23 --- rt/lib/RT/ObjectCustomFields.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'rt/lib/RT/ObjectCustomFields.pm') diff --git a/rt/lib/RT/ObjectCustomFields.pm b/rt/lib/RT/ObjectCustomFields.pm index 97e4f91fb..1a488aac9 100644 --- a/rt/lib/RT/ObjectCustomFields.pm +++ b/rt/lib/RT/ObjectCustomFields.pm @@ -2,7 +2,7 @@ # # COPYRIGHT: # -# This software is Copyright (c) 1996-2014 Best Practical Solutions, LLC +# This software is Copyright (c) 1996-2015 Best Practical Solutions, LLC # # # (Except where explicitly superseded by other copyright notices) -- cgit v1.2.1 From e131b1f71f08b69abb832c1687d1f29682d171f8 Mon Sep 17 00:00:00 2001 From: Ivan Kohler Date: Thu, 9 Jul 2015 22:18:55 -0700 Subject: RT 4.2.11, ticket#13852 --- rt/lib/RT/ObjectCustomFields.pm | 53 +++++------------------------------------ 1 file changed, 6 insertions(+), 47 deletions(-) (limited to 'rt/lib/RT/ObjectCustomFields.pm') diff --git a/rt/lib/RT/ObjectCustomFields.pm b/rt/lib/RT/ObjectCustomFields.pm index 1a488aac9..8c31047f3 100644 --- a/rt/lib/RT/ObjectCustomFields.pm +++ b/rt/lib/RT/ObjectCustomFields.pm @@ -46,47 +46,23 @@ # # END BPS TAGGED BLOCK }}} -package RT::ObjectCustomFields; - use strict; use warnings; +package RT::ObjectCustomFields; +use base 'RT::SearchBuilder::AddAndSort'; +use RT::CustomField; use RT::ObjectCustomField; -use base 'RT::SearchBuilder'; - sub Table { 'ObjectCustomFields'} -sub _Init { - my $self = shift; - - # By default, order by SortOrder - $self->OrderByCols( - { ALIAS => 'main', - FIELD => 'SortOrder', - ORDER => 'ASC' }, - { ALIAS => 'main', - FIELD => 'id', - ORDER => 'ASC' }, - ); - - return ( $self->SUPER::_Init(@_) ); -} - - sub LimitToCustomField { my $self = shift; my $id = shift; $self->Limit( FIELD => 'CustomField', VALUE => $id ); } -sub LimitToObjectId { - my $self = shift; - my $id = shift || 0; - $self->Limit( FIELD => 'ObjectId', VALUE => $id ); -} - sub LimitToLookupType { my $self = shift; my $lookup = shift; @@ -112,22 +88,16 @@ sub HasEntryForCustomField { my @items = grep {$_->CustomField == $id } @{$self->ItemsArrayRef}; if ($#items > 1) { - die "$self HasEntry had a list with more than one of $id in it. this can never happen"; + die "$self HasEntry had a list with more than one of $id in it. this can never happen"; } if ($#items == -1 ) { - return undef; + return undef; } else { - return ($items[0]); + return ($items[0]); } } -sub CustomFields { - my $self = shift; - my %seen; - map { $_->CustomFieldObj } @{$self->ItemsArrayRef}; -} - sub _DoSearch { my $self = shift; if ($self->{'_cfs_alias'}) { @@ -139,17 +109,6 @@ sub _DoSearch { $self->SUPER::_DoSearch() } - -=head2 NewItem - -Returns an empty new RT::ObjectCustomField item - -=cut - -sub NewItem { - my $self = shift; - return(RT::ObjectCustomField->new($self->CurrentUser)); -} RT::Base->_ImportOverlays(); 1; -- cgit v1.2.1