From 0d9ffbafedc170c79ef5587af8c836579eb1c6fc Mon Sep 17 00:00:00 2001 From: Mark Wells Date: Fri, 28 Oct 2016 12:45:13 -0700 Subject: don't query broadband exports about non-broadband services, and other fixes, #73049 --- httemplate/search/sqlradius_usage.html | 37 ++++++++++++++++++++++++---------- 1 file changed, 26 insertions(+), 11 deletions(-) (limited to 'httemplate') diff --git a/httemplate/search/sqlradius_usage.html b/httemplate/search/sqlradius_usage.html index 846b50c2c..b810a8bf6 100644 --- a/httemplate/search/sqlradius_usage.html +++ b/httemplate/search/sqlradius_usage.html @@ -5,8 +5,8 @@ % $cgi->param('agentnum', $agent->agentnum); #for download links
<% $agent->agent %>

- <& cust_pkg_sqlradius_usage.html, - exports => @exports, + <& sqlradius_usage.html, + exports => \@exports, agentnum => $agent->agentnum, nohtmlheader => 1, download_label => 'Download this section', @@ -154,6 +154,17 @@ my %usage_param = ( my @total_usage = ('', 0, 0, 0); # username, input, output, input + output +# remember which exports apply to which services, so we don't inappropriately +# ask the wrong ones for usage stats +my %export_svcparts; +foreach my $export (@exports) { + my %seen; + foreach ($export->export_svc) { + $seen{ $_->svcpart } = 1; + } + $export_svcparts{ $export->exportnum } = \%seen; +} + # a single sub to collect data for each package, aggregated across both # services and exports. when we add per-service breakdown, this should also # keep the per-service data, but not needed yet @@ -163,16 +174,20 @@ my $cust_pkg_stats_sub = sub { my ($upbytes, $downbytes, $totalbytes) = (0, 0, 0); my $display_username; foreach my $svcnum ( split(',', $cust_pkg->get('svcnums_concat')) ) { + my $cust_svc = FS::cust_svc->by_key($svcnum); + my $svc = $cust_svc->svc_x; foreach my $export (@exports) { - my $svc = FS::cust_svc->by_key($svcnum)->svc_x; - my $username = $export->export_username($svc); - my $usage = $export->usage_sessions({ %usage_param, 'svc' => $svc }); - # returns arrayref with one row - $upbytes += $usage->[0]->{'acctinputoctets'}; - $downbytes += $usage->[0]->{'acctoutputoctets'}; - # in combined services mode with multiple users/MAC addresses per - # package, this will just show one of them arbitrarily. - $display_username ||= $username; + if ( $export_svcparts{ $export->exportnum }{ $cust_svc->svcpart } ) { + my $username = $export->export_username($svc); + my $usage = $export->usage_sessions({ %usage_param, 'svc' => $svc }); + # returns arrayref with one row + $upbytes += $usage->[0]->{'acctinputoctets'}; + $downbytes += $usage->[0]->{'acctoutputoctets'}; + # in combined services mode with multiple users/MAC addresses per + # package, this will just show one of them arbitrarily. + $display_username ||= $username; + } + # else this export doesn't apply so skip it } } $total_usage[1] += $upbytes; -- cgit v1.2.1 From b72e70605eb51f2336230bbef8bf7f6fd2fe6456 Mon Sep 17 00:00:00 2001 From: Jonathan Prykop Date: Sat, 29 Oct 2016 12:02:31 -0500 Subject: 71513: Card tokenization [checkpoint, not ready for backport] --- httemplate/misc/process/payment.cgi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'httemplate') diff --git a/httemplate/misc/process/payment.cgi b/httemplate/misc/process/payment.cgi index 74ca7348f..84687f019 100644 --- a/httemplate/misc/process/payment.cgi +++ b/httemplate/misc/process/payment.cgi @@ -135,7 +135,7 @@ if ( (my $custpaybynum = scalar($cgi->param('custpaybynum'))) > 0 ) { validate($payinfo) or errorpage(gettext('invalid_card')); - unless ( $payinfo =~ /^99\d{14}$/ ) { #token + unless ( $cust_main->tokenized($payinfo) ) { #token my $cardtype = cardtype($payinfo); -- cgit v1.2.1 From e14af5f80181a47c2cdd0981a62bcf183688535b Mon Sep 17 00:00:00 2001 From: Mark Wells Date: Tue, 1 Nov 2016 01:43:59 -0700 Subject: fix escaping --- httemplate/browse/cust_main_county.cgi | 20 ++++++++++---------- 1 file changed, 10 insertions(+), 10 deletions(-) (limited to 'httemplate') diff --git a/httemplate/browse/cust_main_county.cgi b/httemplate/browse/cust_main_county.cgi index 522614886..26a3e21b9 100755 --- a/httemplate/browse/cust_main_county.cgi +++ b/httemplate/browse/cust_main_county.cgi @@ -467,13 +467,13 @@ my @fields = ( ? ' '. add_link( desc => 'Add more counties', col => 'state', - label=> 'add more counties', + label=> 'add more counties', row => $_[0], cgi => $cgi, ). ' '. collapse_link( col => 'state', - label=> 'remove all counties', + label=> 'remove all counties', row => $_[0], cgi => $cgi, ) @@ -484,7 +484,7 @@ my @fields = ( ? '' : ' '. expand_link( desc => 'Add States', row => $_[0], - label => 'add states', + label => 'add states', cgi => $cgi, ) ); @@ -503,18 +503,18 @@ my @fields = ( ? ' '. add_link( desc => 'Add more cities', col => 'county', - label=> 'add more cities', + label=> 'add more cities', row => $_[0], cgi => $cgi, ). ' '. collapse_link( col => 'county', - label=> 'remove all cities', + label=> 'remove all cities', row => $_[0], cgi => $cgi, ) : ' '. remove_link( col => 'county', - label=> 'remove county', + label=> 'remove county', row => $_[0], cgi => $cgi, ); @@ -525,7 +525,7 @@ my @fields = ( : '(all) '. expand_link( desc => 'Add Counties', row => $_[0], - label => 'add counties', + label => 'add counties', cgi => $cgi, ); }, @@ -541,7 +541,7 @@ my @fields = ( } else { $r->city. ' '. remove_link( col => 'city', - label=> 'remove city', + label=> 'remove city', row => $r, cgi => $cgi, ); @@ -550,7 +550,7 @@ my @fields = ( '(all) '. expand_link( desc => 'Add Cities', row => $r, - label => 'add cities', + label => 'add cities', cgi => $cgi, ); } @@ -562,7 +562,7 @@ my @fields = ( if ( $r->district ) { $r->district . ' '. remove_link( col => 'district', - label=> 'remove district', + label=> 'remove district', row => $r, cgi => $cgi, ); -- cgit v1.2.1