From aa55eded7431d4781b7105b9b895f4b20e575f01 Mon Sep 17 00:00:00 2001 From: Christopher Burger Date: Sun, 21 Apr 2019 16:14:13 -0400 Subject: RT# 83039 - only towers with sectors shown on provisioning page when export requires sectors Conflicts: httemplate/elements/select-table.html --- httemplate/edit/svc_broadband.cgi | 16 +++++++++++++++- httemplate/elements/select-table.html | 7 +++++++ httemplate/elements/select-tower_sector.html | 5 ++++- 3 files changed, 26 insertions(+), 2 deletions(-) (limited to 'httemplate') diff --git a/httemplate/edit/svc_broadband.cgi b/httemplate/edit/svc_broadband.cgi index 374af4770..5a3692e14 100644 --- a/httemplate/edit/svc_broadband.cgi +++ b/httemplate/edit/svc_broadband.cgi @@ -101,7 +101,21 @@ END my @fields = ( qw( description speed_down speed_up speed_test_down speed_test_up speed_test_latency), - { field=>'sectornum', type=>'select-tower_sector', }, + { field=>'sectornum', type=>'select-tower_sector', + include_opt_callback => sub { + my $svc_broadband = shift; + my $part_svc = $svc_broadband->part_svc; + my $sectors_only; + foreach ($part_svc->part_export()) { + $sectors_only = '1' if $_->can('require_tower_and_sector'); + } + ## incase export requires a sector and service only has tower attached it will not show on edit. + my $non_option_label; + my $sector = qsearchs({'table' => 'tower_sector', 'hashref' => { 'sectornum' => $svc_broadband->sectornum }, }); + $non_option_label = $sector->description if $sector; + return ('sectorsonly' => $sectors_only, 'non_option_label' => $non_option_label); + }, + }, { field=>'routernum', type=>'select-router_block_ip', include_opt_callback => sub { my $svc_broadband = shift; diff --git a/httemplate/elements/select-table.html b/httemplate/elements/select-table.html index 4ac0887fd..8aaa58db2 100644 --- a/httemplate/elements/select-table.html +++ b/httemplate/elements/select-table.html @@ -90,6 +90,7 @@ Example: % } +% my $curr_option_found; % # XXX fix this eventually, when we have time to test it % foreach my $record ( sort { $a->$name_col() cmp $b->$name_col() % || $a->$key() <=> $b->$key() @@ -107,6 +108,7 @@ Example: % $selected = ( ref($value) && $value->{$recvalue} ) % || ( $value && $value eq $recvalue ); #not == because of value_col % } +% $curr_option_found = $selected unless $curr_option_found; +% } + +% my $non_option_label = $opt{'non_option_label'}; +% if (!$curr_option_found && $non_option_label && $value) { + % } diff --git a/httemplate/elements/select-tower_sector.html b/httemplate/elements/select-tower_sector.html index 76ff25223..4dfd23dcc 100644 --- a/httemplate/elements/select-tower_sector.html +++ b/httemplate/elements/select-tower_sector.html @@ -3,7 +3,7 @@ table => 'tower_sector', name_col => 'description', addl_from => 'JOIN tower USING (towernum)', - extra_sql => q(WHERE disabled = '' OR disabled IS NULL), + extra_sql => $extra_sql, order_by => 'ORDER BY towernum,sectorname', empty_label => ' ', @_ @@ -67,4 +67,7 @@ foreach my $towernum (keys %sectors_of) { } my $empty_label = $opt{'empty_label'} || 'Include services with no sector'; + +my $extra_sql = q(WHERE (disabled = '' OR disabled IS NULL)); +$extra_sql .= q( AND sectorname != '_default') if $opt{'sectorsonly'}; -- cgit v1.2.1