From 6924a1488d0ec5e64f2dc5a7f9b927464515c068 Mon Sep 17 00:00:00 2001
From: Mark Wells <mark@freeside.biz>
Date: Thu, 15 Aug 2013 00:13:56 -0700
Subject: fix some UI issues with the report class bulk edit, #24070

---
 httemplate/edit/bulk-part_pkg.html | 16 +++++++---------
 1 file changed, 7 insertions(+), 9 deletions(-)

(limited to 'httemplate/edit/bulk-part_pkg.html')

diff --git a/httemplate/edit/bulk-part_pkg.html b/httemplate/edit/bulk-part_pkg.html
index a1c6f0c9b..1773c9a8b 100644
--- a/httemplate/edit/bulk-part_pkg.html
+++ b/httemplate/edit/bulk-part_pkg.html
@@ -22,15 +22,12 @@ The following packages will be changed:<BR>
 % foreach my $num (sort keys %report_class) {
   <TR CLASS="row<%$row % 2%>">
     <TD>
-%   if ( defined $initial_state{$num} ) {
-      <& /elements/checkbox.html,
-            field => 'report_option_'.$num,
-            value => 1,
-            curr_value => $initial_state{$num}
-      &>
-%   } else {
+%   if ( $initial_state{$num} == -1 ) {
 %     # needs to be a tristate so that you can say "don't change it"
       <& /elements/checkbox-tristate.html, field => 'report_option_'.$num &>
+%   } else {
+%# for visual consistency
+      <INPUT TYPE="checkbox" CLASS="partial" NAME="report_option_<%$num%>" VALUE="1" <% $initial_state{$num} ? 'CHECKED':'' %>><LABEL />
 %   }
     </TD>
     <TD><% $report_class{$num}->name %></TD>
@@ -64,11 +61,12 @@ foreach my $num (keys %report_class) {
     }
   }
   if ( $yes and $no ) {
-    $initial_state{$num} = undef;
+    $initial_state{$num} = -1;
   } elsif ( $yes ) {
     $initial_state{$num} = 1;
   } elsif ( $no ) {
-    $initial_state{$num} = 0;
+    $initial_state{$num} = '';
   } # else, uh, you didn't provide any pkgparts
 }
+warn Dumper \%initial_state;
 </%init>
-- 
cgit v1.2.1


From 22a2961bb218bd7f02606ce17a56186b7c107239 Mon Sep 17 00:00:00 2001
From: Mark Wells <mark@freeside.biz>
Date: Thu, 15 Aug 2013 10:02:26 -0700
Subject: fix spelling errors

---
 httemplate/edit/bulk-part_pkg.html | 1 -
 1 file changed, 1 deletion(-)

(limited to 'httemplate/edit/bulk-part_pkg.html')

diff --git a/httemplate/edit/bulk-part_pkg.html b/httemplate/edit/bulk-part_pkg.html
index 1773c9a8b..9d0792f54 100644
--- a/httemplate/edit/bulk-part_pkg.html
+++ b/httemplate/edit/bulk-part_pkg.html
@@ -68,5 +68,4 @@ foreach my $num (keys %report_class) {
     $initial_state{$num} = '';
   } # else, uh, you didn't provide any pkgparts
 }
-warn Dumper \%initial_state;
 </%init>
-- 
cgit v1.2.1


From 81fbbbd132ec70b81719399aa07d7a6f2606ba6f Mon Sep 17 00:00:00 2001
From: Mark Wells <mark@freeside.biz>
Date: Thu, 15 Aug 2013 14:32:56 -0700
Subject: fix error handling path, #24070

---
 httemplate/edit/bulk-part_pkg.html | 1 +
 1 file changed, 1 insertion(+)

(limited to 'httemplate/edit/bulk-part_pkg.html')

diff --git a/httemplate/edit/bulk-part_pkg.html b/httemplate/edit/bulk-part_pkg.html
index 9d0792f54..4665c9f95 100644
--- a/httemplate/edit/bulk-part_pkg.html
+++ b/httemplate/edit/bulk-part_pkg.html
@@ -6,6 +6,7 @@
 .row0 { background-color: #eeeeee; }
 .row1 { background-color: #ffffff; }
 </STYLE>
+<& /elements/error.html &>
 
 <FORM ACTION="process/bulk-part_pkg.html" METHOD="POST">
 <DIV>
-- 
cgit v1.2.1