From b48c02a92562395c84dbfe8c47db5c4ba14891a0 Mon Sep 17 00:00:00 2001 From: Christopher Burger Date: Sun, 10 Mar 2019 19:12:20 -0400 Subject: RT# 82988 - Fixed so only formats that can handle electronic refunds can download those files --- FS/bin/freeside-eftca-upload | 6 +++++- FS/bin/freeside-paymentech-upload | 1 + FS/bin/freeside-rbc-upload | 1 + 3 files changed, 7 insertions(+), 1 deletion(-) (limited to 'FS/bin') diff --git a/FS/bin/freeside-eftca-upload b/FS/bin/freeside-eftca-upload index 503c7a35a..18656c97a 100755 --- a/FS/bin/freeside-eftca-upload +++ b/FS/bin/freeside-eftca-upload @@ -32,8 +32,12 @@ my @batches; if($opt_a) { local $@; + + my %criteria= ( 'status' => 'O', 'payby' => 'CHEK' ); + $criteria{'type'} = 'DEBIT' unless FS::pay_batch->can_handle_electronic_refunds('eft_canada'); + eval { - @batches = qsearch('pay_batch', { 'status' => 'O', 'payby' => 'CHEK' }) + @batches = qsearch('pay_batch', \%criteria) }; log_error_and_die ("Fatal database error: $@") if $@; diff --git a/FS/bin/freeside-paymentech-upload b/FS/bin/freeside-paymentech-upload index d6ca0cd28..8ec8a5dd4 100755 --- a/FS/bin/freeside-paymentech-upload +++ b/FS/bin/freeside-paymentech-upload @@ -41,6 +41,7 @@ my @batches; if($opt_a) { my %criteria = (status => 'O'); $criteria{'payby'} = uc($opt_p) if $opt_p; + $criteria{'type'} = 'DEBIT' unless FS::pay_batch->can_handle_electronic_refunds('paymentech'); @batches = qsearch('pay_batch', \%criteria); log_and_die("No open batches found".($opt_p ? " of type '$opt_p'" : '').".\n") if !@batches; diff --git a/FS/bin/freeside-rbc-upload b/FS/bin/freeside-rbc-upload index 3fff32a67..8f67a6e4f 100755 --- a/FS/bin/freeside-rbc-upload +++ b/FS/bin/freeside-rbc-upload @@ -33,6 +33,7 @@ my @batches; if($opt_a) { my %criteria = (status => 'O'); $criteria{'payby'} = uc($opt_p) if $opt_p; + $criteria{'type'} = 'DEBIT' unless FS::pay_batch->can_handle_electronic_refunds('RBC'); @batches = qsearch('pay_batch', \%criteria); die "No open batches found".($opt_p ? " of type '$opt_p'" : '').".\n" if !@batches; -- cgit v1.2.1