From 83cf53bba06bd40c34e547f2ae18cd4a59109ff7 Mon Sep 17 00:00:00 2001 From: ivan Date: Fri, 17 Apr 2009 19:50:21 +0000 Subject: add priority to job queue so billing jobs don't don't drown out provisioning jobs --- FS/bin/freeside-queued | 21 +++++++++++++-------- 1 file changed, 13 insertions(+), 8 deletions(-) (limited to 'FS/bin') diff --git a/FS/bin/freeside-queued b/FS/bin/freeside-queued index 93d735d1a..4093e5aa8 100644 --- a/FS/bin/freeside-queued +++ b/FS/bin/freeside-queued @@ -89,14 +89,19 @@ while (1) { my $nodepend = 'AND 0 = ( SELECT COUNT(*) FROM queue_depend'. ' WHERE queue_depend.jobnum = queue.jobnum ) '; - my $job = qsearchs( - 'queue', - { 'status' => 'new' }, - '', - driver_name eq 'mysql' - ? "$nodepend ORDER BY jobnum LIMIT 1 FOR UPDATE" - : "$nodepend ORDER BY jobnum FOR UPDATE LIMIT 1" - ) or do { + #anything with a priority goes after stuff without one + my $order_by = ' ORDER BY COALESCE(priority,0) ASC, jobnum ASC '; + + $order_by .= ( driver_name eq 'mysql' + ? ' LIMIT 1 FOR UPDATE ' + : ' FOR UPDATE LIMIT 1 ' ); + + my $job = qsearchs({ + 'table' => 'queue', + 'hashref' => { 'status' => 'new' }, + 'extra_sql' => $nodepend, + 'order_by' => $order_by, + }) or do { # if $oldAutoCommit { dbh->commit or do { warn "WARNING: database error, closing connection: ". dbh->errstr; -- cgit v1.2.1