From 3a09582cbae17d3c1cfd0c9530b5ef6c2fe659a1 Mon Sep 17 00:00:00 2001 From: Ivan Kohler Date: Mon, 16 Jul 2018 18:41:46 -0700 Subject: harmless, but don't do a string comparison on numbers anyway, RT#79825 --- FS/FS/svc_IP_Mixin.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/FS/FS/svc_IP_Mixin.pm b/FS/FS/svc_IP_Mixin.pm index 8b2b5f17e..4b402fa8d 100644 --- a/FS/FS/svc_IP_Mixin.pm +++ b/FS/FS/svc_IP_Mixin.pm @@ -80,7 +80,7 @@ sub svc_ip_check { my $error = $self->ip_check; return $error if $error; if ( my $router = $self->router ) { - if ( grep { $_->routernum eq $router->routernum } $self->allowed_routers ) { + if ( grep { $_->routernum == $router->routernum } $self->allowed_routers ) { return ''; } else { return 'Router '.$router->routername.' not available for this service'; -- cgit v1.2.1 From bdaaea08f99d60c05389e16fb3e49b38c862af1a Mon Sep 17 00:00:00 2001 From: Ivan Kohler Date: Mon, 16 Jul 2018 18:43:36 -0700 Subject: whitespace, RT#79825 --- FS/FS/svc_broadband.pm | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/FS/FS/svc_broadband.pm b/FS/FS/svc_broadband.pm index 96028df9c..b2fc27260 100755 --- a/FS/FS/svc_broadband.pm +++ b/FS/FS/svc_broadband.pm @@ -110,12 +110,12 @@ sub table_info { 'speed_down' => 'Download speed (Kbps)', 'speed_up' => 'Upload speed (Kbps)', 'ip_addr' => 'IP address', - 'blocknum' => - { 'label' => 'Address block', - 'type' => 'select', - 'select_table' => 'addr_block', - 'select_key' => 'blocknum', - 'select_label' => 'cidr', + 'blocknum' => { + 'label' => 'Address block', + 'type' => 'select', + 'select_table' => 'addr_block', + 'select_key' => 'blocknum', + 'select_label' => 'cidr', 'disable_inventory' => 1, }, 'plan_id' => 'Service Plan Id', -- cgit v1.2.1 From ee32c5f35c41c7bc30a26b3217db3196ff5f39b7 Mon Sep 17 00:00:00 2001 From: Ivan Kohler Date: Mon, 16 Jul 2018 18:46:27 -0700 Subject: fix phantom customer links --- rt/lib/RT/Record.pm | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/rt/lib/RT/Record.pm b/rt/lib/RT/Record.pm index 1818c2d48..8f1b5be5e 100755 --- a/rt/lib/RT/Record.pm +++ b/rt/lib/RT/Record.pm @@ -1282,6 +1282,11 @@ sub Customers { $self->{'Customers'} = $self->MemberOf->Clone; + $self->{'Customers'}->Limit( FIELD => 'Base', + OPERATOR => 'STARTSWITH', + VALUE => 'fsck.com-rt://%/ticket/', + ); + for my $fstable (qw(cust_main cust_svc)) { $self->{'Customers'}->Limit( -- cgit v1.2.1