summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
-rw-r--r--FS/FS/cust_main/Billing.pm2
-rw-r--r--FS/FS/part_pkg/flat.pm23
2 files changed, 11 insertions, 14 deletions
diff --git a/FS/FS/cust_main/Billing.pm b/FS/FS/cust_main/Billing.pm
index 44a4dbb..08b10c1 100644
--- a/FS/FS/cust_main/Billing.pm
+++ b/FS/FS/cust_main/Billing.pm
@@ -1030,6 +1030,7 @@ sub _make_lines {
warn " bill setup\n" if $DEBUG > 1;
+ unless ( $cust_pkg->waive_setup ) {
$lineitems++;
$setup = eval { $cust_pkg->calc_setup( $time, \@details, \%setup_param ) };
@@ -1049,6 +1050,7 @@ sub _make_lines {
$setup_billed_currency = delete $setup_param{'billed_currency'};
$setup_billed_amount = delete $setup_param{'billed_amount'};
}
+ }
if ( $cust_pkg->get('setup') ) {
# don't change it
diff --git a/FS/FS/part_pkg/flat.pm b/FS/FS/part_pkg/flat.pm
index 0bc3860..6fd9c7d 100644
--- a/FS/FS/part_pkg/flat.pm
+++ b/FS/FS/part_pkg/flat.pm
@@ -118,27 +118,22 @@ sub calc_setup {
return 0 if $self->prorate_setup($cust_pkg, $sdate);
- if (!$cust_pkg->waive_setup) {
- my $i = 0;
- my $count = $self->option( 'additional_count', 'quiet' ) || 0;
- while ($i < $count) {
- push @$details, $self->option( 'additional_info' . $i++ );
- }
+ my $i = 0;
+ my $count = $self->option( 'additional_count', 'quiet' ) || 0;
+ while ($i < $count) {
+ push @$details, $self->option( 'additional_info' . $i++ );
+ }
- my $charge = $self->base_setup($cust_pkg, $sdate, $details);
+ my $charge = $self->base_setup($cust_pkg, $sdate, $details);
- my $discount = 0;
- if ( $charge > 0 ) {
+ my $discount = 0;
+ if ( $charge > 0 ) {
$param->{'setup_charge'} = $charge;
$discount = $self->calc_discount($cust_pkg, $sdate, $details, $param);
delete $param->{'setup_charge'};
- }
-
- return sprintf( '%.2f', ($cust_pkg->quantity || 1) * ($charge - $discount) );
}
- return;
-
+ sprintf( '%.2f', ($cust_pkg->quantity || 1) * ($charge - $discount) );
}
sub base_setup {