diff options
| author | ivan <ivan> | 2008-03-03 23:07:58 +0000 |
|---|---|---|
| committer | ivan <ivan> | 2008-03-03 23:07:58 +0000 |
| commit | 479339313bbda612f8fe939217fd067999ef36d4 (patch) | |
| tree | a47e2fbdc0107910bbbd3b57dc0cbfc357f76aa3 /rt/html | |
| parent | 642d85fc54b066e6364b66644b95c7b123ba8e24 (diff) | |
merge in rt 3.4.6. *gulp*!
Diffstat (limited to 'rt/html')
| -rw-r--r-- | rt/html/Admin/Groups/index.html | 4 | ||||
| -rw-r--r-- | rt/html/Elements/CollectionAsTable/ParseFormat | 8 | ||||
| -rw-r--r-- | rt/html/Elements/EditCustomFieldSelect | 2 | ||||
| -rw-r--r-- | rt/html/Elements/QuickCreate | 2 | ||||
| -rw-r--r-- | rt/html/Elements/Quicksearch | 10 | ||||
| -rw-r--r-- | rt/html/Elements/SelectNewTicketQueue | 2 | ||||
| -rw-r--r-- | rt/html/Elements/ShowCustomFields | 40 | ||||
| -rw-r--r-- | rt/html/REST/1.0/Forms/ticket/default | 4 | ||||
| -rw-r--r-- | rt/html/REST/1.0/NoAuth/mail-gateway | 42 | ||||
| -rw-r--r-- | rt/html/REST/1.0/search/ticket | 2 | ||||
| -rw-r--r-- | rt/html/SelfService/Create.html | 2 | ||||
| -rw-r--r-- | rt/html/Ticket/Create.html | 2 | ||||
| -rw-r--r-- | rt/html/Ticket/Display.html | 24 | ||||
| -rw-r--r-- | rt/html/Ticket/Elements/EditCustomFields | 3 | ||||
| -rwxr-xr-x | rt/html/Ticket/Elements/PreviewScrips | 12 | ||||
| -rw-r--r-- | rt/html/Ticket/Elements/ShowBasics | 28 | ||||
| -rw-r--r-- | rt/html/Ticket/Elements/ShowDates | 32 | ||||
| -rw-r--r-- | rt/html/Ticket/Elements/ShowHistory | 10 | ||||
| -rw-r--r-- | rt/html/Ticket/Elements/ShowRequestor | 10 | ||||
| -rw-r--r-- | rt/html/Ticket/Elements/ShowSummary | 4 |
20 files changed, 136 insertions, 107 deletions
diff --git a/rt/html/Admin/Groups/index.html b/rt/html/Admin/Groups/index.html index 073440696..50857e5f4 100644 --- a/rt/html/Admin/Groups/index.html +++ b/rt/html/Admin/Groups/index.html @@ -78,6 +78,10 @@ $Groups->LimitToUserDefinedGroups(); my $title = loc('Select a group'); my $caption; +if ($FindDisabledGroups) { + $Groups->FindAllRows(); +} + if (length $GroupString) { $caption = loc("Groups matching search criteria"); if ($GroupField =~ /^CustomField-(\d+)/) { diff --git a/rt/html/Elements/CollectionAsTable/ParseFormat b/rt/html/Elements/CollectionAsTable/ParseFormat index 57434efe2..be56dea76 100644 --- a/rt/html/Elements/CollectionAsTable/ParseFormat +++ b/rt/html/Elements/CollectionAsTable/ParseFormat @@ -48,7 +48,7 @@ $Format </%ARGS> <%init> -use Regexp::Common; +use Regexp::Common qw/delimited/; my @Columns; while ($Format =~ /($RE{delimited}{-delim=>qq{\'"}}|[{}\w.]+)/go) { @@ -59,7 +59,9 @@ while ($Format =~ /($RE{delimited}{-delim=>qq{\'"}}|[{}\w.]+)/go) { substr($col,-1,1) = ""; } - my $colref; + my $colref = { + title => '', + }; if ( $col =~ s!/STYLE:([^/]+)!!io ) { $colref->{'style'} = $1; @@ -88,7 +90,7 @@ while ($Format =~ /($RE{delimited}{-delim=>qq{\'"}}|[{}\w.]+)/go) { $colref->{'attribute'} = $col; } - if ( !$colref->{'title'} && grep { /^__(.*?)__$/io } + if ( !$colref->{'title'} && grep { /^__(.+?)__$/io } @{ $colref->{'output'} } ) { $colref->{'title'} = $1; diff --git a/rt/html/Elements/EditCustomFieldSelect b/rt/html/Elements/EditCustomFieldSelect index 2a2a64a1d..5dd4d0d69 100644 --- a/rt/html/Elements/EditCustomFieldSelect +++ b/rt/html/Elements/EditCustomFieldSelect @@ -51,7 +51,7 @@ % while ($CFVs and my $value = $CFVs->Next ) { <option value="<%$value->Name%>" % if ($Values) { - <% $Values->HasEntry($value->Name) && ($selected = 1) && 'SELECTED' %> + <% ($Values->HasEntry($value->Name)||'') && ($selected = 1) && 'SELECTED' %> % } elsif ($Default) { <% (ref $Default ? (grep {$_ eq $value->Name} @{$Default}) : ($Default eq $value->Name)) && ($selected = 1) && 'SELECTED' %> diff --git a/rt/html/Elements/QuickCreate b/rt/html/Elements/QuickCreate index 0b97121a4..8fdce4cbc 100644 --- a/rt/html/Elements/QuickCreate +++ b/rt/html/Elements/QuickCreate @@ -52,7 +52,7 @@ <font size="-2"><&|/l&>Subject</&>:<br><input size="30" name="Subject"></font> </td> <td> -<font size="-2"><&|/l&>Queue</&>:<br><& /Elements/SelectQueue, Name => 'Queue', ShowNullOption => 0 &></font> +<font size="-2"><&|/l&>Queue</&>:<br><& /Elements/SelectNewTicketQueue, Name => 'Queue' &></font> </td> <td> <font size="-2"><&|/l&>Owner</&>:<br> diff --git a/rt/html/Elements/Quicksearch b/rt/html/Elements/Quicksearch index d54f72e88..5f1af0f2d 100644 --- a/rt/html/Elements/Quicksearch +++ b/rt/html/Elements/Quicksearch @@ -57,12 +57,10 @@ my $i; while (my $queue = $Queues->Next) { next unless ($queue->CurrentUserHasRight('ShowTicket')); - my $name = $queue->Name; - $name =~ s|(['\\])|\\$1|g; - - my $new_q = "Queue = '$name' AND Status = 'new'"; - my $open_q = "Queue = '$name' AND Status = 'open'"; - my $all_q = "Queue = '$name' AND (Status = 'open' OR Status = 'new')"; + my $qid = $queue->Id; + my $new_q = "Queue = '$qid' AND Status = 'new'"; + my $open_q = "Queue = '$qid' AND Status = 'open'"; + my $all_q = "Queue = '$qid' AND (Status = 'open' OR Status = 'new')"; $Tickets->FromSQL($open_q); my $open = $Tickets->Count(); diff --git a/rt/html/Elements/SelectNewTicketQueue b/rt/html/Elements/SelectNewTicketQueue index d47b58a83..51b89b2a6 100644 --- a/rt/html/Elements/SelectNewTicketQueue +++ b/rt/html/Elements/SelectNewTicketQueue @@ -48,7 +48,7 @@ % foreach my $queue (@{$session{'create_in_queues'}}) { <OPTION VALUE="<%$queue->{'id'}%>" - <%$Default && ($queue->{'id'} == $Default) && 'SELECTED'%>> + <% $Default && $queue->{'id'} == $Default ? 'SELECTED': ''%>> <%$queue->{'Name'}%> % if (($Verbose) and ($queue->{'Description'}) ){ (<%$queue->{'Description'}%>) diff --git a/rt/html/Elements/ShowCustomFields b/rt/html/Elements/ShowCustomFields index 986184120..199fe3606 100644 --- a/rt/html/Elements/ShowCustomFields +++ b/rt/html/Elements/ShowCustomFields @@ -44,36 +44,42 @@ %# %# END BPS TAGGED BLOCK }}} <table> -% my @entry_fields; -% while (my $CustomField = $CustomFields->Next()) { -% my $Values = $Object->CustomFieldValues($CustomField->Id); +% while ( my $CustomField = $CustomFields->Next ) { +% my $Values = $Object->CustomFieldValues( $CustomField->Id ); +% my $count = $Values->Count; <tr> - <td class="label"><%$CustomField->Name%>:</td> + <td class="label"><% $CustomField->Name %>:</td> <td class="value"> +% unless ( $count ) { +<i><&|/l&>(no value)</&></i> +% } elsif ( $count == 1 ) { +% $print_value->( $CustomField, $Values->First ); +% } else { <ul> -% while (my $Value = $Values->Next()) { -<li> -% my $comp = "ShowCustomField".$CustomField->Type; -% if ($m->comp_exists($comp)) { -<& $comp, Object => $Value &> -% } else { -<%$Value->Content%> -% } -</li> -% } -% unless ($Values->Count()) { -<li><i><&|/l&>(no value)</&></i></li> +% while ( my $Value = $Values->Next ) { +<li><% $print_value->( $CustomField, $Value ) |n %></li> % } </ul> +% } </td> </tr> % } </table> <%INIT> my $CustomFields = $Object->CustomFields; - $m->comp('/Elements/Callback', _CallbackName => 'MassageCustomFields', +$m->comp('/Elements/Callback', _CallbackName => 'MassageCustomFields', CustomFields => $CustomFields); +my $print_value = sub { + my ($cf, $value) = @_; + my $comp = "ShowCustomField". $cf->Type; + if ( $m->comp_exists( $comp ) ) { + $m->comp( $comp, Object => $value ); + } else { + $m->print( $value->Content ); + } +}; + </%INIT> <%ARGS> $Object => undef diff --git a/rt/html/REST/1.0/Forms/ticket/default b/rt/html/REST/1.0/Forms/ticket/default index 78f6c9562..7d515e51f 100644 --- a/rt/html/REST/1.0/Forms/ticket/default +++ b/rt/html/REST/1.0/Forms/ticket/default @@ -57,7 +57,7 @@ my @comments; my ($c, $o, $k, $e) = ("", [], {}, 0); my %data = %$changes; my $ticket = new RT::Ticket $session{CurrentUser}; -my @dates = qw(Created Starts Started Due Resolved Told); +my @dates = qw(Created Starts Started Due Resolved Told LastUpdated); my @people = qw(Requestors Cc AdminCc); my @create = qw(Queue Requestor Subject Cc AdminCc Owner Status Priority InitialPriority FinalPriority TimeEstimated TimeWorked @@ -95,7 +95,7 @@ else { $starts->SetToNow; return [ - "# Required: Queue, Requestor, Subject", + "# Required: id, Queue", [ qw(id Queue Requestor Subject Cc AdminCc Owner Status Priority InitialPriority FinalPriority TimeEstimated Starts Due Text) ], { diff --git a/rt/html/REST/1.0/NoAuth/mail-gateway b/rt/html/REST/1.0/NoAuth/mail-gateway index 5252c1968..65d55508d 100644 --- a/rt/html/REST/1.0/NoAuth/mail-gateway +++ b/rt/html/REST/1.0/NoAuth/mail-gateway @@ -52,26 +52,30 @@ $action => "correspond" $ticket => undef </%ARGS> <%init> -use RT::Interface::Email; +use RT::Interface::Email (); # It's an exporter, but we don't care $r->content_type('text/plain; charset=utf-8'); $m->error_format('text'); -my ( $status, $error, $Ticket ) = RT::Interface::Email::Gateway(\%ARGS); - if ($status == -75 ) { -$m->out("temporary failure - ". $error); - } - elsif ($status == 1) { -$m->out('ok'); - if ( $Ticket->Id ) { -$m->out('Ticket: '. $Ticket->Id); -$m->out('Queue: '. $Ticket->QueueObj->Name ); -$m->out('Owner: '. $Ticket->OwnerObj->Name); -$m->out('Status: '. $Ticket->Status ); -$m->out('Subject: '. $Ticket->Subject ); -$m->out('Requestor: '. $Ticket->Requestors->MemberEmailAddressesAsString ); - } - } else { -$m->out('not ok - '.$error); - } - +my ( $status, $error, $Ticket ) = RT::Interface::Email::Gateway( \%ARGS ); +if ( $status == 1 ) { + $m->out('ok'); + if ( $Ticket->Id ) { + $m->out( 'Ticket: ' . $Ticket->Id ); + $m->out( 'Queue: ' . $Ticket->QueueObj->Name ); + $m->out( 'Owner: ' . $Ticket->OwnerObj->Name ); + $m->out( 'Status: ' . $Ticket->Status ); + $m->out( 'Subject: ' . $Ticket->Subject ); + $m->out( + 'Requestor: ' . $Ticket->Requestors->MemberEmailAddressesAsString ); + } +} +else { + $RT::Logger->error( "Could not record email: " . $error ); + if ( $status == -75 ) { + $m->out( "temporary failure - " . $error ); + } + else { + $m->out( 'not ok - ' . $error ); + } +} $m->abort(); </%init> diff --git a/rt/html/REST/1.0/search/ticket b/rt/html/REST/1.0/search/ticket index d0ab59e98..0990fd69b 100644 --- a/rt/html/REST/1.0/search/ticket +++ b/rt/html/REST/1.0/search/ticket @@ -123,7 +123,7 @@ while (my $ticket = $tickets->Next) { } else { my $id = $ticket->Id; - my $d = $m->comp("$RT::WebPath/REST/1.0/Forms/ticket/default", id => $id, format => $format, fields => \%fields); + my $d = $m->comp("/REST/1.0/Forms/ticket/default", id => $id, format => $format, fields => \%fields); my ($c, $o, $k, $e) = @$d; push @output, [ $c, $o, $k ]; } diff --git a/rt/html/SelfService/Create.html b/rt/html/SelfService/Create.html index d60ae267a..bfa7534eb 100644 --- a/rt/html/SelfService/Create.html +++ b/rt/html/SelfService/Create.html @@ -79,7 +79,7 @@ <&|/l&>Subject</&>: </TD> <TD class="value"> -<INPUT Name="Subject" SIZE=60 MAXSIZE=100 value=""> +<INPUT Name="Subject" SIZE=60 MAXSIZE=200 value=""> </TD> </TR> <tr> diff --git a/rt/html/Ticket/Create.html b/rt/html/Ticket/Create.html index b547242f2..fc4cc20ef 100644 --- a/rt/html/Ticket/Create.html +++ b/rt/html/Ticket/Create.html @@ -105,7 +105,7 @@ <&|/l&>Subject</&>: </TD> <TD class=value COLSPAN=5> -<INPUT Name="Subject" SIZE=60 MAXSIZE=100 value="<%$ARGS{Subject} || ''%>"> +<INPUT Name="Subject" SIZE=60 MAXSIZE=200 value="<%$ARGS{Subject} || ''%>"> </TD> </TR> <TR> diff --git a/rt/html/Ticket/Display.html b/rt/html/Ticket/Display.html index dd4c093dc..908a7a93a 100644 --- a/rt/html/Ticket/Display.html +++ b/rt/html/Ticket/Display.html @@ -128,17 +128,19 @@ if ($ARGS{'id'} eq 'new') { } $ARGS{'UpdateContent'} =~ s/\r\n/\n/g if defined $ARGS{'UpdateContent'}; - if ( $ARGS{'UpdateTimeWorked'} || - $session{'Attachments'} || - ( defined $ARGS{'UpdateContent'} - && $ARGS{'UpdateContent'} ne '' - && $ARGS{'UpdateContent'} ne "-- \n" - . $session{'CurrentUser'}->UserObj->Signature )) { - $ARGS{UpdateAttachments} = $session{'Attachments'}; - ProcessUpdateMessage( ARGSRef => \%ARGS, - Actions => \@Actions, - TicketObj => $TicketObj ); - delete $session{'Attachments'}; + if ( $ARGS{'UpdateTimeWorked'} || ( + defined $ARGS{'UpdateContent'} + && $ARGS{'UpdateContent'} ne '' + && $ARGS{'UpdateContent'} ne "-- \n" + . $session{'CurrentUser'}->UserObj->Signature ) ) + { + $ARGS{UpdateAttachments} = $session{'Attachments'}; + ProcessUpdateMessage( + ARGSRef => \%ARGS, + Actions => \@Actions, + TicketObj => $TicketObj, + ); + delete $session{'Attachments'}; } #Process status updates my @BasicActions = ProcessTicketBasics(ARGSRef => \%ARGS, TicketObj=>$TicketObj); diff --git a/rt/html/Ticket/Elements/EditCustomFields b/rt/html/Ticket/Elements/EditCustomFields index 6ae188fa7..78da71201 100644 --- a/rt/html/Ticket/Elements/EditCustomFields +++ b/rt/html/Ticket/Elements/EditCustomFields @@ -48,8 +48,7 @@ <td valign="top" width="50%"> <table> -% my @entry_fields; -% my $i; +% my $i = 0; % my $cfcount = $CustomFields->Count; % $cfcount++ if ($cfcount % 2) ; # if we have an odd number of % #custom fields, fudge it so we know where to put in the table break diff --git a/rt/html/Ticket/Elements/PreviewScrips b/rt/html/Ticket/Elements/PreviewScrips index a3492b749..491f8e3f3 100755 --- a/rt/html/Ticket/Elements/PreviewScrips +++ b/rt/html/Ticket/Elements/PreviewScrips @@ -86,15 +86,19 @@ my ( $Transaction, $Description, $Object ) = $TicketObj->$action( TimeTaken => $ARGS{'UpdateTimeWorked'}, DryRun => 1 ); +unless ( $Transaction ) { + $RT::Logger->error("Coulfn't fire '$action' action: $Description"); +} my @non_recipients = $TicketObj->SquelchMailTo; </%init> <h2><&|/l&>This message will be sent to...</&></h2> +% if ( $Object ) { <i><&|/l&>(Check boxes to disable notifications to the listed recipients)</&></i><br> % foreach my $scrip (@{$Object->Scrips->Prepared}) { % next unless $scrip->ActionObj->Action->isa('RT::Action::SendEmail'); -<b><%$scrip->Description%></b><br> +<b><% $scrip->Description %></b><br> <&|/l, loc($scrip->ConditionObj->Name), loc($scrip->ActionObj->Name), loc($scrip->TemplateObj->Name)&>[_1] [_2] with template [_3]</&> <br> %foreach my $type qw(To Cc Bcc) { @@ -110,8 +114,10 @@ my @non_recipients = $TicketObj->SquelchMailTo; <%$scrip->ActionObj->TemplateObj->MIMEObj->as_string%> </textarea> % } -%} -<br> +% } +% } +<br /> + <h2><&|/l&>Messages about this ticket will not be sent to...</&></h2> <i><&|/l&>(Check boxes to enable notifications to the listed recipients)</&></i> <br> diff --git a/rt/html/Ticket/Elements/ShowBasics b/rt/html/Ticket/Elements/ShowBasics index 00ed3ccd1..e5f09f693 100644 --- a/rt/html/Ticket/Elements/ShowBasics +++ b/rt/html/Ticket/Elements/ShowBasics @@ -45,36 +45,36 @@ %# END BPS TAGGED BLOCK }}} <table> <tr> - <td class="label"><&|/l&>Id</&>:</td> - <td class="value"><%$Ticket->Id %></td> + <td class="label id"><&|/l&>Id</&>:</td> + <td class="value id"><%$Ticket->Id %></td> </tr> <tr> - <td class="label"><&|/l&>Status</&>:</td> - <td class="value"><&|/l&><% $Ticket->Status%></&></td> + <td class="label status"><&|/l&>Status</&>:</td> + <td class="value status"><&|/l&><% $Ticket->Status%></&></td> </tr> % if ($Ticket->TimeEstimated) { <tr> - <td class="label"><&|/l&>Estimated</&>:</td> - <td class="value"><&|/l, $Ticket->TimeEstimated &>[_1] min</&></td> + <td class="label time estimated"><&|/l&>Estimated</&>:</td> + <td class="value time estimated"><&|/l, $Ticket->TimeEstimated &>[_1] min</&></td> </tr> % } % if ($Ticket->TimeWorked) { <tr> - <td class="label"><&|/l&>Worked</&>:</td> - <td class="value"><&|/l, $Ticket->TimeWorked &>[_1] min</&></td> + <td class="label time worked"><&|/l&>Worked</&>:</td> + <td class="value time worked"><&|/l, $Ticket->TimeWorked &>[_1] min</&></td> </tr> % } <tr> - <td class="label"><&|/l&>Left</&>:</td> - <td class="value"><&|/l, $Ticket->TimeLeft &>[_1] min</&></td> + <td class="label time left"><&|/l&>Left</&>:</td> + <td class="value time left"><&|/l, $Ticket->TimeLeft &>[_1] min</&></td> </tr> <tr> - <td class="label"><&|/l&>Priority</&>:</td> - <td class="value"><%$Ticket->Priority%>/<%$Ticket->FinalPriority %></td> + <td class="label priority"><&|/l&>Priority</&>:</td> + <td class="value priority"><%$Ticket->Priority%>/<%$Ticket->FinalPriority %></td> </tr> <tr> - <td class="label"><&|/l&>Queue</&>:</td> - <td class="value"><%$Ticket->QueueObj->Name%></td> + <td class="label queue"><&|/l&>Queue</&>:</td> + <td class="value queue"><%$Ticket->QueueObj->Name%></td> </tr> <& /Elements/Callback, _CallbackName => 'EndOfList', TicketObj => $Ticket, %ARGS &> </table> diff --git a/rt/html/Ticket/Elements/ShowDates b/rt/html/Ticket/Elements/ShowDates index 2ccbb3fea..322fafd99 100644 --- a/rt/html/Ticket/Elements/ShowDates +++ b/rt/html/Ticket/Elements/ShowDates @@ -45,36 +45,36 @@ %# END BPS TAGGED BLOCK }}} <TABLE> <TR> - <TD class="label"><&|/l&>Created</&>:</TD> - <TD class="value"><% $Ticket->CreatedObj->AsString %></TD> + <TD class="label date created"><&|/l&>Created</&>:</TD> + <TD class="value date created"><% $Ticket->CreatedObj->AsString %></TD> </TR> <TR> - <TD class="label"><&|/l&>Starts</&>:</TD> - <TD class="value"><% $Ticket->StartsObj->AsString %></TD> + <TD class="label date starts"><&|/l&>Starts</&>:</TD> + <TD class="value date starts"><% $Ticket->StartsObj->AsString %></TD> </TR> <TR> - <TD class="label"><&|/l&>Started</&>:</TD> - <TD class="value"><% $Ticket->StartedObj->AsString %></TD> + <TD class="label date started"><&|/l&>Started</&>:</TD> + <TD class="value date started"><% $Ticket->StartedObj->AsString %></TD> </TR> <TR> - <TD class="label"><a href="<%$RT::WebPath%>/Ticket/Display.html?id=<%$Ticket->id%>&Action=SetTold"><&|/l&>Last Contact</&></a>:</TD> - <TD class="value"><% $Ticket->ToldObj->AsString %></TD> + <TD class="label date told"><a href="<% $RT::WebPath %>/Ticket/Display.html?id=<% $Ticket->id %>&Action=SetTold"><&|/l&>Last Contact</&></a>:</TD> + <TD class="value date told"><% $Ticket->ToldObj->AsString %></TD> </TR> <TR> - <TD class="label"><&|/l&>Due</&>:</TD> - <TD class="value"><% $Ticket->DueObj->AsString %></TD> + <TD class="label date due"><&|/l&>Due</&>:</TD> + <TD class="value date due"><% $Ticket->DueObj->AsString %></TD> </TR> <TR> - <TD class="label"><&|/l&>Closed</&>:</TD> - <TD class="value"><% $Ticket->ResolvedObj->AsString %></TD> + <TD class="label date resolved"><&|/l&>Closed</&>:</TD> + <TD class="value date resolved"><% $Ticket->ResolvedObj->AsString %></TD> </TR> <TR> - <TD class="label"><&|/l&>Updated</&>:</TD> -% my $UpdatedString = $Ticket->LastUpdated ? (loc("[_1] by [_2]", $Ticket->LastUpdatedAsString, $Ticket->LastUpdatedByObj->Name)) : loc("Never"); + <TD class="label date updated"><&|/l&>Updated</&>:</TD> +% my $UpdatedString = $Ticket->LastUpdated ? loc("[_1] by [_2]", $Ticket->LastUpdatedAsString, $Ticket->LastUpdatedByObj->Name) : loc("Never"); % if ($UpdatedLink) { - <TD class="value"><A HREF="#lasttrans"><% $UpdatedString | h %></a></TD> + <TD class="value date updated"><A HREF="#lasttrans"><% $UpdatedString | h %></a></TD> % } else { - <TD class="value"><% $UpdatedString | h %></TD> + <TD class="value date updated"><% $UpdatedString | h %></TD> % } </TR> </TABLE> diff --git a/rt/html/Ticket/Elements/ShowHistory b/rt/html/Ticket/Elements/ShowHistory index 75e34776f..878e2535c 100644 --- a/rt/html/Ticket/Elements/ShowHistory +++ b/rt/html/Ticket/Elements/ShowHistory @@ -136,8 +136,16 @@ if ($Tickets) { } else { $Transactions = $Ticket->Transactions; } -my $i; + +my $OldestFirst = $RT::OldestTransactionsFirst? 'ASC': 'DESC'; +$Transactions->OrderByCols( { FIELD => 'Created', + ORDER => $OldestFirst }, + { FIELD => 'id', + ORDER => $OldestFirst }, + ); + +my $i; $Attachments ||= $m->comp('/Ticket/Elements/FindAttachments', Ticket => $Ticket, Tickets => $Tickets || undef); $AttachmentContent ||= $m->comp('/Ticket/Elements/LoadTextAttachments', Ticket => $Ticket); diff --git a/rt/html/Ticket/Elements/ShowRequestor b/rt/html/Ticket/Elements/ShowRequestor index 421d38e0a..57bfa0e55 100644 --- a/rt/html/Ticket/Elements/ShowRequestor +++ b/rt/html/Ticket/Elements/ShowRequestor @@ -47,17 +47,14 @@ my $rows = 10; my $people = $Ticket->Requestors->UserMembersObj; while (my $requestor=$people->Next) { +next if $requestor->Privileged; my $name=$requestor->RealName || $requestor->EmailAddress; my $tickets = RT::Tickets->new($session{'CurrentUser'}); -$tickets->LimitWatcher(TYPE => 'Requestor', VALUE => $requestor->EmailAddress ); -$tickets->LimitStatus( VALUE => 'open'); -$tickets->LimitStatus( VALUE => 'new'); +$tickets->FromSQL( "Requestor.id = ". $requestor->id ." AND (Status = 'open' OR Status = 'new')" ); $tickets->RowsPerPage($rows); -$tickets->OrderBy(FIELD => 'Priority', - ORDER => 'DESC'); +$tickets->OrderBy(FIELD => 'Priority', ORDER => 'DESC'); </%PERL> -% unless ($requestor->Privileged) { <& /Elements/TitleBoxStart, title => "<a class='inverse' href=\"$RT::WebPath/Admin/Users/Modify.html?id=".$requestor->id."\">".loc("More about [_1]", $name)."</a>" &> @@ -80,7 +77,6 @@ $tickets->OrderBy(FIELD => 'Priority', <& /Elements/TitleBoxEnd &> -% } %} <%ARGS> $Ticket=>undef diff --git a/rt/html/Ticket/Elements/ShowSummary b/rt/html/Ticket/Elements/ShowSummary index 5a6e7e099..e2f3e7195 100644 --- a/rt/html/Ticket/Elements/ShowSummary +++ b/rt/html/Ticket/Elements/ShowSummary @@ -79,6 +79,9 @@ <& /Elements/TitleBoxEnd &> <BR> + + <& /Elements/Callback, %ARGS, _CallbackName => 'LeftColumn' &> + </TD> <TD VALIGN=TOP WIDTH="50%" class="boxcontainer"> @@ -100,6 +103,7 @@ <& /Ticket/Elements/ShowRequestor, Ticket => $Ticket &> + <& /Elements/Callback, %ARGS, _CallbackName => 'RightColumn' &> </TD> </TR> |
