summaryrefslogtreecommitdiff
path: root/FS
diff options
context:
space:
mode:
authorIvan Kohler <ivan@freeside.biz>2017-03-06 21:33:37 -0800
committerIvan Kohler <ivan@freeside.biz>2017-03-06 21:33:37 -0800
commitda5b18b44fd8f953832a9985602cdd69e81bafb0 (patch)
treed1cb1bcef28981d7ebb48fd74e3249fb6f64783a /FS
parent5efeb63e2fcbbb864278a86bcc4663d4d533eb32 (diff)
detect errors on the scp portion of the backup, RT#74914
Diffstat (limited to 'FS')
-rw-r--r--FS/FS/Cron/backup.pm4
1 files changed, 3 insertions, 1 deletions
diff --git a/FS/FS/Cron/backup.pm b/FS/FS/Cron/backup.pm
index cfc8e3624..6e172ae4c 100644
--- a/FS/FS/Cron/backup.pm
+++ b/FS/FS/Cron/backup.pm
@@ -58,7 +58,9 @@ sub backup {
if ( $scpdest ) {
eval "use Net::SCP qw(scp);";
backup_email_and_die($conf,$filename,$@) if $@;
- scp("/var/tmp/$database.$ext", "$scpdest/$filename.$ext");
+ my $scp = new Net::SCP;
+ $scp->scp("/var/tmp/$database.$ext", "$scpdest/$filename.$ext")
+ or backup_email_and_die($conf, $filename, $scp->{errstr});
}
unlink "/var/tmp/$database.$ext" or backup_email_and_die($conf,$filename,$!); #or just warn?