->setfixed untaints svcnum

1 files changed, 4 insertions, 6 deletions

diff --git a/FS/FS/svc_domain.pm b/FS/FS/svc_domain.pm
index fce6cf2..b3b298b 100644
--- a/FS/FS/svc_domain.pm
+++ b/FS/FS/svc_domain.pm
@@ -289,16 +289,14 @@ Sets any fixed values; see L<FS::part_svc>.
 
 sub check {
   my $self = shift;
-  my $error =
-    $self->ut_numbern('svcnum')
-    || $self->ut_numbern('catchall')
-  ;
-  return $error if $error;
 
   my $x = $self->setfixed;
   return $x unless ref($x);
   my $part_svc = $x;
 
+  my $error = $self->ut_numbern('catchall');
+  return $error if $error;
+
   #hmm
   my $pkgnum;
   if ( $self->svcnum ) {
@@ -487,7 +485,7 @@ sub submit_internic {
 
 =head1 VERSION
 
-$Id: svc_domain.pm,v 1.14 2001-08-17 10:57:23 ivan Exp $
+$Id: svc_domain.pm,v 1.15 2001-08-19 08:18:01 ivan Exp $
 
 =head1 BUGS