diff options
author | Mark Wells <mark@freeside.biz> | 2016-12-14 13:00:24 -0800 |
---|---|---|
committer | Mark Wells <mark@freeside.biz> | 2016-12-14 13:41:39 -0800 |
commit | 5c59bb1d95ae3f0def9981a087f09ab0a687015b (patch) | |
tree | 2470c7489dbd7dfc7673d8a06a709bd4b3cff8de /FS/FS/msg_template | |
parent | 2e6c36147f13355a4f17afc1ff2a30642acf089e (diff) |
fix parsing of multiple To: addresses, #73241
Diffstat (limited to 'FS/FS/msg_template')
-rw-r--r-- | FS/FS/msg_template/email.pm | 15 |
1 files changed, 10 insertions, 5 deletions
diff --git a/FS/FS/msg_template/email.pm b/FS/FS/msg_template/email.pm index 5abbaca..63c860f 100644 --- a/FS/FS/msg_template/email.pm +++ b/FS/FS/msg_template/email.pm @@ -290,7 +290,7 @@ sub prepare { my @to; if ( exists($opt{'to'}) ) { - @to = split(/\s*,\s*/, $opt{'to'}); + @to = map { $_->format } Email::Address->parse($opt{'to'}); } elsif ( $cust_main ) { @@ -393,14 +393,17 @@ sub prepare { # effective To: address (not in headers) push @to, $self->bcc_addr if $self->bcc_addr; - my $env_to = join(', ', @to); + my @env_to; + foreach my $dest (@to) { + push @env_to, map { $_->address } Email::Address->parse($dest); + } my $cust_msg = FS::cust_msg->new({ 'custnum' => $cust_main ? $cust_main->custnum : '', 'msgnum' => $self->msgnum, '_date' => $time, 'env_from' => $env_from, - 'env_to' => $env_to, + 'env_to' => join(',', @env_to), 'header' => $message->header_as_string, 'body' => $message->body_as_string, 'error' => '', @@ -507,7 +510,9 @@ sub send_prepared { $domain = $1; } - my @to = split(/\s*,\s*/, $cust_msg->env_to); + # in principle should already be a list of bare addresses, but run it + # through Email::Address to make sure + my @env_to = map { $_->address } Email::Address->parse($cust_msg->env_to); my %smtp_opt = ( 'host' => $conf->config('smtpmachine'), 'helo' => $domain ); @@ -533,7 +538,7 @@ sub send_prepared { eval { sendmail( $message, { transport => $transport, from => $cust_msg->env_from, - to => \@to }) + to => \@env_to }) }; my $error = ''; if(ref($@) and $@->isa('Email::Sender::Failure')) { |