diff options
author | Jonathan Prykop <jonathan@freeside.biz> | 2016-05-28 18:42:30 -0500 |
---|---|---|
committer | Jonathan Prykop <jonathan@freeside.biz> | 2016-05-28 18:46:45 -0500 |
commit | d08cf825ecdcb08a2c36ac4ef79d9983455e2163 (patch) | |
tree | 200d30b2b8a57af6f067b6f87aac372267e02c24 /FS/FS/cust_main | |
parent | 1cc506c07d16f22d970d3959e263d602dba0f07d (diff) |
RT#57135: Credit card validation: take action based on AVS response [warnings in system log]
Diffstat (limited to 'FS/FS/cust_main')
-rw-r--r-- | FS/FS/cust_main/Billing_Realtime.pm | 17 |
1 files changed, 14 insertions, 3 deletions
diff --git a/FS/FS/cust_main/Billing_Realtime.pm b/FS/FS/cust_main/Billing_Realtime.pm index 8cac982..c676607 100644 --- a/FS/FS/cust_main/Billing_Realtime.pm +++ b/FS/FS/cust_main/Billing_Realtime.pm @@ -1918,6 +1918,8 @@ sub realtime_verify_bop { } } + my $log = FS::Log->new('FS::cust_main::Billing_Realtime::realtime_verify_bop'); + if ( $transaction->is_success() ) { $cust_pay_pending->status('authorized'); @@ -1962,6 +1964,7 @@ sub realtime_verify_bop { my $e = "Authorization successful but reversal failed, custnum #". $self->custnum. ': '. $reverse->result_code. ": ". $reverse->error_message; + $log->warning($e); warn $e; return $e; @@ -2000,6 +2003,7 @@ sub realtime_verify_bop { # Neither address nor postal code matches N N N N if (my $avscode = uc($transaction->avs_code)) { + # map codes to accept/warn/reject my $avs = { 'American Express card' => { @@ -2053,13 +2057,18 @@ sub realtime_verify_bop { my $cardtype = cardtype($content{card_number}); if ($avs->{$cardtype}) { my $avsact = $avs->{$cardtype}->{$avscode}; + my $warning = ''; if ($avsact eq 'r') { return "AVS code verification failed, cardtype $cardtype, code $avscode"; } elsif ($avsact eq 'w') { - warn "AVS code verification did not occur, cardtype $cardtype, code $avscode"; + $warning = "AVS did not occur, cardtype $cardtype, code $avscode"; } elsif (!$avsact) { - warn "AVS code verification did not occur, unknown avscode, cardtype $cardtype, code $avscode"; + $warning = "AVS code unknown, cardtype $cardtype, code $avscode"; } # else $avsact eq 'a' + if ($warning) { + $log->warning($warning); + warn $warning; + } } # else $cardtype avs handling not implemented } # else !$transaction->avs_code @@ -2086,7 +2095,9 @@ sub realtime_verify_bop { $self->payinfo($transaction->card_token); my $error = $self->replace; if ( $error ) { - warn "WARNING: error storing token: $error, but proceeding anyway\n"; + my $warning = "WARNING: error storing token: $error, but proceeding anyway\n"; + $log->warning($warning); + warn $warning; } } |