svc_domain needs to import dbh sub from Record

view/cust_main.cgi needs to use ->owed method, not check (depriciated) owed field
search/cust_bill.cgi redirect error when there's only one invoice

4 files changed, 24 insertions, 8 deletions

diff --git a/FS/FS/svc_domain.pm b/FS/FS/svc_domain.pm
index 3d011af2c..08bcc246e 100644
--- a/FS/FS/svc_domain.pm
+++ b/FS/FS/svc_domain.pm
@@ -11,7 +11,7 @@ use Mail::Internet;
 use Mail::Header;
 use Date::Format;
 use Net::Whois 1.0;
-use FS::Record qw(fields qsearch qsearchs);
+use FS::Record qw(fields qsearch qsearchs dbh);
 use FS::Conf;
 use FS::svc_Common;
 use FS::cust_svc;
@@ -478,7 +478,7 @@ sub submit_internic {
 
 =head1 VERSION
 
-$Id: svc_domain.pm,v 1.8 2001-04-15 13:35:12 ivan Exp $
+$Id: svc_domain.pm,v 1.9 2001-04-22 01:38:39 ivan Exp $
 
 =head1 BUGS
 
diff --git a/TODO b/TODO
index 52b88fdce..593f4e989 100644
--- a/TODO
+++ b/TODO
@@ -1,4 +1,4 @@
-$Id: TODO,v 1.62 2001-04-15 13:56:54 ivan Exp $
+$Id: TODO,v 1.63 2001-04-22 01:38:38 ivan Exp $
 
 If you are interested in helping with any of these, please join the
 *development* mailing list (send a blank message to
@@ -6,6 +6,11 @@ ivan-freeside-devel-subscribe@sisd.com) to avoid duplication of effort.
 
 ---
 
+Things that would be nice but probably won't happen: testing with 
+MySQL+Sleepycat, a fix for the long-RADIUS-attributes-with Pg problem,    
+passive session monitoring with RADIUS (tailing a log file or monitoring a
+database, as opposed to using a RADIUS with proper callbacks).
+
 anything doing transactions in the web interface should likely move into *.pm.
 (transactions are here woo!)
 
diff --git a/htdocs/search/cust_bill.cgi b/htdocs/search/cust_bill.cgi
index 95347032d..0645d1cc0 100755
--- a/htdocs/search/cust_bill.cgi
+++ b/htdocs/search/cust_bill.cgi
@@ -1,6 +1,6 @@
 #!/usr/bin/perl -Tw
 #
-# $Id: cust_bill.cgi,v 1.5 2000-07-17 16:45:41 ivan Exp $
+# $Id: cust_bill.cgi,v 1.6 2001-04-22 01:38:39 ivan Exp $
 #
 # Usage: post form to:
 #        http://server.name/path/cust_bill.cgi
@@ -11,7 +11,12 @@
 #       bmccane@maxbaud.net     98-apr-3
 #
 # $Log: cust_bill.cgi,v $
-# Revision 1.5  2000-07-17 16:45:41  ivan
+# Revision 1.6  2001-04-22 01:38:39  ivan
+# svc_domain needs to import dbh sub from Record
+# view/cust_main.cgi needs to use ->owed method, not check (depriciated) owed field
+# search/cust_bill.cgi redirect error when there's only one invoice
+#
+# Revision 1.5  2000/07/17 16:45:41  ivan
 # first shot at invoice browsing and some other cleanups
 #
 # Revision 1.4  1999/02/28 00:03:54  ivan
@@ -85,6 +90,7 @@ if ( $cgi->keywords ) {
 }
 
 if ( scalar(@cust_bill) == 1 ) {
+  my $invnum = $cust_bill[0]->invnum;
   print $cgi->redirect(popurl(2). "view/cust_bill.cgi?$invnum");  #redirect
 } elsif ( scalar(@cust_bill) == 0 ) {
   eidiot("Invoice not found.");
diff --git a/htdocs/view/cust_main.cgi b/htdocs/view/cust_main.cgi
index 055256570..ff169fdae 100755
--- a/htdocs/view/cust_main.cgi
+++ b/htdocs/view/cust_main.cgi
@@ -1,6 +1,6 @@
 #!/usr/bin/perl -Tw
 #
-# $Id: cust_main.cgi,v 1.18 1999-08-12 04:16:01 ivan Exp $
+# $Id: cust_main.cgi,v 1.19 2001-04-22 01:38:39 ivan Exp $
 #
 # Usage: cust_main.cgi custnum
 #        http://server.name/path/cust_main.cgi?custnum
@@ -31,7 +31,12 @@
 # lose background, FS::CGI ivan@sisd.com 98-sep-2
 #
 # $Log: cust_main.cgi,v $
-# Revision 1.18  1999-08-12 04:16:01  ivan
+# Revision 1.19  2001-04-22 01:38:39  ivan
+# svc_domain needs to import dbh sub from Record
+# view/cust_main.cgi needs to use ->owed method, not check (depriciated) owed field
+# search/cust_bill.cgi redirect error when there's only one invoice
+#
+# Revision 1.18  1999/08/12 04:16:01  ivan
 # hidecancelledpackages config option
 #
 # Revision 1.17  1999/04/15 16:44:36  ivan
@@ -331,7 +336,7 @@ foreach $bill (@bills) {
   push @history,
     $bref->{_date} . qq!\t<A HREF="!. popurl(2). qq!view/cust_bill.cgi?! .
     $bref->{invnum} . qq!">Invoice #! . $bref->{invnum} .
-    qq! (Balance \$! . $bref->{owed} . qq!)</A>\t! .
+    qq! (Balance \$! . $bill->owed . qq!)</A>\t! .
     $bref->{charged} . qq!\t\t\t!;
 
   my(@payments)=qsearch('cust_pay',{'invnum'=> $bref->{invnum} } );