summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authormark <mark>2009-12-29 01:00:48 +0000
committermark <mark>2009-12-29 01:00:48 +0000
commit09b21d0180c2ea23c7dd0b6611d26a4af184a56d (patch)
tree1884bc83b2c2a6ca9051f826adf1837a79ac1a45
parentb249b6d799647050468ead9cfcbd1e5ebbb026cc (diff)
Add Browse attachments ACL (RT#4964)
-rw-r--r--FS/FS/AccessRight.pm3
-rwxr-xr-xhttemplate/browse/cust_attachment.html3
-rw-r--r--httemplate/elements/menu.html2
3 files changed, 5 insertions, 3 deletions
diff --git a/FS/FS/AccessRight.pm b/FS/FS/AccessRight.pm
index 44235b113..46e740cc1 100644
--- a/FS/FS/AccessRight.pm
+++ b/FS/FS/AccessRight.pm
@@ -206,7 +206,8 @@ tie my %rights, 'Tie::IxHash',
'Customer note and attachment rights' => [
'Add customer note', #NEW
'Edit customer note', #NEW
- 'View attachments',
+ 'View attachments', #NEW
+ 'Browse attachments', #NEW
'Download attachment', #NEW
'Add attachment', #NEW
'Edit attachment', #NEW
diff --git a/httemplate/browse/cust_attachment.html b/httemplate/browse/cust_attachment.html
index d95f2b18c..e19259d05 100755
--- a/httemplate/browse/cust_attachment.html
+++ b/httemplate/browse/cust_attachment.html
@@ -62,7 +62,8 @@
<%init>
my $curuser = $FS::CurrentUser::CurrentUser;
-die "access denied" if !$curuser->access-right('View attachments');
+die "access denied" if !$curuser->access_right('View attachments')
+ or !$curuser->access_right('Browse attachments');
my $conf = new FS::Conf;
diff --git a/httemplate/elements/menu.html b/httemplate/elements/menu.html
index 4490517d0..d4a915e15 100644
--- a/httemplate/elements/menu.html
+++ b/httemplate/elements/menu.html
@@ -323,7 +323,7 @@ $tools_menu{'Ticketing'} = [ \%tools_ticketing, 'Ticketing tools' ]
$tools_menu{'Time Queue'} = [ $fsurl.'search/timeworked.html', 'View pending support time' ]
if $curuser->access_right('Time queue');
$tools_menu{'Attachments'} = [ $fsurl.'browse/cust_attachment.html', 'View customer attachments' ]
- if !$conf->config('disable_cust_attachment') and $curuser->access_right('View attachments');
+ if !$conf->config('disable_cust_attachment') and $curuser->access_right('View attachments') and $curuser->access_right('Browse attachments');
$tools_menu{'Importing'} = [ \%tools_importing, 'Import tools' ]
if $curuser->access_right('Import');
$tools_menu{'Exporting'} = [ \%tools_exporting, 'Export tools' ]