slightly better error handling than before?, RT#10574

1 files changed, 6 insertions, 0 deletions

diff --git a/FS/FS/svc_port.pm b/FS/FS/svc_port.pm
index befe8ca46..db1f539b8 100644
--- a/FS/FS/svc_port.pm
+++ b/FS/FS/svc_port.pm
@@ -273,6 +273,12 @@ sub graph_png {
           'order_by'  => "order by $_date asc",
         });
 
+        if ( ! scalar(@records) ) {
+          warn "$me no records returned for $serviceid\n";
+          return ''; #should actually return a blank png (or, even better, the
+                     # error message in the image)
+        }
+
         warn "$me ". scalar(@records). " records returned for $serviceid\n"
           if $DEBUG;